[#20640] Border/lasso selection zone "translated" when occlude geometry is on

Box select for mesh wrongly applied the transformation matrix (it wasn't done for Circle select and that worked correctly).

I've just commented and explained the removal, since comments in the matrix setting function seems to indicate that this should be needed (with the call removed, the situations that are noted as problematic still work fine).
This commit is contained in:
Martin Poirier
2010-01-11 19:52:03 +00:00
parent 491e365514
commit 393f53fc92

View File

@@ -1361,7 +1361,10 @@ static void do_mesh_box_select(ViewContext *vc, rcti *rect, int select, int exte
EM_deselect_all(vc->em);
}
ED_view3d_init_mats_rv3d(vc->obedit, vc->rv3d); /* for foreach's screen/vert projection */
/* XXX Don't think we need this, it break selection of transformed objects.
* Also, it's not done by Circle select and that works fine
*/
//ED_view3d_init_mats_rv3d(vc->obedit, vc->rv3d); /* for foreach's screen/vert projection */
bbsel= EM_init_backbuf_border(vc, rect->xmin, rect->ymin, rect->xmax, rect->ymax);
if(ts->selectmode & SCE_SELECT_VERTEX) {
@@ -1423,7 +1426,7 @@ static int view3d_borderselect_exec(bContext *C, wmOperator *op)
rect.xmax= RNA_int_get(op->ptr, "xmax");
rect.ymax= RNA_int_get(op->ptr, "ymax");
extend = RNA_boolean_get(op->ptr, "extend");
if(obedit==NULL && (paint_facesel_test(OBACT))) {
face_borderselect(C, obact, &rect, selecting, extend);
return OPERATOR_FINISHED;