griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

RNA: use is_dirty prefix for checking updates

Browse Source 
Common convention for read-only update checks
This commit is contained in:
Campbell Barton
2018-07-05 21:48:46 +02:00
parent a3f5d4cb14
commit 45fdf41be8
1 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
source/blender/makesrna/intern/rna_depsgraph.c
View File

@@ -143,27 +143,27 @@ static PointerRNA rna_DepsgraphUpdate_id_get(PointerRNA *ptr)
return rna_pointer_inherit_refine(ptr, &RNA_ID, ptr->data); return rna_pointer_inherit_refine(ptr, &RNA_ID, ptr->data);
} }
static int rna_DepsgraphUpdate_updated_transform_get(PointerRNA *ptr) static int rna_DepsgraphUpdate_is_dirty_transform_get(PointerRNA *ptr)
{ {
ID *id = ptr->data; ID *id = ptr->data;
return ((id->recalc & ID_RECALC_TRANSFORM) != 0); return ((id->recalc & ID_RECALC_TRANSFORM) == 0);
} }
static int rna_DepsgraphUpdate_updated_geometry_get(PointerRNA *ptr) static int rna_DepsgraphUpdate_is_dirty_geometry_get(PointerRNA *ptr)
{ {
ID *id = ptr->data; ID *id = ptr->data;
if (id->recalc & ID_RECALC_GEOMETRY) { if (id->recalc & ID_RECALC_GEOMETRY) {
return true; return false;
} }
if (GS(id->name) != ID_OB) { if (GS(id->name) != ID_OB) {
return false; return true;
} }
Object *object = (Object *)id; Object *object = (Object *)id;
ID *data = object->data; ID *data = object->data;
if (data == NULL) { if (data == NULL) {
return 0; return true;
} }
return ((data->recalc & ID_RECALC_ALL) != 0); return ((data->recalc & ID_RECALC_ALL) == 0);
} }
/* **************** Depsgraph **************** */ /* **************** Depsgraph **************** */
@@ -454,15 +454,15 @@ static void rna_def_depsgraph_update(BlenderRNA *brna)
RNA_def_property_clear_flag(prop, PROP_ANIMATABLE | PROP_EDITABLE); RNA_def_property_clear_flag(prop, PROP_ANIMATABLE | PROP_EDITABLE);
RNA_def_property_pointer_funcs(prop, "rna_DepsgraphUpdate_id_get", NULL, NULL, NULL); RNA_def_property_pointer_funcs(prop, "rna_DepsgraphUpdate_id_get", NULL, NULL, NULL);
prop = RNA_def_property(srna, "updated_transform", PROP_BOOLEAN, PROP_NONE); prop = RNA_def_property(srna, "is_dirty_transform", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_clear_flag(prop, PROP_ANIMATABLE | PROP_EDITABLE); RNA_def_property_clear_flag(prop, PROP_ANIMATABLE | PROP_EDITABLE);
RNA_def_property_ui_text(prop, "Transform", "Object transformation was updated"); RNA_def_property_ui_text(prop, "Transform", "Object transformation is not updated");
RNA_def_property_boolean_funcs(prop, "rna_DepsgraphUpdate_updated_transform_get", NULL); RNA_def_property_boolean_funcs(prop, "rna_DepsgraphUpdate_is_dirty_transform_get", NULL);
prop = RNA_def_property(srna, "updated_geometry", PROP_BOOLEAN, PROP_NONE); prop = RNA_def_property(srna, "is_dirty_geometry", PROP_BOOLEAN, PROP_NONE);
RNA_def_property_clear_flag(prop, PROP_ANIMATABLE | PROP_EDITABLE); RNA_def_property_clear_flag(prop, PROP_ANIMATABLE | PROP_EDITABLE);
RNA_def_property_ui_text(prop, "Geometry", "Object geometry was updated"); RNA_def_property_ui_text(prop, "Geometry", "Object geometry is not updated");
RNA_def_property_boolean_funcs(prop, "rna_DepsgraphUpdate_updated_geometry_get", NULL); RNA_def_property_boolean_funcs(prop, "rna_DepsgraphUpdate_is_dirty_geometry_get", NULL);
} }
static void rna_def_depsgraph(BlenderRNA *brna) static void rna_def_depsgraph(BlenderRNA *brna)