From 2cc56495f3ce9fb8d959c78f761602da019c958a Mon Sep 17 00:00:00 2001 From: Alessio Monti di Sopra Date: Wed, 24 Nov 2021 15:49:37 +0100 Subject: [PATCH 1/4] UI: Fix alignment for recently added/edited icons The patch slightly modifies two recently added icons "FILE_BLEND" and "CURRENT_FILE" to better align them to the pixel grid, and change the design of "FILE_BACKUP" to avoid alignment and readability issues, as well as avoiding the outline version of the Blender logo which violates the official logo guidelines. Differential revision: https://developer.blender.org/D13346 --- release/datafiles/blender_icons.svg | 131 +++++++++++------- .../blender_icons16/icon16_current_file.dat | Bin 1048 -> 1048 bytes .../blender_icons16/icon16_file_backup.dat | Bin 1048 -> 1048 bytes .../blender_icons16/icon16_file_blend.dat | Bin 1048 -> 1048 bytes .../blender_icons32/icon32_current_file.dat | Bin 4120 -> 4120 bytes .../blender_icons32/icon32_file_backup.dat | Bin 4120 -> 4120 bytes .../blender_icons32/icon32_file_blend.dat | Bin 4120 -> 4120 bytes 7 files changed, 80 insertions(+), 51 deletions(-) diff --git a/release/datafiles/blender_icons.svg b/release/datafiles/blender_icons.svg index a271a29b263..63e57a22b9d 100644 --- a/release/datafiles/blender_icons.svg +++ b/release/datafiles/blender_icons.svg @@ -17349,44 +17349,49 @@ style="color:#000000;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:medium;line-height:normal;font-family:sans-serif;font-variant-ligatures:normal;font-variant-position:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-feature-settings:normal;text-indent:0;text-align:start;text-decoration:none;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:#000000;letter-spacing:normal;word-spacing:normal;text-transform:none;writing-mode:lr-tb;direction:ltr;text-orientation:mixed;dominant-baseline:auto;baseline-shift:baseline;text-anchor:start;white-space:normal;shape-padding:0;clip-rule:nonzero;display:inline;overflow:visible;visibility:visible;isolation:auto;mix-blend-mode:normal;color-interpolation:sRGB;color-interpolation-filters:linearRGB;solid-color:#000000;solid-opacity:1;vector-effect:none;fill:#ffffff;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:1.15052;stroke-linecap:round;stroke-linejoin:miter;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:2.2;stroke-opacity:1;color-rendering:auto;image-rendering:auto;shape-rendering:auto;text-rendering:auto;enable-background:new" id="path4101-2-6-9-1_GP_dotdash" /> + id="g7580" + style="display:inline;enable-background:new"> + + id="path8597-7-0" + d="m 331.87142,629.24052 c 0,0.81936 -0.66423,1.48359 -1.48359,1.48359 -0.81937,0 -1.4836,-0.66422 -1.4836,-1.48359 0,-0.81937 0.66423,-1.4836 1.4836,-1.4836 0.81937,0 1.48359,0.66423 1.48359,1.4836 z" + style="opacity:1;vector-effect:none;fill:#ffffff;fill-opacity:1;stroke:none;stroke-width:1.72218;stroke-linecap:round;stroke-linejoin:round;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;paint-order:fill markers stroke" + inkscape:connector-curvature="0" + sodipodi:nodetypes="sssss" /> + id="path8595-5-9" + d="m 414.93725,78.999996 c -0.65344,-0.653443 -1.58833,0.255453 -0.88297,0.960812 L 415.18167,81 h -4.6057 c -0.88913,-0.01822 -0.88913,1.018254 0,1 l 2.19337,-0.004 -0.006,0.004 -3.27651,2.873468 c -0.64989,0.580999 0.2216,1.555837 0.87149,0.97484 L 412.00004,84.45 c 0,1.651946 1.15621,3.581251 3.47506,3.550001 C 417.79395,87.968751 419,86.250706 419,84.45 c 0,-1.800705 -1.00462,-2.558141 -1.45954,-3.013074 z M 415.5,82.2 c 1.22478,0 2.25,0.945047 2.25,2.25 0,1.304953 -1.05311,2.25 -2.25,2.25 -1.19689,0 -2.25,-0.960585 -2.25,-2.25 0,-1.289415 1.02522,-2.25 2.25,-2.25 z" + style="color:#000000;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:medium;line-height:normal;font-family:sans-serif;font-variant-ligatures:normal;font-variant-position:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-feature-settings:normal;text-indent:0;text-align:start;text-decoration:none;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:#000000;letter-spacing:normal;word-spacing:normal;text-transform:none;writing-mode:lr-tb;direction:ltr;text-orientation:mixed;dominant-baseline:auto;baseline-shift:baseline;text-anchor:start;white-space:normal;shape-padding:0;clip-rule:nonzero;display:inline;overflow:visible;visibility:visible;isolation:auto;mix-blend-mode:normal;color-interpolation:sRGB;color-interpolation-filters:linearRGB;solid-color:#000000;solid-opacity:1;vector-effect:none;fill:#ffffff;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:1.3066;stroke-linecap:round;stroke-linejoin:round;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;marker:none;paint-order:fill markers stroke;color-rendering:auto;image-rendering:auto;shape-rendering:auto;text-rendering:auto;enable-background:accumulate" /> + + id="g4103-6"> @@ -17394,60 +17399,84 @@ + transform="translate(499.00086,52.015151)" + id="g824" + style="display:inline;enable-background:new"> + + + + + + + + + id="path28215-0" + transform="translate(-337.99999,439.99995)" + d="m 501.49219,52.992188 c -0.27615,0.0043 -0.49651,0.223792 -0.49219,0.499938 v 1 c -0.01,0.676161 1.00956,0.676161 1,0 v -1 c 0.004,-0.282265 -0.22554,-0.504353 -0.50781,-0.499938 z m -7.00781,0.0067 c -0.12718,0.004 -0.248,0.0564 -0.3379,0.146484 l -4,4.001116 c -0.10126,0.101337 -0.1304,0.223491 -0.13086,0.345704 L 490,57.507812 v 1.984314 c -0.01,0.676161 1.00956,0.676161 1,0 v -1.5 h 3.5 c 0.27613,-3e-5 0.49997,-0.22387 0.5,-0.5 v -3.5 h 1.5 c 0.67616,0.0096 0.67616,-1.002805 0,-0.993242 h -2 v 0.002 c -0.005,-5e-6 -0.0101,-0.0021 -0.0156,-0.002 z m 4.01562,-0.0068 c -0.67616,-0.0096 -0.67616,1.009563 0,1 h 1 c 0.67616,0.0096 0.67616,-1.009563 0,-1 z m 2.99219,3.000062 c -0.27615,0.0043 -0.49651,0.223792 -0.49219,0.499938 v 1 c -0.01,0.676161 1.00956,0.676161 1,0 v -1 c 0.004,-0.282265 -0.22554,-0.504353 -0.50781,-0.499938 z m -11,5 c -0.27615,0.0043 -0.49651,0.223792 -0.49219,0.499938 v 1 c -0.01,0.676161 1.00956,0.676161 1,0 v -1 c 0.004,-0.282265 -0.22554,-0.504353 -0.50781,-0.499938 z m 0,3 c -0.27615,0.0043 -0.49651,0.223792 -0.49219,0.499938 v 1 c -0.01,0.676161 1.00956,0.676161 1,0 v -1 c 0.004,-0.282265 -0.22554,-0.504353 -0.50781,-0.499938 z M 492.5,65.992126 c -0.67616,-0.0096 -0.67616,1.009563 0,1 h 1 c 0.67616,0.0096 0.67616,-1.009563 0,-1 z m 3,0 c -0.67616,-0.0096 -0.67616,1.009563 0,1 h 1 c 0.67616,0.0096 0.67616,-1.009563 0,-1 z" + style="color:#000000;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;font-size:medium;line-height:normal;font-family:sans-serif;font-variant-ligatures:normal;font-variant-position:normal;font-variant-caps:normal;font-variant-numeric:normal;font-variant-alternates:normal;font-feature-settings:normal;text-indent:0;text-align:start;text-decoration:none;text-decoration-line:none;text-decoration-style:solid;text-decoration-color:#000000;letter-spacing:normal;word-spacing:normal;text-transform:none;writing-mode:lr-tb;direction:ltr;text-orientation:mixed;dominant-baseline:auto;baseline-shift:baseline;text-anchor:start;white-space:normal;shape-padding:0;clip-rule:nonzero;display:inline;overflow:visible;visibility:visible;opacity:1;isolation:auto;mix-blend-mode:normal;color-interpolation:sRGB;color-interpolation-filters:linearRGB;solid-color:#000000;solid-opacity:1;vector-effect:none;fill:#ffffff;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:1;stroke-linecap:round;stroke-linejoin:round;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;color-rendering:auto;image-rendering:auto;shape-rendering:auto;text-rendering:auto;enable-background:accumulate" + sodipodi:nodetypes="cccccccccccccccccccccccccccccccccccccccccccccccccccccccc" /> + + + + + transform="matrix(0.65914281,0,0,0.65914281,248.47102,-214.89549)" + id="g12839-3-5"> - - - - - + id="path2-6" + d="m 469,101 v 7.5 c 0,0.276 0.224,0.5 0.5,0.5 h 11 c 0.30423,0 0.5,-0.22782 0.5,-0.5 v -4 c 0,-0.65459 -1,-0.65682 -1,0 v 3.5 h -10 v -7 z m 4.48081,-6 c -0.151,0.004 -0.293,0.077 -0.384,0.197 l -3.95,3.949 c -0.314,0.315 -0.091,0.854 0.354,0.854 h 4 c 0.276,0 0.5,-0.224 0.5,-0.5 V 96 H 480.5 c 0.68512,0 0.64092,-1 0,-1 z" /> #;euX}Fe&P*tOozDNC`=2v+ z>b9J7EpVqz!nUY zMPImUg?2|*-DqAJ@LXA9w6e^N%$~1sxQD#P75*N2>b;_Hk57J|+sAm3*|Xilp3+yv zZk(|*Kj0&-KU2?+WgN{5 cM$*M-Aw$})OvVJPK=_xaFT9^$zmea60$+J?BLDyZ literal 1048 zcmb`F!3se^6o%(28!N<0-Le!C3kz9T+t_;rc>ya6+1ilUdjT)t2`E{UrKLBxzN33I zO`~ox^>yZ)`TzgU)Xf@WvTzBE$)}7N!W90oq9~fdA|ZYEoA{QHNk9+H(C4>jqJar? zAgyO{pTs{xtLw@plnkomCGpqP9M?Ow40Z6nU+)-yCqQ=sd);W>_pr6Ge(9MN(Vy)A z_V0VR+HXDjf+u6=>e0+$<1iK-Gdtr*--QE|G>3f!w>>hJ=mJaHTkpf5W!ev9}Ae&Gvh`nkl( zjLtcqS_l!$p<%7Wq3Y>5Uo5o+Ea3uHFtNVqklYmB^^EqZ-M|JuUB047EwvJ?A@9ue3{9SXT^FC8 zChS4(lCS7+i06mM_o&M|%iXp8YO;GMI~1?kK57-oVLh$nsvx@39ocyo)021C*VM*t ihwCq5nN4-%&C%oO*S&Vf$m&S6;_LtFU;TPV5&sW4?Qa19 literal 1048 zcmb`FJxc>Y5QaBKM2to710=N(8$kstgO#17m6AfNQltzDRu+l`A%gf7FijLmmtQF7 z^TG~HmYiqd!NbhXyzkuZ-c>^gRroH2(3lC~6t3Yvo-E6H(04qOui9+#c{qU%G^}os zTHkVu)OJ9=W%z_cs6z|xO{d6u!q0ja-r)9s6!?$PjG!IoRmiuX3_4q_z^{Glo4iHNiSoX{fqCQX ziSzqj?BC(h_s|{er~RTe9-T$^wl_^nUGx3_)0?JK4c$%Jqo(_O^fOY8t);Qt$8?78 e`8>}rji2E?KL5=hXKbK(kS>SZyYcV&YyJawfNwMa diff --git a/release/datafiles/blender_icons16/icon16_file_blend.dat b/release/datafiles/blender_icons16/icon16_file_blend.dat index f92b46ad44e7550cbc2d943e0bb13fb0a1f7085d..85a70be080ce0c3e6af2b57a577de8faf61e3603 100644 GIT binary patch literal 1048 zcmb`Fy-or_6h;RVTC$xsQV}UB?R*0ow^KT5qAfuZg9RN%vjsecFW?hEL$HuqAHhUP z$a=nHh77|FA;w8g=Kg(mX75g7j7cCX8B;$p<_hlNKUSXSBbWr7yWYgxu!J9YgG-mw zjz95z-zJyB8pd#KcloKS!`{-%hZm^86rQZDdnon{vpxC-`A?X`H#FfEbncDyzhZjD zsj0#Ov<7ejeK>{(c;BbDJre3(L36u<3+RFF)QRcImEi+oD|1?V&er_=oU>`vf)!|% zyrRPw_4;Pbu3MxcJ_P^$jKVtdr;4#}-j%B%Rs;RhO%Im~ch!V3`C*Tu8e3PW4}1JY VZ+o0^mq-6w0()mRv9k_|{{pPUgqZ*U literal 1048 zcmb`_ze_?<6u|Lo;8KG+w6xeD3NB8zI6CQ+t3z{RyA2J3Aov4GQpA5ED1yL6aC7Mo zXmx1_YL(abfCrA3_w)@t_;AlX_nhulmA zu5pKo=5-}E)!1J-OJR)-7Wl#3*0JB~XMcewNbe9!WKhB-zR=Ja#D4!7xfMR}i5v8= zMIAGYqWUGz`6-?u&pm2*MHcU9#pusd_l95GqKq!Skv-Bc-z4mj`>SfNtnBxGzdh5K znhE6It~3{SrAO}K1;wx)@*UX!Pd}_qa@4i`GjchM> X9vdI(-_4M3K9ITyk#}R?6F2??LnCt| diff --git a/release/datafiles/blender_icons32/icon32_current_file.dat b/release/datafiles/blender_icons32/icon32_current_file.dat index 63bbd668eb5d55ec6d8040cbe1a1ae2396cfdc8c..6709a64f29c6c935664b1a7ab5cc9c7b05981fae 100644 GIT binary patch literal 4120 zcmeH|ze)r#5XJ*)X<_Bx;tIjS&Q`%U5JUtKY%DD7?l=oAwD%1TtbGDs=G0a@-#|To zSvE(QnzNeVfbf^_+7(@Hpq(=Dc%Hz%79PQJuhKGPweyjxZ=4b4R+< z=dtRScun)+xk`0bUa61FTl-phvVUoB?Q7w|Spp|uqof=1mcE{A;lViqVZ5?<0B2x5 z=*gK}bq8f!?kzkxYd{-c1TSPyzbD?Be%)`Z86frzE~SSK^!@Xs#*7Du0}ts-?%`O^ z=`et+J`2No2Mx%3}k?H({fB3C>XsX}#Is8Vy zp@;o&c5Tmw-@<<@SK8K%`(-@5kgNVLn76@kTo=~F`=GjmnRyua+Dx6ild<*=`48aV zi$hsY>>8BxN3u@t=@C3=+N7&7R_YeX+=8qJS*Pvku?LoYjyXIx%jtMe)D=Bwb*UI? zTfm>W9Q{m9)vFGo=u%JX hU3<7=&b}9geD=Gc>Bh0z!%aaW=g<7R$GU%E{R54(7uEm( literal 4120 zcmeH}O)Ex06vuBNA`9}8P!gq-onk{aC>zSk#>R@pvyeh8iR9hJ2OwLed;uT9C-4cR zM8e~DbmwV|J9o~*eO65Ux_4&IIsgC6eeH;%r~}T+qNuApimo84fdBTn1NnS@4mL`_ z5;ZGB+f2-9329a8AK;-OLzd$;wJG)YLvh8-qrI4wK6T1q3>vi_h|N;Jk9yMH;TDcz z8oYj(%Tm9bdJo{XHwIRc_Jr}w^rb%au3d4fzwUY{fxg_&Y3+*#0<&KKK$>_wSMWf8 zB=%6{?v2|gPToJM&mZ%058Okjt-AF?eF_Hkr3P`6@Deh>d{G{VSLw$dCWwDlcvuUq z+sqfEUkVTCR}03E=19EuTFh$d{UintQ;>E)JTX5Ms!hxS>?_zMrr)kd-{(QJ$3eaw z@@>u8dG!AGyn6Y!^oLtv~t$oJ4Y4dJwoL@(P{Qqb?eA9P4__W2tBP8BujMu{^ zgghkb#~y~s9|YNRd);&kttDv>;`}C}wjs@fSKrhnU)GV-E=`Q@NK!NGfX{cBK_aD*K^7X0H11FXT<3)4)^&W^Xw0pt579ssDauVM+ JzP0|P@eg2n+zuv)H3M49!)*g!fY~arYZ>(NgO0PD z**CCVd3m_(eDeFi3RnO;y}nDtvI+5_r(i-w_{)*Jec#FbCpYEwFS9;q8hE=Nvn6S= zJ_MeFXJFjpmx#?4#g%$`Hi1Xh?9BG@IQZ=1tI{HFfnN@bUHz&!dHCYrDFSb5e(=ZZSJ|JU~*=cQZfrPWkV-3Yj-`jl_d z3G>nk`B+TtW{|yxSYM7qucPNG_1S&M&FWV!cMbiT(WJvQM8AuszA%qY(fJSiERO9% ztS-l)(bID!wGU3WeqSX{{a@;7zS{@;E~ec~{~1v~kI4DYkMRFeeVw_z`WJJ50Jy0J AmjD0& literal 4120 zcmeH|O^8lm6vwYIV?xGE#H`Glk8H+f6e}yDd@W=pS&+|2%1lO5qGV-5L-r!2M3IFN z`G~R{V_`?6gc^#{>-WFiGd+U{Wl(2Lf7V!{<4rhxkYdehT%JWfZMPIriAt>PCnO&)x>h_ z-wxm4Ug59CZi4gh1@1z7s0X=9`qZt36Hv2W`0L>-Y_*tciFd&>7zCaCF+bu-eQMT# zp6dgU-YS?5A7O_z#a{wDLG?|FV>{tJ9JD&u60f3vhPqotzkYl@?*VvWz3_K|W_%8x z;6CIx9eV_Ztk$)}tLW?h{0vK-8Gf@qRjk|bM__}qe#3fiv0jL;`uSSBKVnIJ)l+u~ z-hs`q4SzwATZunX>U)9MK#_05m;RVLOsuMY6SY@hbOzHS)&W0Youl`f^?_nt!U6hs#%{uOxC;4MuwG?Leg^2yJ_hesk9bvmy?=Dyb=H=9=poi> zGvLnzX}^NG7B5?JRrOn`y#YT#XUWGN^(QwA9>PnQQ`U6X=hdSI^pHIz1^*7T)XR!tJ9(oE-V75De+E2Z{4f%f%u}4GuLvecbL2oE;accS_x}$SheN}5cQ}xv8uAH>`kWKX|=dDjU z?psrvoWZv*7HdRbeNr>Tw0yZn^;0wWG-9#w=*MP=Y58*F)ep_!(}=|;q92;UdNyKX WGp2Ir=w2LeM6Xoam(uuG^M3#@`OTC7 diff --git a/release/datafiles/blender_icons32/icon32_file_blend.dat b/release/datafiles/blender_icons32/icon32_file_blend.dat index 478c67f875d5eafd2d5e26ff043b438e5a2759f0..25903bc87ee67654ab14979fe446879adee59b00 100644 GIT binary patch literal 4120 zcmeH~yK59t6viis1{={@K~n}XXrV^1@efcd5khQLNF#y?n!>_DA&sv>EG%q9uv0tJ zY9*RRv=M?SVj-fE7$4~R`<8o_%XlAiXYKUB$2s>qkMGQ6W_L4ERn-U>9jdA$>#FJz zsMdr3*1ZFrPG=h2YJjt`TSo6FxB*^+RqzqK0GGkGSf6|v{ zy}o`dpW>N&q9(e?`L2Uv-%f^RQP92qP|i4N1}ruYw*{;K*&5I;gI<2namvZQfUTA{ z50}&@zZ-l2&%k!C?;>ZjN#pCDf=MgFUkc=N`cq#2GVwmmz-u4bg3Tn}51xW2VBF&u zILn?JXC5x6zk!;EYIdgkcockg=PTYUJ^w!)UU~dgSNq90^YBT1)loA9Zn_zAzr1+P zoAnOf^p`z;&eg9OXC6MQ@7128-q+UH$6o$8XT5KFE_=@e@jQ^dv0C$RjrG+-{RH?5 z%yhkbym`Z%hrRP&&Z?2!Hr_m3k-qxqISBMlm@N_PvYF<^fw!(m_ifB_=HZI<)l1(F zun5e45Zni692AQ)yKb7kCz;i!W)pa6gIf3p^aQ_k;hX4hrcUox8@oqS?|JaAT`{?= ze!VAlX4W`(56tcm=od%S$p006<{Se0Y%;q>@W=N?bdf$1=qQ#HZ7(-{jR%UH||9 literal 4120 zcmeH|!An(95QlG;LJQL%1u07kN+|akXwmX;aW5j8d?~cJ5lXh*kyq2bj=C zky;wnrU=|fi%=|DL>5H#`sOkd$NS#7=bZOwr2`)`cV^D~=G}MSeLY#0^+50TEIYd+ z%Vr^KhAqqQK&4U{frkMeP(SuRZdpLr_7eR*pFXvHa39{mI;_AmxB%OH=Oj-(*C^{L zt8xAkdu)>pG0VBAC4-*jZ}_@}0SOc;5 zaKLKj$=#Bo+PLLiPc24&SZ92}56XG`Rn7gv=g%g7FWi7Lra?RnVyn<(dGq9A^pDdg z&z0B@ko!I*7uXA#g>Q$CAm4{Dtof6~W=BoeJcXdX&grN3vksE^axcUlYyC8_X^WrJ ze77{IoibhX z_#Rw_{JX|K0di&wLBJZ6K zU?!h$5-!3ukoTY2TY}a`^f^CZ!xH@x{rhWaOO9I9=ciAey|0jBuW9b|X{YFGZ!`0D zd*~!T3uey=+RC(3^?kF@X@aLFjGuv;?|a{jM)GJKakQThSN+Z!nICf&&6^R-*fFpU|9Q-DVc^#cTRnVZ!=-zIZNlZF53>Ql~e# zL(CkvCq+MI2X}T%oT?w%Ax6{fsYkzT2X}T%T(7=whZs$_rxAVM4mLBzyE~=E=*aKl PPKsWkcQjRVv-JN3uy`=n From 64d9291d26b4a855c7891a02b118c450b9b2709a Mon Sep 17 00:00:00 2001 From: Brecht Van Lommel Date: Tue, 23 Nov 2021 15:51:46 +0100 Subject: [PATCH 2/4] Cleanup: formatting --- extern/hipew/src/hipew.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/extern/hipew/src/hipew.c b/extern/hipew/src/hipew.c index 593901aad9c..010c361fa46 100644 --- a/extern/hipew/src/hipew.c +++ b/extern/hipew/src/hipew.c @@ -219,17 +219,17 @@ static int hipewHasOldDriver(const char *hip_path) { DWORD verHandle = 0; DWORD verSize = GetFileVersionInfoSize(hip_path, &verHandle); int old_driver = 0; - if(verSize != 0) { + if (verSize != 0) { LPSTR verData = (LPSTR)malloc(verSize); - if(GetFileVersionInfo(hip_path, verHandle, verSize, verData)) { + if (GetFileVersionInfo(hip_path, verHandle, verSize, verData)) { LPBYTE lpBuffer = NULL; UINT size = 0; - if(VerQueryValue(verData, "\\", (VOID FAR * FAR *)&lpBuffer, &size)) { - if(size) { + if (VerQueryValue(verData, "\\", (VOID FAR * FAR *)&lpBuffer, &size)) { + if (size) { VS_FIXEDFILEINFO *verInfo = (VS_FIXEDFILEINFO *)lpBuffer; /* Magic value from * https://docs.microsoft.com/en-us/windows/win32/api/verrsrc/ns-verrsrc-vs_fixedfileinfo */ - if(verInfo->dwSignature == 0xfeef04bd) { + if (verInfo->dwSignature == 0xfeef04bd) { unsigned int fileVersionLS0 = (verInfo->dwFileVersionLS >> 16) & 0xffff; unsigned int fileversionLS1 = (verInfo->dwFileVersionLS >> 0) & 0xffff; /* Corresponds to versions older than AMD Radeon Pro 21.Q4. */ From 56b068a6647f51cc00f3fbfa262d8ffc38f15cf9 Mon Sep 17 00:00:00 2001 From: Brecht Van Lommel Date: Wed, 24 Nov 2021 15:47:46 +0100 Subject: [PATCH 3/4] Fix inconsistent UI terminology for tiling option Was meant to be Use instead of Using. --- intern/cycles/blender/addon/properties.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/intern/cycles/blender/addon/properties.py b/intern/cycles/blender/addon/properties.py index e74619d0c4b..19580914f19 100644 --- a/intern/cycles/blender/addon/properties.py +++ b/intern/cycles/blender/addon/properties.py @@ -770,7 +770,7 @@ class CyclesRenderSettings(bpy.types.PropertyGroup): ) use_auto_tile: BoolProperty( - name="Using Tiling", + name="Use Tiling", description="Render high resolution images in tiles to reduce memory usage, using the specified tile size. Tiles are cached to disk while rendering to save memory", default=True, ) From a07089dcb10d8f0265220bf5abe07dca03097fe1 Mon Sep 17 00:00:00 2001 From: Hans Goudey Date: Wed, 24 Nov 2021 10:39:33 -0500 Subject: [PATCH 4/4] Fix T92120 (partially): No bone custom shape with curve object meshes This part of the drawing code assumes that the bone custom object has only one evaluated geometry component, and it also uses the object type to check which data to draw, with the functions like `DRW_cache_object_surface_get` that just take an object input. Those functions usually work on evaluated objects, which use the instancing system to access a temporary object with `object.data` replaced for data types that don't match the original object. That assumption used to work, but now curve, point cloud, or volume objects can have an evaluated mesh which is not accessed with the same object for render engine drawing. The "correct" solution for the way this code is structured would be to loop through all of the geometry components and try to get GPU batches from every one of them. However, that significantly increases complexity in an area that should probably be refactored anyway. This patch treats the mesh as a special case, and only draws the evaluated mesh. The **best** solution in my opinion might be refactoring this area to use the instancing system with some sort of viewport-only flag so the custom shape instances aren't added in the render. The solution is "partial" because the "Wireframe" option only works for meshes from mesh objects, even after this fix, and because other data besides meshes is not displayed at all. Differential Revision: https://developer.blender.org/D13038 --- .../draw/engines/overlay/overlay_armature.c | 21 +++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/source/blender/draw/engines/overlay/overlay_armature.c b/source/blender/draw/engines/overlay/overlay_armature.c index 1da682ff01b..50d8fe3065d 100644 --- a/source/blender/draw/engines/overlay/overlay_armature.c +++ b/source/blender/draw/engines/overlay/overlay_armature.c @@ -26,6 +26,7 @@ #include "DNA_armature_types.h" #include "DNA_constraint_types.h" +#include "DNA_mesh_types.h" #include "DNA_object_types.h" #include "DNA_scene_types.h" #include "DNA_view3d_types.h" @@ -39,6 +40,7 @@ #include "BKE_armature.h" #include "BKE_deform.h" #include "BKE_modifier.h" +#include "BKE_object.h" #include "DEG_depsgraph_query.h" @@ -52,6 +54,8 @@ #include "overlay_private.h" +#include "draw_cache_impl.h" + #define BONE_VAR(eBone, pchan, var) ((eBone) ? (eBone->var) : (pchan->var)) #define BONE_FLAG(eBone, pchan) ((eBone) ? (eBone->flag) : (pchan->bone->flag)) @@ -535,13 +539,22 @@ static void drw_shgroup_bone_custom_solid(ArmatureDrawContext *ctx, const float outline_color[4], Object *custom) { + /* The custom object is not an evaluated object, so its object->data field hasn't been replaced + * by #data_eval. This is bad since it gives preference to an object's evaluated mesh over any + * other data type, but supporting all evaluated geometry components would require a much larger + * refactor of this area. */ + Mesh *mesh = BKE_object_get_evaluated_mesh(custom); + if (mesh == NULL) { + return; + } + /* TODO(fclem): arg... less than ideal but we never iter on this object * to assure batch cache is valid. */ - drw_batch_cache_validate(custom); + DRW_mesh_batch_cache_validate(mesh); - struct GPUBatch *surf = DRW_cache_object_surface_get(custom); - struct GPUBatch *edges = DRW_cache_object_edge_detection_get(custom, NULL); - struct GPUBatch *ledges = DRW_cache_object_loose_edges_get(custom); + struct GPUBatch *surf = DRW_mesh_batch_cache_get_surface(mesh); + struct GPUBatch *edges = DRW_mesh_batch_cache_get_edge_detection(mesh, NULL); + struct GPUBatch *ledges = DRW_mesh_batch_cache_get_loose_edges(mesh); BoneInstanceData inst_data; DRWCallBuffer *buf;