Cleanup: use const args & variables, remove redundant checks

- Declare const variables & arguments.
- Remove redundant null checks.
- Remove break after return.
- Replace suspicious "&" with "&&".

source/blender/blenlib/intern/array_store.cc

@@ -982,7 +982,7 @@ static const BChunkRef *table_lookup(const BArrayInfo *info,
       if (cref->link->key == key)
 #  endif
       {
-        BChunk *chunk_test = cref->link;
+        const BChunk *chunk_test = cref->link;
         if (chunk_test->data_len <= size_left) {
           if (bchunk_data_compare_unchecked(chunk_test, data, data_len, offset)) {
             /* We could remove the chunk from the table, to avoid multiple hits. */
@@ -1176,7 +1176,7 @@ static BChunkList *bchunk_list_from_data_merge(const BArrayInfo *info,
     while ((cref->prev != nullptr) && (cref != cref_match_first) &&
            (cref->link->data_len <= data_len - i_prev))
     {
-      BChunk *chunk_test = cref->link;
+      const BChunk *chunk_test = cref->link;
       size_t offset = data_len - chunk_test->data_len;
       if (bchunk_data_compare(chunk_test, data, data_len, offset)) {
         data_len = offset;
@@ -1607,7 +1607,7 @@ size_t BLI_array_store_calc_size_compacted_get(const BArrayStore *bs)
 {
   size_t size_total = 0;
   BLI_mempool_iter iter;
-  BChunk *chunk;
+  const BChunk *chunk;
   BLI_mempool_iternew(bs->memory.chunk, &iter);
   while ((chunk = static_cast<BChunk *>(BLI_mempool_iterstep(&iter)))) {
     BLI_assert(chunk->users > 0);