From 60d88f46ba4ec9d8e8aefddb5babc94f332bb60d Mon Sep 17 00:00:00 2001 From: Jesse Yurkovich Date: Mon, 4 Nov 2024 04:38:15 +0100 Subject: [PATCH] Fix: STL import crash when unable to open or read file Regression from d1455c41389302eadeeae1d291b482c1fa499a9f Ensure we return from `importer_main` if no mesh could be loaded with `read_stl_file` (e.g. `bpy.ops.wm.stl_import(filepath="")`) Pull Request: https://projects.blender.org/blender/blender/pulls/129759 --- source/blender/io/stl/importer/stl_import.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/source/blender/io/stl/importer/stl_import.cc b/source/blender/io/stl/importer/stl_import.cc index 0a2d47db12a..c904d1452e3 100644 --- a/source/blender/io/stl/importer/stl_import.cc +++ b/source/blender/io/stl/importer/stl_import.cc @@ -120,6 +120,9 @@ void importer_main(Main *bmain, BLI_path_extension_strip(ob_name); Mesh *mesh = read_stl_file(import_params); + if (!mesh) { + return; + } Mesh *mesh_in_main = BKE_mesh_add(bmain, ob_name); BKE_mesh_nomain_to_mesh(mesh, mesh_in_main, nullptr);