From fca5bcbe46214173da37cf45a9b9ab650472d2ef Mon Sep 17 00:00:00 2001 From: Philipp Oeser Date: Fri, 17 Oct 2025 10:21:01 +0200 Subject: [PATCH] Fix #146250: Some gizmos/widgets are continuously running updates Reported for the geometry nodes gizmos, but in general `cage2d`, `cage3d` and `arrow` were affected (so for example Forcefield arrows, UV editing transform tool, Lamp angle gizmo, ...) `gizmo_cage3d_modal`, `gizmo_cage2d_modal` and `gizmo_arrow_modal` add a `WM_event_add_mousemove` which ... lets the modal run even if the mouse does **not** move... This seems to date back to d8f931c9b7db in the arrow gizmo, others probably just copied from there (not the DialGizmo though), did not do further git archeology. Propose to just remove `WM_event_add_mousemove` (even though there _might_ still be reasons for this -- could not spot any though...) Pull Request: https://projects.blender.org/blender/blender/pulls/146310 --- .../blender/editors/gizmo_library/gizmo_types/arrow3d_gizmo.cc | 1 - source/blender/editors/gizmo_library/gizmo_types/cage2d_gizmo.cc | 1 - source/blender/editors/gizmo_library/gizmo_types/cage3d_gizmo.cc | 1 - 3 files changed, 3 deletions(-) diff --git a/source/blender/editors/gizmo_library/gizmo_types/arrow3d_gizmo.cc b/source/blender/editors/gizmo_library/gizmo_types/arrow3d_gizmo.cc index a474fd47f5b..4c9daa1ab06 100644 --- a/source/blender/editors/gizmo_library/gizmo_types/arrow3d_gizmo.cc +++ b/source/blender/editors/gizmo_library/gizmo_types/arrow3d_gizmo.cc @@ -412,7 +412,6 @@ static wmOperatorStatus gizmo_arrow_modal(bContext *C, /* tag the region for redraw */ ED_region_tag_redraw_editor_overlays(region); - WM_event_add_mousemove(CTX_wm_window(C)); return OPERATOR_RUNNING_MODAL; } diff --git a/source/blender/editors/gizmo_library/gizmo_types/cage2d_gizmo.cc b/source/blender/editors/gizmo_library/gizmo_types/cage2d_gizmo.cc index 4d330742ced..f5ae69eefbb 100644 --- a/source/blender/editors/gizmo_library/gizmo_types/cage2d_gizmo.cc +++ b/source/blender/editors/gizmo_library/gizmo_types/cage2d_gizmo.cc @@ -1360,7 +1360,6 @@ static wmOperatorStatus gizmo_cage2d_modal(bContext *C, /* tag the region for redraw */ ED_region_tag_redraw_editor_overlays(CTX_wm_region(C)); - WM_event_add_mousemove(CTX_wm_window(C)); return OPERATOR_RUNNING_MODAL; } diff --git a/source/blender/editors/gizmo_library/gizmo_types/cage3d_gizmo.cc b/source/blender/editors/gizmo_library/gizmo_types/cage3d_gizmo.cc index 25870f3fde2..600d617333d 100644 --- a/source/blender/editors/gizmo_library/gizmo_types/cage3d_gizmo.cc +++ b/source/blender/editors/gizmo_library/gizmo_types/cage3d_gizmo.cc @@ -590,7 +590,6 @@ static wmOperatorStatus gizmo_cage3d_modal(bContext *C, /* tag the region for redraw */ ED_region_tag_redraw_editor_overlays(CTX_wm_region(C)); - WM_event_add_mousemove(CTX_wm_window(C)); return OPERATOR_RUNNING_MODAL; }