griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #129142: GPv3: gesture select tools selecting only right handles

Browse Source 
When selection type is set/and for gesture selection tools, Instead of
current attribute, all three selection attributes (`.selection`, `left_handle`,
`right_handle`) are reset in every iteration of for loop.

Pull Request: https://projects.blender.org/blender/blender/pulls/129147
This commit is contained in:
Pratik Borhade
2024-10-18 15:32:53 +02:00
committed by Falk David
parent 49bfcbc06d
commit 74129b648b
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
source/blender/editors/grease_pencil/intern/grease_pencil_select.cc
View File

@@ -265,13 +265,9 @@ bool selection_update(const ViewContext *vc,
/* Modes that un-set all elements not in the mask. */ /* Modes that un-set all elements not in the mask. */
if (ELEM(sel_op, SEL_OP_SET, SEL_OP_AND)) { if (ELEM(sel_op, SEL_OP_SET, SEL_OP_AND)) {
ed::curves::foreach_selection_attribute_writer( bke::GSpanAttributeWriter selection =
curves, selection_domain, [&](bke::GSpanAttributeWriter &writer) { curves.attributes_for_write().lookup_for_write_span(attribute_name);
for (const int element_i : IndexRange(writer.span.size())) { ed::curves::fill_selection_false(selection.span);
ed::curves::apply_selection_operation_at_index(
writer.span, element_i, SEL_OP_SUB);
}
});
} }
if (use_segment_selection) { if (use_segment_selection) {