From 765e38677a11d89b177b7c09dd60d8545448a52a Mon Sep 17 00:00:00 2001 From: Harley Acheson Date: Wed, 8 Oct 2025 20:58:42 +0200 Subject: [PATCH] Fix: Default Collection Color Always White With #126307 the default collection color (not set to a specific one), set in Icon Colors / Collection, is always white. This PR restores the correct behavior of following the theme color (an error in the SVG source). And does so immediately (change in property_update). Pull Request: https://projects.blender.org/blender/blender/pulls/147651 --- release/datafiles/icons_svg/outliner_collection.svg | 2 +- source/blender/makesrna/intern/rna_userdef.cc | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/release/datafiles/icons_svg/outliner_collection.svg b/release/datafiles/icons_svg/outliner_collection.svg index 35a323ba722..4384aa1b03e 100644 --- a/release/datafiles/icons_svg/outliner_collection.svg +++ b/release/datafiles/icons_svg/outliner_collection.svg @@ -1 +1 @@ - \ No newline at end of file + \ No newline at end of file diff --git a/source/blender/makesrna/intern/rna_userdef.cc b/source/blender/makesrna/intern/rna_userdef.cc index e4c0c4f01b0..ad0718f1d46 100644 --- a/source/blender/makesrna/intern/rna_userdef.cc +++ b/source/blender/makesrna/intern/rna_userdef.cc @@ -2182,7 +2182,7 @@ static void rna_def_userdef_theme_ui(BlenderRNA *brna) RNA_def_property_float_sdna(prop, nullptr, "icon_collection"); RNA_def_property_array(prop, 4); RNA_def_property_ui_text(prop, "Collection", ""); - RNA_def_property_update(prop, 0, "rna_userdef_theme_update"); + RNA_def_property_update(prop, 0, "rna_userdef_gpu_update"); prop = RNA_def_property(srna, "icon_object", PROP_FLOAT, PROP_COLOR_GAMMA); RNA_def_property_float_sdna(prop, nullptr, "icon_object"); @@ -4086,7 +4086,7 @@ static void rna_def_userdef_theme_collection_color(BlenderRNA *brna) RNA_def_property_float_sdna(prop, nullptr, "color"); RNA_def_property_array(prop, 3); RNA_def_property_ui_text(prop, "Color", "Collection Color Tag"); - RNA_def_property_update(prop, 0, "rna_userdef_theme_update"); + RNA_def_property_update(prop, 0, "rna_userdef_gpu_update"); } static void rna_def_userdef_theme_strip_color(BlenderRNA *brna)