From 792c29e52f3d2f63bdfd0bad54dff4245dc508a4 Mon Sep 17 00:00:00 2001
From: Campbell Barton <campbell@blender.org>
Date: Fri, 6 Sep 2024 16:28:36 +1000
Subject: [PATCH] Fix uninitialized memory use rendering from the sequencer

SeqRenderData::is_playing & is_scrubbing used uninitialized stack
memory, seq_prefetch_start(..) read both values.

Resolve by setting defaults.
---
 source/blender/sequencer/SEQ_render.hh | 40 +++++++++++++-------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/source/blender/sequencer/SEQ_render.hh b/source/blender/sequencer/SEQ_render.hh
index 61636b2595a..b092885657d 100644
--- a/source/blender/sequencer/SEQ_render.hh
+++ b/source/blender/sequencer/SEQ_render.hh
@@ -25,29 +25,29 @@ enum eSeqTaskId {
 };
 
 struct SeqRenderData {
-  Main *bmain;
-  Depsgraph *depsgraph;
-  Scene *scene;
-  int rectx;
-  int recty;
-  int preview_render_size;
-  bool use_proxies;
-  bool ignore_missing_media;
-  int for_render;
-  int motion_blur_samples;
-  float motion_blur_shutter;
-  bool skip_cache;
-  bool is_proxy_render;
-  bool is_prefetch_render;
-  bool is_playing;
-  bool is_scrubbing;
-  int view_id;
+  Main *bmain = nullptr;
+  Depsgraph *depsgraph = nullptr;
+  Scene *scene = nullptr;
+  int rectx = 0;
+  int recty = 0;
+  int preview_render_size = 0;
+  bool use_proxies = false;
+  bool ignore_missing_media = false;
+  int for_render = 0;
+  int motion_blur_samples = 0;
+  float motion_blur_shutter = 0.0f;
+  bool skip_cache = false;
+  bool is_proxy_render = false;
+  bool is_prefetch_render = false;
+  bool is_playing = false;
+  bool is_scrubbing = false;
+  int view_id = 0;
   /* ID of task for assigning temp cache entries to particular task(thread, etc.) */
-  eSeqTaskId task_id;
+  eSeqTaskId task_id = SEQ_TASK_MAIN_RENDER;
 
   /* special case for OpenGL render */
-  GPUOffScreen *gpu_offscreen;
-  GPUViewport *gpu_viewport;
+  GPUOffScreen *gpu_offscreen = nullptr;
+  GPUViewport *gpu_viewport = nullptr;
   // int gpu_samples;
   // bool gpu_full_samples;
 };