From 79ed05b29f5bb8a010ee7cbbb33033b95103e5c8 Mon Sep 17 00:00:00 2001 From: Philipp Oeser Date: Wed, 6 Dec 2023 14:13:07 +0100 Subject: [PATCH] Fix #115830: Poly Build tool crash with clipping borders Since 02ee5a769366 we cant call `ED_view3d_win_to_ray_clipped_ex` with null `r_ray_end`, `ED_view3d_clip_segment` relies on it. To fix this, just pass a dummy from `ED_view3d_win_to_ray_clipped`. Pull Request: https://projects.blender.org/blender/blender/pulls/115840 --- source/blender/editors/space_view3d/view3d_project.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source/blender/editors/space_view3d/view3d_project.cc b/source/blender/editors/space_view3d/view3d_project.cc index 1d898e70113..cdcf8aa145d 100644 --- a/source/blender/editors/space_view3d/view3d_project.cc +++ b/source/blender/editors/space_view3d/view3d_project.cc @@ -399,8 +399,9 @@ bool ED_view3d_win_to_ray_clipped(Depsgraph *depsgraph, float r_ray_normal[3], const bool do_clip_planes) { + float ray_end_dummy[3]; return ED_view3d_win_to_ray_clipped_ex( - depsgraph, region, v3d, mval, do_clip_planes, nullptr, r_ray_normal, r_ray_start, nullptr); + depsgraph, region, v3d, mval, do_clip_planes, nullptr, r_ray_normal, r_ray_start, ray_end_dummy); } void ED_view3d_win_to_ray(const ARegion *region,