griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix: Nodes: copied node not always added to nodes_by_id

Browse Source
This commit is contained in:
Jacques Lucke
2025-08-02 11:34:09 +02:00
parent 644a1791b9
commit 9fd877e174
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/blenkernel/intern/node.cc
View File

@@ -163,7 +163,6 @@ static void ntree_copy_data(Main * /*bmain*/,
/* Don't find a unique name for every node, since they should have valid names already. */ /* Don't find a unique name for every node, since they should have valid names already. */
bNode *new_node = node_copy_with_mapping( bNode *new_node = node_copy_with_mapping(
ntree_dst, *src_node, flag_subdata, src_node->name, src_node->identifier, socket_map); ntree_dst, *src_node, flag_subdata, src_node->name, src_node->identifier, socket_map);
dst_runtime.nodes_by_id.add_new(new_node);
new_node->runtime->index_in_tree = i; new_node->runtime->index_in_tree = i;
} }
@@ -3361,6 +3360,7 @@ bNode *node_copy_with_mapping(bNodeTree *dst_tree,
*node_dst = node_src; *node_dst = node_src;
node_dst->runtime = MEM_new<bNodeRuntime>(__func__); node_dst->runtime = MEM_new<bNodeRuntime>(__func__);
if (dst_unique_name) { if (dst_unique_name) {
BLI_assert(dst_unique_name->size() < sizeof(node_dst->name));
STRNCPY_UTF8(node_dst->name, dst_unique_name->c_str()); STRNCPY_UTF8(node_dst->name, dst_unique_name->c_str());
} }
else if (dst_tree) { else if (dst_tree) {
@@ -3368,6 +3368,9 @@ bNode *node_copy_with_mapping(bNodeTree *dst_tree,
} }
if (dst_unique_identifier) { if (dst_unique_identifier) {
node_dst->identifier = *dst_unique_identifier; node_dst->identifier = *dst_unique_identifier;
if (dst_tree) {
dst_tree->runtime->nodes_by_id.add_new(node_dst);
}
} }
else if (dst_tree) { else if (dst_tree) {
node_unique_id(*dst_tree, *node_dst); node_unique_id(*dst_tree, *node_dst);