From a67b5f6f6364146d824e9930d8c11130e11dc9bc Mon Sep 17 00:00:00 2001 From: Hans Goudey Date: Thu, 19 Dec 2024 02:42:14 +0100 Subject: [PATCH] Fix #131316: Edit overlays rendered for geometry instances Geometry instances shouldn't be drawn with cage overlays or other edit mode overlays since they don't necessarily correspond to original data. In this case the draw manager thought they were in edit mode because the object data is copied from the instance parent-- we need _some_ object for rendering. Pull Request: https://projects.blender.org/blender/blender/pulls/132081 --- source/blender/draw/intern/draw_manager_c.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source/blender/draw/intern/draw_manager_c.cc b/source/blender/draw/intern/draw_manager_c.cc index 297d9a86370..9b1bd0f191f 100644 --- a/source/blender/draw/intern/draw_manager_c.cc +++ b/source/blender/draw/intern/draw_manager_c.cc @@ -594,7 +594,9 @@ static void duplidata_key_free(void *key) drw_batch_cache_generate_requested(dupli_key->ob); } else { + /* Geometry instances shouldn't be rendered with edit mode overlays. */ Object temp_object = blender::dna::shallow_copy(*dupli_key->ob); + temp_object.mode = OB_MODE_OBJECT; blender::bke::ObjectRuntime runtime = *dupli_key->ob->runtime; temp_object.runtime = &runtime;