From bde991df9ed2d9a1bd54eecd09eb6a7ab0bea4fc Mon Sep 17 00:00:00 2001 From: Kent Mein Date: Sat, 13 Jun 2009 22:31:14 +0000 Subject: [PATCH] coverity issue CID: 275 Checker: FORWARD_NULL (help) File: base/src/source/blender/gpu/intern/gpu_extensions.c Function: GPU_shader_create Description: Variable "fragcode" tracked as NULL was passed to a function that dereferences it. fix provided by Brecht. :) Kent --- source/blender/gpu/intern/gpu_extensions.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/source/blender/gpu/intern/gpu_extensions.c b/source/blender/gpu/intern/gpu_extensions.c index 7654c67419b..70192f44ceb 100644 --- a/source/blender/gpu/intern/gpu_extensions.c +++ b/source/blender/gpu/intern/gpu_extensions.c @@ -746,7 +746,9 @@ GPUShader *GPU_shader_create(const char *vertexcode, const char *fragcode, /*GPU glGetObjectParameterivARB(shader->object, GL_OBJECT_LINK_STATUS_ARB, &status); if (!status) { glGetInfoLogARB(shader->object, sizeof(log), &length, log); - shader_print_errors("linking", log, fragcode); + if (fragecode) shader_print_errors("linking", log, fragcode); + else if (vertexcode) shader_print_errors("linking", log, vertexcode); + else if (libcode) shader_print_errors("linking", log, libcode); GPU_shader_free(shader); return NULL;