From cfd04172c9bccdecb8f8ced963ee7ab3f1828560 Mon Sep 17 00:00:00 2001 From: Sergey Sharybin Date: Thu, 14 Aug 2025 17:51:52 +0200 Subject: [PATCH] Fix #144521: Unable to fetch LFS objects on `make update` with Glthub mirror The setting is called `lfs.remote.searchall`, the `remote` part of it being an exact string, it is not to be expanded with the name of the remote. Whenever name of the remote is to be used Git documentation uses `` syntax. Tested by triggering the original issue (clone the Github mirror, make update, wait for a new LFS object appear in the upstream, make update again). Before this change the LFS object will not be fetched, and based on the Git Curl's log only the github origin was used to fetch LFS object, none other remotes were tried. Also confirmed by checking the Git-LFS code: https://github.com/git-lfs/git-lfs/blob/v3.7.0/config/config.go#L232 Pull Request: https://projects.blender.org/blender/blender/pulls/144574 --- build_files/utils/make_update.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build_files/utils/make_update.py b/build_files/utils/make_update.py index fd93c5e64df..51eb110f67c 100755 --- a/build_files/utils/make_update.py +++ b/build_files/utils/make_update.py @@ -647,7 +647,7 @@ def lfs_fallback_setup(args: argparse.Namespace) -> None: for remote in remotes: url = make_utils.git_get_remote_url(args.git_command, remote) if "projects.blender.org" not in url and "git.blender.org" not in url: - make_utils.git_set_config(args.git_command, f"lfs.{remote}.searchall", "true") + make_utils.git_set_config(args.git_command, "lfs.remote.searchall", "true") else: add_fallback_remote = False