griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #144639: light missing update because it was disabled

Browse Source 
the `light->is_enabled` check was only intended for background light,
for other light types we need to recompute the contribution at each
update.
This commit is contained in:
Weizhen Huang
2025-08-18 11:33:38 +02:00
committed by Weizhen Huang
parent da7bcfc642
commit d866517708
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
intern/cycles/scene/light.cpp
View File

@@ -157,7 +157,7 @@ bool Light::has_contribution(const Scene *scene, const Object *object)
return false;
}
if (light_type == LIGHT_BACKGROUND) {
return true;
return is_enabled;
}
if (light_type == LIGHT_AREA) {
if ((get_sizeu() * get_sizev() * get_size() == 0.0f) ||
@@ -264,13 +264,12 @@ void LightManager::test_enabled_lights(Scene *scene)
}
Light *light = static_cast<Light *>(object->get_geometry());
light->is_enabled = light->has_contribution(scene, object);
has_portal |= light->is_portal;
if (!light->is_enabled) {
continue;
}
light->is_enabled = light->has_contribution(scene, object);
has_portal |= light->is_portal;
if (light->light_type == LIGHT_BACKGROUND) {
background_lights.push_back(light);
}