griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix (studio-reported) RNA allowing to rename linked IDs.

Browse Source 
There is no reason to allow this currently, and the underlying code is
not designed to support it right now.

Kept liboverrides IDs names editable though through RNA API, think this can
be valuable for advanced processing or debugging.
This commit is contained in:
Bastien Montagne
2024-02-06 11:58:44 +01:00
parent 9a1651533d
commit dbfd54d7c8
1 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
source/blender/makesrna/intern/rna_ID.cc
View File

@@ -213,6 +213,8 @@ const IDFilterEnumPropertyItem rna_enum_id_type_filter_items[] = {
# include "BLI_listbase.h"
# include "BLI_math_base.h"
# include "BLT_translation.h"
# include "BLO_readfile.h"
# include "BKE_anim_data.h"
@@ -283,9 +285,11 @@ int rna_ID_name_length(PointerRNA *ptr)
void rna_ID_name_set(PointerRNA *ptr, const char *value)
{
ID *id = (ID *)ptr->data;
BLI_assert(BKE_id_is_in_global_main(id));
BLI_assert(!ID_IS_LINKED(id));
BKE_main_namemap_remove_name(G_MAIN, id, id->name + 2);
BLI_strncpy_utf8(id->name + 2, value, sizeof(id->name) - 2);
BLI_assert(BKE_id_is_in_global_main(id));
BKE_libblock_ensure_unique_name(G_MAIN, id);
if (GS(id->name) == ID_OB) {
@@ -296,17 +300,33 @@ void rna_ID_name_set(PointerRNA *ptr, const char *value)
}
}
static int rna_ID_name_editable(PointerRNA *ptr, const char ** /*r_info*/)
static int rna_ID_name_editable(PointerRNA *ptr, const char **r_info)
{
ID *id = (ID *)ptr->data;
/* NOTE: For the time being, allow rename of local liboverrides from the RNA API.
* While this is not allowed from the UI, this should work with modern liboverride code,
* and could be useful in some cases. */
if (ID_IS_LINKED(id)) {
if (r_info) {
*r_info = N_("Linked data-blocks cannot be renamed");
}
return 0;
}
if (GS(id->name) == ID_VF) {
VFont *vfont = (VFont *)id;
if (BKE_vfont_is_builtin(vfont)) {
if (r_info) {
*r_info = N_("Built-in fonts cannot be renamed");
}
return 0;
}
}
else if (!BKE_id_is_in_global_main(id)) {
if (r_info) {
*r_info = N_("Datablocks not in global Main data-base cannot be renamed");
}
return 0;
}