From de63022ca089f387510c5191ecb4e8ea7dce7342 Mon Sep 17 00:00:00 2001 From: Hans Goudey Date: Thu, 3 Jul 2025 16:11:29 -0400 Subject: [PATCH] Cleanup: Remove unnecessary SDNA info for node tool flags These all have getters and setters anyway. The flag for "wait for click" was wrong, even though that dicn't cause an observable bug (AFAIK). --- source/blender/makesrna/intern/rna_nodetree.cc | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/source/blender/makesrna/intern/rna_nodetree.cc b/source/blender/makesrna/intern/rna_nodetree.cc index ac4707fff88..bef63528e8a 100644 --- a/source/blender/makesrna/intern/rna_nodetree.cc +++ b/source/blender/makesrna/intern/rna_nodetree.cc @@ -10304,7 +10304,6 @@ static void rna_def_geometry_nodetree(BlenderRNA *brna) RNA_def_struct_ui_icon(srna, ICON_NODETREE); prop = RNA_def_property(srna, "is_tool", PROP_BOOLEAN, PROP_NONE); - RNA_def_property_boolean_sdna(prop, nullptr, "flag", GEO_NODE_ASSET_TOOL); RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); RNA_def_property_ui_text(prop, "Tool", "The node group is used as a tool"); RNA_def_property_boolean_funcs( @@ -10312,7 +10311,6 @@ static void rna_def_geometry_nodetree(BlenderRNA *brna) RNA_def_property_update(prop, NC_NODE | ND_DISPLAY, "rna_NodeTree_update_asset"); prop = RNA_def_property(srna, "is_modifier", PROP_BOOLEAN, PROP_NONE); - RNA_def_property_boolean_sdna(prop, nullptr, "flag", GEO_NODE_ASSET_MODIFIER); RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); RNA_def_property_ui_text(prop, "Modifier", "The node group is used as a geometry modifier"); RNA_def_property_boolean_funcs( @@ -10320,7 +10318,6 @@ static void rna_def_geometry_nodetree(BlenderRNA *brna) RNA_def_property_update(prop, NC_NODE | ND_DISPLAY, "rna_NodeTree_update_asset"); prop = RNA_def_property(srna, "is_mode_object", PROP_BOOLEAN, PROP_NONE); - RNA_def_property_boolean_sdna(prop, nullptr, "flag", GEO_NODE_ASSET_EDIT); RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); RNA_def_property_ui_text(prop, "Edit", "The node group is used in object mode"); RNA_def_property_boolean_funcs( @@ -10328,7 +10325,6 @@ static void rna_def_geometry_nodetree(BlenderRNA *brna) RNA_def_property_update(prop, NC_NODE | ND_DISPLAY, "rna_NodeTree_update_asset"); prop = RNA_def_property(srna, "is_mode_edit", PROP_BOOLEAN, PROP_NONE); - RNA_def_property_boolean_sdna(prop, nullptr, "flag", GEO_NODE_ASSET_EDIT); RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); RNA_def_property_ui_text(prop, "Edit", "The node group is used in edit mode"); RNA_def_property_boolean_funcs( @@ -10336,7 +10332,6 @@ static void rna_def_geometry_nodetree(BlenderRNA *brna) RNA_def_property_update(prop, NC_NODE | ND_DISPLAY, "rna_NodeTree_update_asset"); prop = RNA_def_property(srna, "is_mode_sculpt", PROP_BOOLEAN, PROP_NONE); - RNA_def_property_boolean_sdna(prop, nullptr, "flag", GEO_NODE_ASSET_SCULPT); RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); RNA_def_property_ui_text(prop, "Sculpt", "The node group is used in sculpt mode"); RNA_def_property_boolean_funcs( @@ -10344,7 +10339,6 @@ static void rna_def_geometry_nodetree(BlenderRNA *brna) RNA_def_property_update(prop, NC_NODE | ND_DISPLAY, "rna_NodeTree_update_asset"); prop = RNA_def_property(srna, "is_mode_paint", PROP_BOOLEAN, PROP_NONE); - RNA_def_property_boolean_sdna(prop, nullptr, "flag", GEO_NODE_ASSET_PAINT); RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); RNA_def_property_ui_text(prop, "Paint", "The node group is used in paint mode"); RNA_def_property_boolean_funcs( @@ -10352,7 +10346,6 @@ static void rna_def_geometry_nodetree(BlenderRNA *brna) RNA_def_property_update(prop, NC_NODE | ND_DISPLAY, "rna_NodeTree_update_asset"); prop = RNA_def_property(srna, "is_type_mesh", PROP_BOOLEAN, PROP_NONE); - RNA_def_property_boolean_sdna(prop, nullptr, "flag", GEO_NODE_ASSET_MESH); RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); RNA_def_property_ui_text(prop, "Mesh", "The node group is used for meshes"); RNA_def_property_boolean_funcs( @@ -10360,7 +10353,6 @@ static void rna_def_geometry_nodetree(BlenderRNA *brna) RNA_def_property_update(prop, NC_NODE | ND_DISPLAY, "rna_NodeTree_update_asset"); prop = RNA_def_property(srna, "is_type_curve", PROP_BOOLEAN, PROP_NONE); - RNA_def_property_boolean_sdna(prop, nullptr, "flag", GEO_NODE_ASSET_CURVE); RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); RNA_def_property_ui_text(prop, "Curves", "The node group is used for curves"); RNA_def_property_boolean_funcs( @@ -10368,7 +10360,6 @@ static void rna_def_geometry_nodetree(BlenderRNA *brna) RNA_def_property_update(prop, NC_NODE | ND_DISPLAY, "rna_NodeTree_update_asset"); prop = RNA_def_property(srna, "is_type_pointcloud", PROP_BOOLEAN, PROP_NONE); - RNA_def_property_boolean_sdna(prop, nullptr, "flag", GEO_NODE_ASSET_POINTCLOUD); RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); RNA_def_property_ui_text(prop, "Point Cloud", "The node group is used for point clouds"); RNA_def_property_boolean_funcs(prop, @@ -10377,7 +10368,6 @@ static void rna_def_geometry_nodetree(BlenderRNA *brna) RNA_def_property_update(prop, NC_NODE | ND_DISPLAY, "rna_NodeTree_update_asset"); prop = RNA_def_property(srna, "use_wait_for_click", PROP_BOOLEAN, PROP_NONE); - RNA_def_property_boolean_sdna(prop, nullptr, "flag", GEO_NODE_ASSET_POINTCLOUD); RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); RNA_def_property_ui_text(prop, "Wait for Click", @@ -10388,7 +10378,6 @@ static void rna_def_geometry_nodetree(BlenderRNA *brna) RNA_def_property_update(prop, NC_NODE | ND_DISPLAY, "rna_NodeTree_update_asset"); prop = RNA_def_property(srna, "is_type_grease_pencil", PROP_BOOLEAN, PROP_NONE); - RNA_def_property_boolean_sdna(prop, nullptr, "flag", GEO_NODE_ASSET_GREASE_PENCIL); RNA_def_property_clear_flag(prop, PROP_ANIMATABLE); RNA_def_property_ui_text(prop, "Grease Pencil", "The node group is used for Grease Pencil"); RNA_def_property_boolean_funcs(prop,