From 15f59470a30f200a98ca2bb7c2537ab07a33fdb5 Mon Sep 17 00:00:00 2001 From: Hans Goudey Date: Tue, 28 Feb 2023 13:59:28 -0500 Subject: [PATCH] Fix #105314: Custom node groups missing sockets `ShaderNodeCustomGroup` and others lost their UI with 70260960994d6cce3a33 without a dynamic declaration callback. --- source/blender/nodes/composite/nodes/node_composite_common.cc | 1 + source/blender/nodes/geometry/nodes/node_geo_common.cc | 1 + source/blender/nodes/shader/nodes/node_shader_common.cc | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/source/blender/nodes/composite/nodes/node_composite_common.cc b/source/blender/nodes/composite/nodes/node_composite_common.cc index 5c3a2c87b9f..f996eb5a76c 100644 --- a/source/blender/nodes/composite/nodes/node_composite_common.cc +++ b/source/blender/nodes/composite/nodes/node_composite_common.cc @@ -46,4 +46,5 @@ void register_node_type_cmp_custom_group(bNodeType *ntype) if (ntype->insert_link == nullptr) { ntype->insert_link = node_insert_link_default; } + ntype->declare_dynamic = blender::nodes::node_group_declare_dynamic; } diff --git a/source/blender/nodes/geometry/nodes/node_geo_common.cc b/source/blender/nodes/geometry/nodes/node_geo_common.cc index 6830d819b34..1803ac1f83d 100644 --- a/source/blender/nodes/geometry/nodes/node_geo_common.cc +++ b/source/blender/nodes/geometry/nodes/node_geo_common.cc @@ -67,4 +67,5 @@ void register_node_type_geo_custom_group(bNodeType *ntype) if (ntype->insert_link == nullptr) { ntype->insert_link = node_insert_link_default; } + ntype->declare_dynamic = blender::nodes::node_group_declare_dynamic; } diff --git a/source/blender/nodes/shader/nodes/node_shader_common.cc b/source/blender/nodes/shader/nodes/node_shader_common.cc index ac918ba0fdd..6b26cd11fef 100644 --- a/source/blender/nodes/shader/nodes/node_shader_common.cc +++ b/source/blender/nodes/shader/nodes/node_shader_common.cc @@ -110,6 +110,6 @@ void register_node_type_sh_custom_group(bNodeType *ntype) if (ntype->insert_link == nullptr) { ntype->insert_link = node_insert_link_default; } - + ntype->declare_dynamic = blender::nodes::node_group_declare_dynamic; ntype->gpu_fn = gpu_group_execute; }