Campbell Barton
b134434224
Cleanup: declare arrays arrays where possible
2020-08-07 22:37:39 +10:00
Sybren A. Stüvel
20869065b8
Cleanup: BMesh, Clang-Tidy else-after-return fixes
...
This addresses warnings from Clang-Tidy's `readability-else-after-return`
rule in the `source/blender/bmesh` module.
No functional changes.
2020-07-03 14:48:37 +02:00
Campbell Barton
001629a362
Fix T75946: Intersect (knife) doesn't cut all intersections
2020-04-24 13:26:17 +10:00
Campbell Barton
d428cca124
Fix T63787: Knife intersect crashes
2020-04-24 12:18:29 +10:00
Campbell Barton
9667f89e82
Cleanup: correct printf warnings for bmesh interesect debugging
2020-04-24 11:47:41 +10:00
Dalai Felinto
2d1cce8331
Cleanup: make format after SortedIncludes change
2020-03-19 09:33:58 +01:00
Campbell Barton
68a52a7fa9
Cleanup: define use
2020-02-15 10:40:41 +11:00
mano-wii
55fbb0fd69
BM_mesh_intersect: Match the mesh in Debug build with Release
...
Prevents regression in unit tests.
2020-01-06 12:33:46 -03:00
Campbell Barton
cd6b49f995
Cleanup: spelling
2019-07-07 15:38:41 +10:00
Campbell Barton
e12c08e8d1
ClangFormat: apply to source, most of intern
...
Apply clang format as proposed in T53211.
For details on usage and instructions for migrating branches
without conflicts, see:
https://wiki.blender.org/wiki/Tools/ClangFormat
2019-04-17 06:21:24 +02:00
Campbell Barton
8d7005d715
Cleanup: style, use braces for bmesh
2019-03-27 17:14:36 +11:00
Campbell Barton
de13d0a80c
doxygen: add newline after \file
...
While \file doesn't need an argument, it can't have another doxy
command after it.
2019-02-18 08:22:12 +11:00
Campbell Barton
452df3f392
Cleanup: comments
2019-02-12 01:51:03 +11:00
Campbell Barton
eef4077f18
Cleanup: remove redundant doxygen \file argument
...
Move \ingroup onto same line to be more compact and
make it clear the file is in the group.
2019-02-06 15:45:22 +11:00
Campbell Barton
65ec7ec524
Cleanup: remove redundant, invalid info from headers
...
BF-admins agree to remove header information that isn't useful,
to reduce noise.
- BEGIN/END license blocks
Developers should add non license comments as separate comment blocks.
No need for separator text.
- Contributors
This is often invalid, outdated or misleading
especially when splitting files.
It's more useful to git-blame to find out who has developed the code.
See P901 for script to perform these edits.
2019-02-02 01:36:28 +11:00
Campbell Barton
1e4aab36c2
Cleanup: remove redundant BKE/BLI/BIF headers
2019-01-26 21:20:25 +11:00
Campbell Barton
dd4c87cd04
Merge branch 'master' into blender2.8
2018-12-14 11:09:42 +11:00
Campbell Barton
6e2d9ef2db
Cleanup: naming (mean -> median) see T47811
2018-12-14 10:54:11 +11:00
Campbell Barton
49490e5cfb
Merge branch 'master' into blender2.8
2018-12-12 13:02:09 +11:00
Campbell Barton
e757c4a3be
Cleanup: use colon separator after parameter
...
Helps separate variable names from descriptive text.
Was already used in some parts of the code,
double space and dashes were used elsewhere.
2018-12-12 12:50:58 +11:00
Campbell Barton
bb3ec3ebaf
BLI_utildefines: rename pointer conversion macros
...
Terms get/set don't make much sense when casting values.
Name macros so the conversion is obvious,
use common prefix for easier completion.
- GET_INT_FROM_POINTER -> POINTER_AS_INT
- SET_INT_IN_POINTER -> POINTER_FROM_INT
- GET_UINT_FROM_POINTER -> POINTER_AS_UINT
- SET_UINT_IN_POINTER -> POINTER_FROM_UINT
2018-09-19 12:12:21 +10:00
Campbell Barton
f35e9f047a
Merge branch 'master' into blender2.8
2018-09-19 12:14:36 +10:00
Campbell Barton
43ce201125
Merge branch 'master' into blender2.8
2018-06-17 11:57:49 +02:00
Campbell Barton
2f1e34cfcc
Cleanup: use clamp_* from BLI_math (replace macro)
2018-06-17 11:50:56 +02:00
Campbell Barton
0b8c2eed75
Merge branch 'master' into blender28
2018-06-15 15:42:42 +02:00
Howard Trickey
b84fad2ba3
Fix T55490, intersect two triangles fails.
...
Need to use the 'use_partial_connect' option in island connect,
so changed signatures of various functions to pass that into and
then down from BM_mesh_intersect (making true for intersect, false
for boolean).
Then fix bm_face_split_edgenet_partial_connect to work when
input edges are not necessarily wire, but at least not in the
face they are being connected in. That caused generalization
of core BM_vert_separate_hflag_wire (which is only used in
this one place in all Blender).
2018-06-15 08:48:45 -04:00
Sergey Sharybin
df1c88b652
Merge branch 'master' into blender2.8
2018-02-15 14:15:55 +01:00
Campbell Barton
ccdacf1c9b
Cleanup: use '_len' instead of '_size' w/ BLI API
...
- When returning the number of items in a collection use BLI_*_len()
- Keep _size() for size in bytes.
- Keep _count() for data structures that don't store length
(hint this isn't a simple getter).
See P611 to apply instead of manually resolving conflicts.
2018-02-15 23:39:08 +11:00
Sergey Sharybin
af170839af
Merge branch 'master' into blender2.8
2017-09-19 21:08:14 +05:00
Campbell Barton
60956397ca
Cleanup: BLI_utildefines prefix for header-only libs
...
This allows to have different macro headers without them sharing
similar names to regular C modules.
2017-09-19 20:16:05 +10:00
Campbell Barton
90ebf4832f
Merge branch 'master' into blender2.8
2017-05-06 22:54:28 +10:00
Campbell Barton
89120cd241
bmesh: use 'uint' instead of 'unsigned int'
...
no functional changes.
2017-05-06 14:19:08 +10:00
Julian Eisel
a5cba9aab9
Merge branch 'master' into blender2.8
...
Conflicts:
source/blender/editors/space_nla/nla_draw.c
source/blender/editors/space_view3d/view3d_draw.c
2017-03-06 13:00:46 +01:00
Campbell Barton
3caeb51d7f
Fix T50855: Intersect (knife) w/o separate doesn't select
2017-03-05 22:28:16 +11:00
Mike Erwin
6ab42eb0bd
OpenGL: delete bl_debug_draw
...
Eliminating this chunk of legacy GL as part of T49043.
We can introduce some sort of "debug plate" to fill this need in the future.
2016-12-04 20:34:44 -05:00
Campbell Barton
e6d947f037
BMesh Intersect: use flags to keep track of verts
...
For simple cases bitmasks were OK, but didnt work for vert/edge, vert/edge tests.
Tag verts instead, makes logic easier to follow and gives minor speedup.
2016-06-29 16:09:58 +10:00
Campbell Barton
d9a01a1d04
Fix T48707: Edit-mesh intersect crash
...
In rare cases intersect would attempt to add edges with the same vertex twice
from edge-vert / edge-edge intersections.
Solve by checking for duplicates when creating vertex-array for these types of intersections
(always under 3x comparisons, so not much overhead).
2016-06-23 22:20:40 +10:00
Campbell Barton
a8898d3105
Correct assert
2016-06-23 12:26:26 +10:00
Campbell Barton
86b509229f
Fix T48413: editmesh intersect tool crash
...
Its important to add tri-edge intersections from both sides.
2016-05-12 21:00:08 +10:00
Campbell Barton
8d3f367c01
Correct debug prints
2016-05-12 20:59:48 +10:00
Bastien Montagne
c6c223ade6
Fix T47164: [Scene.raycast] - True result when it should be False.
...
We cannot use FLT_MAX as initi distance for raycast...
Renamed TRANSFORM_DIST_MAX_RAY to BVH_RAYCAST_DIST_MAX, moved it into BLI_kdopbvh,
and use in RNA raycast callbacks (and all other places using that API).
2016-01-12 10:09:00 +01:00
Campbell Barton
88191f7fa3
BMesh: support connecting single-edge island links
...
Handle these cases by temporarily disconnecting the single links to ensure isolated islands,
then link back up after.
2015-12-17 05:13:57 +11:00
Campbell Barton
fa3fe2ee10
Cleanup: math lib naming
...
Distinguish between line / line_segment
2015-12-15 18:16:41 +11:00
Campbell Barton
fa4a9c7ae6
BMesh: don't use total faces to detect edits
...
Possible a boolean operation edits the mesh while keeping the same number of faces.
2015-12-13 19:55:21 +11:00
Campbell Barton
e47397c7d2
BMesh: no need to tag edges created to fill holes
...
Was selecting these edges after applying boolean,
which isnt useful since selection is supposed to be along the cuts.
2015-12-13 19:55:21 +11:00
Campbell Barton
dc98a3b0a7
Cleanup: style/spelling
2015-12-12 15:10:03 +11:00
Campbell Barton
ebf9d315c4
BMesh: editmode booleans ignored when no faces cut
...
For the intersect tool this made sense, but booleans can use cuts which overlap edges exactly.
2015-12-12 13:58:03 +11:00
Campbell Barton
189032c724
Correct error in last boolean commit
...
Side was flipped
2015-12-12 13:15:09 +11:00
Campbell Barton
e301fcf8e7
Commend timing prints for boolean
2015-12-12 01:30:03 +11:00
Campbell Barton
fa32cde8a8
BMesh: boolean wasn't ignoring hidden faces
...
Needed for editmode use
2015-12-12 00:52:38 +11:00