Campbell Barton
581a6da804
Fix incorrect use of BLI_assert with error strings
...
Some asserts were never raised because of invalid checks.
2021-07-22 00:47:29 +10:00
Campbell Barton
265c3a4724
Cleanup: replace NB with NOTE in comments
2021-07-21 13:10:32 +10:00
Campbell Barton
77e927b58f
Cleanup: reserve C++ comments for disabled code
...
Use C comments for plain text.
2021-07-20 15:01:05 +10:00
Campbell Barton
bf5b1fa726
Cleanup: remove redundant parentheses
2021-07-16 11:45:52 +10:00
Campbell Barton
5bbbc98471
Cleanup: spelling in comments
2021-07-07 13:42:46 +10:00
Campbell Barton
f0f7282d9d
Cleanup: spelling in comments
2021-07-05 15:54:57 +10:00
Campbell Barton
9b89de2571
Cleanup: consistent use of tags: NOTE/TODO/FIXME/XXX
...
Also use doxy style function reference `#` prefix chars when
referencing identifiers.
2021-07-04 00:43:40 +10:00
Campbell Barton
1d8648b13a
Cleanup: repeated terms in code comments & error messages
2021-06-28 15:46:08 +10:00
Campbell Barton
f1e4903854
Cleanup: full sentences in comments, improve comment formatting
2021-06-26 21:50:48 +10:00
Campbell Barton
6570159929
Cleanup: update clang-format so PyObject_HEAD indents properly
2021-06-24 17:12:04 +10:00
Campbell Barton
1f778dbefc
Cleanup: use Blender's code style for doxygen commetns in freestyle
2021-06-24 15:59:34 +10:00
Campbell Barton
4b9ff3cd42
Cleanup: comment blocks, trailing space in comments
2021-06-24 15:59:34 +10:00
Campbell Barton
1198b187b5
Cleanup: spelling
2021-04-11 13:09:27 +10:00
Jacques Lucke
f031791185
Cleanup: modernize-use-equals-default
...
This was missing from rB19dfb6ea1f6745c0dbc2ce21839c30184b553878.
2021-04-08 15:51:39 +02:00
Jacques Lucke
de6f19ce22
Cleanup: modernize-use-equals-default
...
This was missing from rB19dfb6ea1f6745c0dbc2ce21839c30184b553878.
2021-04-08 11:24:02 +02:00
Campbell Barton
bf13a4d3ff
Cleanup: unused return statements
2021-03-21 14:00:40 +11:00
Brecht Van Lommel
ec8c09f2aa
Cleanup: fix compiler warnings
2021-02-17 16:26:24 +01:00
Campbell Barton
67c8d97db3
Cleanup: spelling
2021-02-14 20:58:04 +11:00
Campbell Barton
dae445d94a
Fix T85573: Building with Python 3.10a5 fails
...
Replace deprecated _PyUnicode_AsString{AndSize} usage.
T83626 still needs to be resolved before 3.10 is usable.
2021-02-13 23:09:55 +11:00
Campbell Barton
d21f445469
PyAPI: remove Python 3.7x compatibility code
...
This removes Python version checks needed to build with 3.8+ and 3.7x.
Ref D10381
2021-02-12 08:08:15 +11:00
Omar Emara
21a2b975b8
Cleanup: Remove using-directive from freestyle headers
...
The header files in freestyle utilize the using-directive at the global
file scope. This is a bad practice as it pollutes the global name space
causing possible ambiguous reference compilation errors. In particular,
the DNA files that are included by freestyle will cause those ambiguous
reference errors when the developers adds a DNA member with a type name
that also exist in the Freestyle name space, such as Curve and possibly
others.
This patch does the minimal work needed to resolve that by moving the
using-directives from the headers into the corresponding translation
units.
Reviewed By: Brecht
Differential Revision: https://developer.blender.org/D10351
2021-02-08 17:29:42 +02:00
luzpaz
a4a9d14ba7
UI: Fix Typos in Comments and Docs
...
Approximately 91 spelling corrections, almost all in comments.
Differential Revision: https://developer.blender.org/D10288
Reviewed by Harley Acheson
2021-02-05 19:08:14 -08:00
Campbell Barton
17e1e2bfd8
Cleanup: correct spelling in comments
2021-02-05 16:23:34 +11:00
Sebastian Parborg
d0aa7d5562
Merge branch 'blender-v2.92-release'
2021-02-02 16:47:21 +01:00
Sebastian Parborg
f8359b5f52
Fix freestyle render pass not being created when there are no strokes
...
It could lead to missing images when outputing the pass to an image
sequence.
2021-02-02 16:45:23 +01:00
Campbell Barton
9ad181a5d0
Cleanup: email address formatting
...
Match git style email addresses, ignored by the spell checker.
2021-01-24 16:08:17 +11:00
Brecht Van Lommel
90bcd5e724
Cleanup: remove unused render camera code
2021-01-22 19:30:17 +01:00
Brecht Van Lommel
84702bd3d8
Fix T84242: freestyle animated camera shift lags behind in animation render
2021-01-21 14:21:49 +01:00
Jacques Lucke
c93f826661
Cleanup: various clang tidy fixes
2020-12-09 16:29:11 +01:00
Sybren A. Stüvel
7f2d356a67
Cleanup: Clang-Tidy, modernize-use-using
...
Replace `typedef` with `using` in C++ code.
In the case of `typedef struct SomeName { ... } SomeName;` I removed the
`typedef` altogether, as this is unnecessary in C++. Such cases have been
rewritten to `struct SomeName { ... };`
No functional changes.
2020-12-04 12:46:43 +01:00
Sybren A. Stüvel
168909d974
Cleanup: Clang-Tidy, modernize-use-override
...
No functional changes.
2020-12-04 12:02:52 +01:00
Sybren A. Stüvel
958df2ed1b
Cleanup: Clang-Tidy, modernize-deprecated-headers
...
No functional changes.
2020-12-04 11:28:09 +01:00
Ankit Meel
88de58fd1a
Clang-tidy, fix bugprone-exception-escape.
...
Remove redundant call to `ofstream::close()` from `~PSStrokeRenderer`
and `~TextStrokeRenderer`. ofstream will be destructed automatically.
- For `~Depsgraph`, `std::function`'s constructor can throw.
- Passing throwing statements in the lambda will not be detected by
clang-tidy.
Fix these issues by using lambda as function argument.
Reviewed By: sergey, sybren
Differential Revision: https://developer.blender.org/D9497
2020-11-17 17:33:25 +05:30
Campbell Barton
cd9acfed4f
Cleanup: use preprocessor version check for PyTypeObject declaration
...
While `tp_print` was deprecated, Python 3.8+ uses this for
'tp_vectorcall_offset' which wasn't stated in the comment from
efd71aad4f .
Instead of suppressing clang-tidy, use preprocessor a check since
this properly represents the difference between Python versions.
2020-11-11 09:11:21 +11:00
Campbell Barton
b5d310b569
Cleanup: clang-format
2020-11-10 09:42:03 +11:00
Campbell Barton
efd71aad4f
Cleanup: clang-tidy suppress warnings for PyTypeObject.tp_print
...
Clang-tidy behavior changes from Python 3.7 to 3.8+ so it's simplest
to suppress the warning in this instance.
2020-11-10 09:40:20 +11:00
Campbell Barton
e118426e46
Fix T82520: error building freestyle with Python3.8
...
Caused by 16732def37 ,
This is a 'Py_ssize_t' in Python 3.8,
replace with zero as this works in both 3.7 and 3.8.
2020-11-09 16:08:29 +11:00
Campbell Barton
8c846cccd6
Cleanup: clang-format
2020-11-09 15:47:08 +11:00
Ankit Meel
9cd9ea591f
Cleanup: NULL to nullptr.
2020-11-07 21:52:53 +05:30
Ankit Meel
40d4a4cb1a
Cleanup: Clang-format.
2020-11-07 18:48:13 +05:30
Ankit Meel
4525049aa0
Cleanup: Clang-tidy, modernize-concat-nested-namespaces
2020-11-07 18:48:13 +05:30
Sybren A. Stüvel
16732def37
Cleanup: Clang-Tidy modernize-use-nullptr
...
Replace `NULL` with `nullptr` in C++ code.
No functional changes.
2020-11-06 18:08:25 +01:00
Sergey Sharybin
3cb4c51308
Cleanup: Clang-Tidy, modernize-make-unique
2020-11-06 16:47:16 +01:00
Aaron Carlisle
580ff2cb93
Cleanup: Render Module: combine intern/ source & include
2020-11-06 10:37:40 -05:00
Aaron Carlisle
e15076b22f
Cleanup: Render Module: move header files to main directory
...
Move headers files from `render/extern/` to `render/`
Part of T73586
2020-11-06 10:10:41 -05:00
Sergey Sharybin
af35ada2f3
Cleanup: Clang-Tidy, modernize-use-bool-literals
2020-11-06 14:32:51 +01:00
Sergey Sharybin
8d5073345d
Cleanup: Clang-Tidy, modernize-use-emplace
2020-11-06 14:06:52 +01:00
Sergey Sharybin
a331d5c992
Cleanup: Clang-Tidy, modernize-redundant-void-arg
2020-11-06 13:40:46 +01:00
Sergey Sharybin
190170d4cc
Cleanup: Clang-Tidy, readability-redundant-member-init
2020-11-06 11:54:53 +01:00
Campbell Barton
605425c006
Cleanup: doxygen comments
2020-11-06 14:35:38 +11:00