ce0ec6e708
MNEE on HIP has rendering artifacts on RDNA1 (#134978), RDNA2 (#139068) and RDNA4 (#136980), and can lock up the GPU under specific situations with RDNA3 (#138607). There are certain configurations that work (E.g. RDNA4 seems to work on Linux), but the number of configurations that work keep dropping as further developments are made in other areas. So it was decided it's just better to disable MNEE entirely on HIP. This commit disables MNEE on HIP, and does a small cleanup to remove the unused functions as a result of this change. Fix #139068: MNEE renders with artifacts on RDNA2 Fix #138607: MNEE render test stalls on RDNA3 Pull Request: https://projects.blender.org/blender/blender/pulls/139069
102 lines
2.7 KiB
C++
102 lines
2.7 KiB
C++
/* SPDX-FileCopyrightText: 2011-2022 Blender Foundation
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0 */
|
|
|
|
#pragma once
|
|
|
|
#ifdef WITH_HIP
|
|
|
|
# include <cstring>
|
|
# include <string>
|
|
|
|
# ifdef WITH_HIP_DYNLOAD
|
|
# include "hipew.h"
|
|
# endif
|
|
|
|
CCL_NAMESPACE_BEGIN
|
|
|
|
class HIPDevice;
|
|
|
|
/* Utility to push/pop HIP context. */
|
|
class HIPContextScope {
|
|
public:
|
|
HIPContextScope(HIPDevice *device);
|
|
~HIPContextScope();
|
|
|
|
private:
|
|
HIPDevice *device;
|
|
};
|
|
|
|
/* Utility for checking return values of HIP function calls. */
|
|
# define hip_device_assert(hip_device, stmt) \
|
|
{ \
|
|
hipError_t result = stmt; \
|
|
if (result != hipSuccess) { \
|
|
const char *name = hipewErrorString(result); \
|
|
hip_device->set_error( \
|
|
string_printf("%s in %s (%s:%d)", name, #stmt, __FILE__, __LINE__)); \
|
|
} \
|
|
} \
|
|
(void)0
|
|
|
|
# define hip_assert(stmt) hip_device_assert(this, stmt)
|
|
|
|
# ifndef WITH_HIP_DYNLOAD
|
|
/* Transparently implement some functions, so majority of the file does not need
|
|
* to worry about difference between dynamically loaded and linked HIP at all. */
|
|
const char *hipewErrorString(hipError_t result);
|
|
const char *hipewCompilerPath();
|
|
int hipewCompilerVersion();
|
|
# endif /* !WITH_HIP_DYNLOAD */
|
|
|
|
bool hipSupportsDriver();
|
|
|
|
static std::string hipDeviceArch(const int hipDevId)
|
|
{
|
|
hipDeviceProp_t props;
|
|
hipGetDeviceProperties(&props, hipDevId);
|
|
const char *arch = strtok(props.gcnArchName, ":");
|
|
return (arch == nullptr) ? props.gcnArchName : arch;
|
|
}
|
|
|
|
static inline bool hipSupportsDevice(const int hipDevId)
|
|
{
|
|
int major, minor;
|
|
hipDeviceGetAttribute(&major, hipDeviceAttributeComputeCapabilityMajor, hipDevId);
|
|
hipDeviceGetAttribute(&minor, hipDeviceAttributeComputeCapabilityMinor, hipDevId);
|
|
|
|
return (major >= 10);
|
|
}
|
|
|
|
static inline bool hipIsRDNA2OrNewer(const int hipDevId)
|
|
{
|
|
int major, minor;
|
|
hipDeviceGetAttribute(&major, hipDeviceAttributeComputeCapabilityMajor, hipDevId);
|
|
hipDeviceGetAttribute(&minor, hipDeviceAttributeComputeCapabilityMinor, hipDevId);
|
|
|
|
return (major > 10 || (major == 10 && minor >= 3));
|
|
}
|
|
|
|
static inline bool hipNeedPreciseMath(const std::string &arch)
|
|
{
|
|
# ifdef _WIN32
|
|
/* Enable stricter math options for RDNA2 GPUs (compiler bug on Windows). */
|
|
return (arch == "gfx1030" || arch == "gfx1031" || arch == "gfx1032" || arch == "gfx1033" ||
|
|
arch == "gfx1034" || arch == "gfx1035" || arch == "gfx1036");
|
|
# else
|
|
(void)arch;
|
|
return false;
|
|
# endif
|
|
}
|
|
|
|
static inline bool hipSupportsDeviceOIDN(const int hipDevId)
|
|
{
|
|
/* Matches HIPDevice::getArch in HIP. */
|
|
const std::string arch = hipDeviceArch(hipDevId);
|
|
return (arch == "gfx1030" || arch == "gfx1100" || arch == "gfx1101" || arch == "gfx1102");
|
|
}
|
|
|
|
CCL_NAMESPACE_END
|
|
|
|
#endif /* WITH_HIP */
|