The issue was that the `FCURVE_DISABLED` flag is set when an RNA path cannot be resolved, and that skips evaluation. However in the specific case, that is actually something expected as the property only exists on one ID and not the other. Pull Request: https://projects.blender.org/blender/blender/pulls/135782
319 lines
11 KiB
C++
319 lines
11 KiB
C++
/* SPDX-FileCopyrightText: 2023 Blender Developers
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
#include "ANIM_evaluation.hh"
|
|
|
|
#include "BKE_animsys.h"
|
|
#include "BKE_fcurve.hh"
|
|
|
|
#include "BLI_map.hh"
|
|
|
|
#include "CLG_log.h"
|
|
|
|
#include "evaluation_internal.hh"
|
|
|
|
static CLG_LogRef LOG = {"animrig.evaluation"};
|
|
|
|
namespace blender::animrig {
|
|
|
|
using namespace internal;
|
|
|
|
/**
|
|
* Blend the 'current layer' with the 'last evaluation result', returning the
|
|
* blended result.
|
|
*/
|
|
EvaluationResult blend_layer_results(const EvaluationResult &last_result,
|
|
const EvaluationResult ¤t_result,
|
|
const Layer ¤t_layer);
|
|
|
|
/**
|
|
* Apply the result of the animation evaluation to the given data-block.
|
|
*
|
|
* \param flush_to_original: when true, look up the original data-block (assuming the given one is
|
|
* an evaluated copy) and update that too.
|
|
*/
|
|
void apply_evaluation_result(const EvaluationResult &evaluation_result,
|
|
PointerRNA &animated_id_ptr,
|
|
bool flush_to_original);
|
|
|
|
EvaluationResult evaluate_action(PointerRNA &animated_id_ptr,
|
|
Action &action,
|
|
const slot_handle_t slot_handle,
|
|
const AnimationEvalContext &anim_eval_context)
|
|
{
|
|
EvaluationResult last_result;
|
|
|
|
/* Evaluate each layer in order. */
|
|
for (Layer *layer : action.layers()) {
|
|
if (layer->influence <= 0.0f) {
|
|
/* Don't bother evaluating layers without influence. */
|
|
continue;
|
|
}
|
|
|
|
auto layer_result = evaluate_layer(
|
|
animated_id_ptr, action, *layer, slot_handle, anim_eval_context);
|
|
if (!layer_result) {
|
|
continue;
|
|
}
|
|
|
|
if (!last_result) {
|
|
/* Simple case: no results so far, so just use this layer as-is. There is
|
|
* nothing to blend/combine with, so ignore the influence and combination
|
|
* options. */
|
|
last_result = layer_result;
|
|
continue;
|
|
}
|
|
|
|
/* Complex case: blend this layer's result into the previous layer's result. */
|
|
last_result = blend_layer_results(last_result, layer_result, *layer);
|
|
}
|
|
|
|
return last_result;
|
|
}
|
|
|
|
void evaluate_and_apply_action(PointerRNA &animated_id_ptr,
|
|
Action &action,
|
|
const slot_handle_t slot_handle,
|
|
const AnimationEvalContext &anim_eval_context,
|
|
const bool flush_to_original)
|
|
{
|
|
EvaluationResult evaluation_result = evaluate_action(
|
|
animated_id_ptr, action, slot_handle, anim_eval_context);
|
|
if (!evaluation_result) {
|
|
return;
|
|
}
|
|
|
|
apply_evaluation_result(evaluation_result, animated_id_ptr, flush_to_original);
|
|
}
|
|
|
|
/* Copy of the same-named function in anim_sys.cc, with the check on action groups removed. */
|
|
static bool is_fcurve_evaluatable(const FCurve *fcu)
|
|
{
|
|
if (fcu->rna_path == nullptr) {
|
|
return false;
|
|
}
|
|
|
|
/* Not checking for FCURVE_DISABLED here, because those FCurves may still be evaluatable for
|
|
* other users of the same slot. See #135666. This is safe to do since this function isn't called
|
|
* for drivers. */
|
|
if (fcu->flag & FCURVE_MUTED) {
|
|
return false;
|
|
}
|
|
if (BKE_fcurve_is_empty(fcu)) {
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
/* Copy of the same-named function in anim_sys.cc, but with the special handling for NLA strips
|
|
* removed. */
|
|
static void animsys_construct_orig_pointer_rna(const PointerRNA *ptr, PointerRNA *ptr_orig)
|
|
{
|
|
*ptr_orig = *ptr;
|
|
/* Original note from anim_sys.cc:
|
|
* -----------
|
|
* NOTE: nlastrip_evaluate_controls() creates PointerRNA with ID of nullptr. Technically, this is
|
|
* not a valid pointer, but there are exceptions in various places of this file which handles
|
|
* such pointers.
|
|
* We do special trickery here as well, to quickly go from evaluated to original NlaStrip.
|
|
* -----------
|
|
* And this is all not ported to the new layered animation system. */
|
|
BLI_assert_msg(ptr->owner_id, "NLA support was not ported to the layered animation system");
|
|
ptr_orig->owner_id = ptr_orig->owner_id->orig_id;
|
|
ptr_orig->data = ptr_orig->owner_id;
|
|
}
|
|
|
|
/* Copy of the same-named function in anim_sys.cc. */
|
|
static void animsys_write_orig_anim_rna(PointerRNA *ptr,
|
|
const char *rna_path,
|
|
const int array_index,
|
|
const float value)
|
|
{
|
|
PointerRNA ptr_orig;
|
|
animsys_construct_orig_pointer_rna(ptr, &ptr_orig);
|
|
|
|
PathResolvedRNA orig_anim_rna;
|
|
/* TODO(sergey): Should be possible to cache resolved path in dependency graph somehow. */
|
|
if (BKE_animsys_rna_path_resolve(&ptr_orig, rna_path, array_index, &orig_anim_rna)) {
|
|
BKE_animsys_write_to_rna_path(&orig_anim_rna, value);
|
|
}
|
|
}
|
|
|
|
static EvaluationResult evaluate_keyframe_data(PointerRNA &animated_id_ptr,
|
|
StripKeyframeData &strip_data,
|
|
const slot_handle_t slot_handle,
|
|
const AnimationEvalContext &offset_eval_context)
|
|
{
|
|
Channelbag *channelbag_for_slot = strip_data.channelbag_for_slot(slot_handle);
|
|
if (!channelbag_for_slot) {
|
|
return {};
|
|
}
|
|
|
|
EvaluationResult evaluation_result;
|
|
for (FCurve *fcu : channelbag_for_slot->fcurves()) {
|
|
/* Blatant copy of animsys_evaluate_fcurves(). */
|
|
|
|
if (!is_fcurve_evaluatable(fcu)) {
|
|
continue;
|
|
}
|
|
|
|
PathResolvedRNA anim_rna;
|
|
if (!BKE_animsys_rna_path_resolve(
|
|
&animated_id_ptr, fcu->rna_path, fcu->array_index, &anim_rna))
|
|
{
|
|
/* Log this at quite a high level, because it can get _very_ noisy when playing back
|
|
* animation. */
|
|
CLOG_INFO(&LOG,
|
|
4,
|
|
"Cannot resolve RNA path %s[%d] on ID %s\n",
|
|
fcu->rna_path,
|
|
fcu->array_index,
|
|
animated_id_ptr.owner_id->name);
|
|
continue;
|
|
}
|
|
|
|
const float curval = calculate_fcurve(&anim_rna, fcu, &offset_eval_context);
|
|
evaluation_result.store(fcu->rna_path, fcu->array_index, curval, anim_rna);
|
|
}
|
|
|
|
return evaluation_result;
|
|
}
|
|
|
|
void apply_evaluation_result(const EvaluationResult &evaluation_result,
|
|
PointerRNA &animated_id_ptr,
|
|
const bool flush_to_original)
|
|
{
|
|
for (auto channel_result : evaluation_result.items()) {
|
|
const PropIdentifier &prop_ident = channel_result.key;
|
|
const AnimatedProperty &anim_prop = channel_result.value;
|
|
const float animated_value = anim_prop.value;
|
|
PathResolvedRNA anim_rna = anim_prop.prop_rna;
|
|
|
|
BKE_animsys_write_to_rna_path(&anim_rna, animated_value);
|
|
|
|
if (flush_to_original) {
|
|
/* Convert the StringRef to a `const char *`, as the rest of the RNA path handling code in
|
|
* BKE still uses `char *` instead of `StringRef`. */
|
|
animsys_write_orig_anim_rna(&animated_id_ptr,
|
|
StringRefNull(prop_ident.rna_path).c_str(),
|
|
prop_ident.array_index,
|
|
animated_value);
|
|
}
|
|
}
|
|
}
|
|
|
|
static EvaluationResult evaluate_strip(PointerRNA &animated_id_ptr,
|
|
Action &owning_action,
|
|
Strip &strip,
|
|
const slot_handle_t slot_handle,
|
|
const AnimationEvalContext &anim_eval_context)
|
|
{
|
|
AnimationEvalContext offset_eval_context = anim_eval_context;
|
|
/* Positive offset means the entire strip is pushed "to the right", so
|
|
* evaluation needs to happen further "to the left". */
|
|
offset_eval_context.eval_time -= strip.frame_offset;
|
|
|
|
switch (strip.type()) {
|
|
case Strip::Type::Keyframe: {
|
|
StripKeyframeData &strip_data = strip.data<StripKeyframeData>(owning_action);
|
|
return evaluate_keyframe_data(animated_id_ptr, strip_data, slot_handle, offset_eval_context);
|
|
}
|
|
}
|
|
|
|
return {};
|
|
}
|
|
|
|
EvaluationResult blend_layer_results(const EvaluationResult &last_result,
|
|
const EvaluationResult ¤t_result,
|
|
const Layer ¤t_layer)
|
|
{
|
|
/* TODO?: store the layer results sequentially, so that we can step through
|
|
* them in parallel, instead of iterating over one and doing map lookups on
|
|
* the other. */
|
|
|
|
EvaluationResult blend = last_result;
|
|
|
|
for (auto channel_result : current_result.items()) {
|
|
const PropIdentifier &prop_ident = channel_result.key;
|
|
AnimatedProperty *last_prop = blend.lookup_ptr(prop_ident);
|
|
const AnimatedProperty &anim_prop = channel_result.value;
|
|
|
|
if (!last_prop) {
|
|
/* Nothing to blend with, so just take (influence * value). */
|
|
blend.store(prop_ident.rna_path,
|
|
prop_ident.array_index,
|
|
anim_prop.value * current_layer.influence,
|
|
anim_prop.prop_rna);
|
|
continue;
|
|
}
|
|
|
|
/* TODO: move this to a separate function. And write more smartness for rotations. */
|
|
switch (current_layer.mix_mode()) {
|
|
case Layer::MixMode::Replace:
|
|
last_prop->value = anim_prop.value * current_layer.influence;
|
|
break;
|
|
case Layer::MixMode::Offset:
|
|
last_prop->value = math::interpolate(
|
|
current_layer.influence, last_prop->value, anim_prop.value);
|
|
break;
|
|
case Layer::MixMode::Add:
|
|
last_prop->value += anim_prop.value * current_layer.influence;
|
|
break;
|
|
case Layer::MixMode::Subtract:
|
|
last_prop->value -= anim_prop.value * current_layer.influence;
|
|
break;
|
|
case Layer::MixMode::Multiply:
|
|
last_prop->value *= anim_prop.value * current_layer.influence;
|
|
break;
|
|
};
|
|
}
|
|
|
|
return blend;
|
|
}
|
|
|
|
namespace internal {
|
|
|
|
EvaluationResult evaluate_layer(PointerRNA &animated_id_ptr,
|
|
Action &owning_action,
|
|
Layer &layer,
|
|
const slot_handle_t slot_handle,
|
|
const AnimationEvalContext &anim_eval_context)
|
|
{
|
|
/* TODO: implement cross-blending between overlapping strips. For now, this is not supported.
|
|
* Instead, the first strong result is taken (see below), and if that is not available, the last
|
|
* weak result will be used.
|
|
*
|
|
* Weak result: obtained from evaluating the final frame of the strip.
|
|
* Strong result: any result that is not a weak result. */
|
|
EvaluationResult last_weak_result;
|
|
|
|
for (Strip *strip : layer.strips()) {
|
|
if (!strip->contains_frame(anim_eval_context.eval_time)) {
|
|
continue;
|
|
}
|
|
|
|
const EvaluationResult strip_result = evaluate_strip(
|
|
animated_id_ptr, owning_action, *strip, slot_handle, anim_eval_context);
|
|
if (!strip_result) {
|
|
continue;
|
|
}
|
|
|
|
const bool is_weak_result = strip->is_last_frame(anim_eval_context.eval_time);
|
|
if (is_weak_result) {
|
|
/* Keep going until a strong result is found. */
|
|
last_weak_result = strip_result;
|
|
continue;
|
|
}
|
|
|
|
/* Found a strong result, just return it. */
|
|
return strip_result;
|
|
}
|
|
|
|
return last_weak_result;
|
|
}
|
|
|
|
} // namespace internal
|
|
|
|
} // namespace blender::animrig
|