Files
test/source/blender/editors/interface/views/interface_view.cc
Jacques Lucke 40177a8426 UI: Tree View: support drag&drop below last element
Previously, when reordering a tree view item to the end, one had to move it drop
it fairly precisely on the lower half of the last item in the list. This patch
makes it possible to just drop it below the last item too. The outliner has the
same functionality.

Pull Request: https://projects.blender.org/blender/blender/pulls/139025
2025-05-21 17:56:39 +02:00

386 lines
11 KiB
C++

/* SPDX-FileCopyrightText: 2023 Blender Authors
*
* SPDX-License-Identifier: GPL-2.0-or-later */
/** \file
* \ingroup edinterface
*
* Code to manage views as part of the regular screen hierarchy. E.g. managing ownership of views
* inside blocks (#uiBlock.views), looking up items in the region, passing WM notifiers to views,
* etc.
*
* Blocks and their contained views are reconstructed on every redraw. This file also contains
* functions related to this recreation of views inside blocks. For example to query state
* information before the view is done reconstructing (#AbstractView.is_reconstructed() returns
* false), it may be enough to query the previous version of the block/view/view-item. Since such
* queries rely on the details of the UI reconstruction process, they should remain internal to
* `interface/` code.
*/
#include <memory>
#include "DNA_screen_types.h"
#include "BKE_screen.hh"
#include "BLI_listbase.h"
#include "BLI_map.hh"
#include "BLI_rect.h"
#include "ED_screen.hh"
#include "interface_intern.hh"
#include "UI_interface.hh"
#include "UI_abstract_view.hh"
#include "UI_grid_view.hh"
#include "UI_tree_view.hh"
using namespace blender;
using namespace blender::ui;
/**
* Wrapper to store views in a #ListBase, addressable via an identifier.
*/
struct ViewLink : public Link {
std::string idname;
std::unique_ptr<AbstractView> view;
static void views_bounds_calc(const uiBlock &block);
};
template<class T>
static T *ui_block_add_view_impl(uiBlock &block,
StringRef idname,
std::unique_ptr<AbstractView> view)
{
BLI_assert(idname.size() < int64_t(sizeof(uiViewStateLink::idname)));
ViewLink *view_link = MEM_new<ViewLink>(__func__);
BLI_addtail(&block.views, view_link);
view_link->view = std::move(view);
view_link->idname = idname;
return dynamic_cast<T *>(view_link->view.get());
}
AbstractGridView *UI_block_add_view(uiBlock &block,
StringRef idname,
std::unique_ptr<AbstractGridView> grid_view)
{
return ui_block_add_view_impl<AbstractGridView>(block, idname, std::move(grid_view));
}
AbstractTreeView *UI_block_add_view(uiBlock &block,
StringRef idname,
std::unique_ptr<AbstractTreeView> tree_view)
{
return ui_block_add_view_impl<AbstractTreeView>(block, idname, std::move(tree_view));
}
void ui_block_free_views(uiBlock *block)
{
LISTBASE_FOREACH_MUTABLE (ViewLink *, link, &block->views) {
MEM_delete(link);
}
}
void ViewLink::views_bounds_calc(const uiBlock &block)
{
Map<AbstractView *, rcti> views_bounds;
rcti minmax;
BLI_rcti_init_minmax(&minmax);
LISTBASE_FOREACH (ViewLink *, link, &block.views) {
views_bounds.add(link->view.get(), minmax);
}
for (const std::unique_ptr<uiBut> &but : block.buttons) {
if (but->type != UI_BTYPE_VIEW_ITEM) {
continue;
}
uiButViewItem *view_item_but = static_cast<uiButViewItem *>(but.get());
if (!view_item_but->view_item) {
continue;
}
/* Get the view from the button. */
AbstractViewItem &view_item = reinterpret_cast<AbstractViewItem &>(*view_item_but->view_item);
AbstractView &view = view_item.get_view();
rcti &bounds = views_bounds.lookup(&view);
rcti but_rcti{};
BLI_rcti_rctf_copy_round(&but_rcti, &view_item_but->rect);
BLI_rcti_do_minmax_rcti(&bounds, &but_rcti);
}
for (const auto item : views_bounds.items()) {
const rcti &bounds = item.value;
if (BLI_rcti_is_empty(&bounds)) {
continue;
}
AbstractView &view = *item.key;
view.bounds_ = bounds;
}
}
void ui_block_view_persistent_state_restore(const ARegion &region,
const uiBlock &block,
ui::AbstractView &view)
{
StringRef idname = [&]() -> StringRef {
LISTBASE_FOREACH (ViewLink *, link, &block.views) {
if (link->view.get() == &view) {
return link->idname;
}
}
return "";
}();
if (idname.is_empty()) {
BLI_assert_unreachable();
return;
}
LISTBASE_FOREACH (uiViewStateLink *, stored_state, &region.view_states) {
if (stored_state->idname == idname) {
view.persistent_state_apply(stored_state->state);
}
}
}
static uiViewStateLink *ensure_view_state(ARegion &region, const ViewLink &link)
{
LISTBASE_FOREACH (uiViewStateLink *, stored_state, &region.view_states) {
if (link.idname == stored_state->idname) {
return stored_state;
}
}
uiViewStateLink *new_state = MEM_callocN<uiViewStateLink>(__func__);
link.idname.copy(new_state->idname, sizeof(new_state->idname));
BLI_addhead(&region.view_states, new_state);
return new_state;
}
void ui_block_views_end(ARegion *region, const uiBlock *block)
{
ViewLink::views_bounds_calc(*block);
if (region && region->regiontype != RGN_TYPE_TEMPORARY) {
LISTBASE_FOREACH (const ViewLink *, link, &block->views) {
/* Ensure persistent view state storage for writing to files if needed. */
if (std::optional<uiViewState> temp_state = link->view->persistent_state()) {
uiViewStateLink *state_link = ensure_view_state(*region, *link);
state_link->state = *temp_state;
}
}
}
}
void ui_block_views_listen(const uiBlock *block, const wmRegionListenerParams *listener_params)
{
ARegion *region = listener_params->region;
LISTBASE_FOREACH (ViewLink *, view_link, &block->views) {
if (view_link->view->listen(*listener_params->notifier)) {
ED_region_tag_redraw(region);
}
}
}
void ui_block_views_draw_overlays(const ARegion *region, const uiBlock *block)
{
LISTBASE_FOREACH (ViewLink *, view_link, &block->views) {
view_link->view->draw_overlays(*region, *block);
}
}
blender::ui::AbstractView *UI_region_view_find_at(const ARegion *region,
const int xy[2],
const int pad)
{
/* NOTE: Similar to #ui_but_find_mouse_over_ex(). */
if (!ui_region_contains_point_px(region, xy)) {
return nullptr;
}
LISTBASE_FOREACH (uiBlock *, block, &region->runtime->uiblocks) {
float mx = xy[0], my = xy[1];
ui_window_to_block_fl(region, block, &mx, &my);
LISTBASE_FOREACH (ViewLink *, view_link, &block->views) {
std::optional<rcti> bounds = view_link->view->get_bounds();
if (!bounds) {
continue;
}
rcti padded_bounds = *bounds;
if (pad) {
BLI_rcti_pad(&padded_bounds, pad, pad);
}
if (BLI_rcti_isect_pt(&padded_bounds, mx, my)) {
return view_link->view.get();
}
}
}
return nullptr;
}
ui::AbstractViewItem *UI_region_views_find_item_at(const ARegion &region, const int xy[2])
{
uiButViewItem *item_but = (uiButViewItem *)ui_view_item_find_mouse_over(&region, xy);
if (!item_but) {
return nullptr;
}
return item_but->view_item;
}
ui::AbstractViewItem *UI_region_views_find_active_item(const ARegion *region)
{
uiButViewItem *item_but = (uiButViewItem *)ui_view_item_find_active(region);
if (!item_but) {
return nullptr;
}
return item_but->view_item;
}
uiBut *UI_region_views_find_active_item_but(const ARegion *region)
{
return ui_view_item_find_active(region);
}
void UI_region_views_clear_search_highlight(const ARegion *region)
{
LISTBASE_FOREACH (uiBlock *, block, &region->runtime->uiblocks) {
LISTBASE_FOREACH (ViewLink *, view_link, &block->views) {
view_link->view->clear_search_highlight();
}
}
}
namespace blender::ui {
std::unique_ptr<DropTargetInterface> region_views_find_drop_target_at(const ARegion *region,
const int xy[2])
{
if (ui::AbstractViewItem *item = UI_region_views_find_item_at(*region, xy)) {
if (std::unique_ptr<DropTargetInterface> target = item->create_item_drop_target()) {
return target;
}
}
/* Get style for some sensible padding around the view items. */
const uiStyle *style = UI_style_get_dpi();
if (AbstractView *view = UI_region_view_find_at(region, xy, style->buttonspacex)) {
if (std::unique_ptr<DropTargetInterface> target = view->create_drop_target()) {
return target;
}
}
if (AbstractView *view = UI_region_view_find_at(region, xy, 0)) {
/* If we are above a tree, but not hovering any specific element, dropping something should
* insert it after the last item. */
if (AbstractTreeView *tree_view = dynamic_cast<AbstractTreeView *>(view)) {
/* Find the last item which we want to drop below. */
AbstractTreeViewItem *last_item = nullptr;
tree_view->foreach_root_item([&](AbstractTreeViewItem &item) {
if (!item.is_interactive()) {
return;
}
last_item = &item;
});
if (last_item) {
return last_item->create_item_drop_target();
}
}
}
return nullptr;
}
} // namespace blender::ui
static StringRef ui_block_view_find_idname(const uiBlock &block, const AbstractView &view)
{
/* First get the idname the of the view we're looking for. */
LISTBASE_FOREACH (ViewLink *, view_link, &block.views) {
if (view_link->view.get() == &view) {
return view_link->idname;
}
}
return {};
}
template<class T>
static T *ui_block_view_find_matching_in_old_block_impl(const uiBlock &new_block,
const T &new_view)
{
uiBlock *old_block = new_block.oldblock;
if (!old_block) {
return nullptr;
}
StringRef idname = ui_block_view_find_idname(new_block, new_view);
if (idname.is_empty()) {
return nullptr;
}
LISTBASE_FOREACH (ViewLink *, old_view_link, &old_block->views) {
if (old_view_link->idname == idname) {
return dynamic_cast<T *>(old_view_link->view.get());
}
}
return nullptr;
}
blender::ui::AbstractView *ui_block_view_find_matching_in_old_block(
const uiBlock &new_block, const blender::ui::AbstractView &new_view)
{
return ui_block_view_find_matching_in_old_block_impl(new_block, new_view);
}
uiButViewItem *ui_block_view_find_matching_view_item_but_in_old_block(
const uiBlock &new_block, const ui::AbstractViewItem &new_item)
{
uiBlock *old_block = new_block.oldblock;
if (!old_block) {
return nullptr;
}
const AbstractView *old_view = ui_block_view_find_matching_in_old_block_impl(
new_block, new_item.get_view());
if (!old_view) {
return nullptr;
}
for (const std::unique_ptr<uiBut> &old_but : old_block->buttons) {
if (old_but->type != UI_BTYPE_VIEW_ITEM) {
continue;
}
uiButViewItem *old_item_but = (uiButViewItem *)old_but.get();
if (!old_item_but->view_item) {
continue;
}
AbstractViewItem &old_item = *reinterpret_cast<AbstractViewItem *>(old_item_but->view_item);
/* Check if the item is from the expected view. */
if (&old_item.get_view() != old_view) {
continue;
}
if (UI_view_item_matches(new_item, old_item)) {
return old_item_but;
}
}
return nullptr;
}