caac241c84
This allows multiple threads to request different specializations without locking usage of all specialized shaders program when a new specialization is being compiled. The specialization constants are bundled in a structure that is being passed to the `Shader::bind()` method. The structure is owned by the calling thread and only used by the `Shader::bind()`. Only querying for the specialized shader (Map lookup) is locking the shader usage. The variant compilation is now also locking and ensured that multiple thread trying to compile the same variant will never result in race condition. Note that this removes the `is_dirty` optimization. This can be added back if this becomes a bottleneck in the future. Otherwise, the performance impact is not noticeable. Pull Request: https://projects.blender.org/blender/blender/pulls/136991
36 lines
1.1 KiB
C++
36 lines
1.1 KiB
C++
/* SPDX-FileCopyrightText: 2023 Blender Authors
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
/** \file
|
|
* \ingroup gpu
|
|
*/
|
|
|
|
#include "GPU_compute.hh"
|
|
|
|
#include "gpu_backend.hh"
|
|
|
|
void GPU_compute_dispatch(GPUShader *shader,
|
|
uint groups_x_len,
|
|
uint groups_y_len,
|
|
uint groups_z_len,
|
|
const blender::gpu::shader::SpecializationConstants *constants_state)
|
|
{
|
|
blender::gpu::GPUBackend &gpu_backend = *blender::gpu::GPUBackend::get();
|
|
GPU_shader_bind(shader, constants_state);
|
|
gpu_backend.compute_dispatch(groups_x_len, groups_y_len, groups_z_len);
|
|
}
|
|
|
|
void GPU_compute_dispatch_indirect(
|
|
GPUShader *shader,
|
|
GPUStorageBuf *indirect_buf_,
|
|
const blender::gpu::shader::SpecializationConstants *constants_state)
|
|
{
|
|
blender::gpu::GPUBackend &gpu_backend = *blender::gpu::GPUBackend::get();
|
|
blender::gpu::StorageBuf *indirect_buf = reinterpret_cast<blender::gpu::StorageBuf *>(
|
|
indirect_buf_);
|
|
|
|
GPU_shader_bind(shader, constants_state);
|
|
gpu_backend.compute_dispatch_indirect(indirect_buf);
|
|
}
|