Files
test/source/blender/render/intern/tile_highlight.cc
Brecht Van Lommel 920e709069 Refactor: Make header files more clangd and clang-tidy friendly
When using clangd or running clang-tidy on headers there are
currently many errors. These are noisy in IDEs, make auto fixes
impossible, and break features like code completion, refactoring
and navigation.

This makes source/blender headers work by themselves, which is
generally the goal anyway. But #includes and forward declarations
were often incomplete.

* Add #includes and forward declarations
* Add IWYU pragma: export in a few places
* Remove some unused #includes (but there are many more)
* Tweak ShaderCreateInfo macros to work better with clangd

Some types of headers still have errors, these could be fixed or
worked around with more investigation. Mostly preprocessor
template headers like NOD_static_types.h.

Note that that disabling WITH_UNITY_BUILD is required for clangd to
work properly, otherwise compile_commands.json does not contain
the information for the relevant source files.

For more details see the developer docs:
https://developer.blender.org/docs/handbook/tooling/clangd/

Pull Request: https://projects.blender.org/blender/blender/pulls/132608
2025-01-07 12:39:13 +01:00

101 lines
2.2 KiB
C++

/* SPDX-FileCopyrightText: 2001-2002 NaN Holding BV. All rights reserved.
*
* SPDX-License-Identifier: GPL-2.0-or-later */
/** \file
* \ingroup render
*/
#include "tile_highlight.h"
#include "BLI_hash.hh"
#include "BLI_rect.h"
#include "RE_pipeline.h"
namespace blender::render {
TilesHighlight::Tile::Tile(const RenderResult *result) : rect(result->tilerect) {}
TilesHighlight::Tile::Tile(const int x, const int y, const int width, const int height)
{
BLI_rcti_init(&rect, x, x + width, y, y + height);
}
uint64_t TilesHighlight::Tile::hash() const
{
return get_default_hash(rect.xmin, rect.xmax, rect.ymin, rect.ymax);
}
void TilesHighlight::highlight_tile_for_result(const RenderResult *result)
{
const Tile tile(result);
highlight_tile(tile);
}
void TilesHighlight::unhighlight_tile_for_result(const RenderResult *result)
{
const Tile tile(result);
unhighlight_tile(tile);
}
void TilesHighlight::highlight_tile(const int x, const int y, const int width, const int height)
{
const Tile tile(x, y, width, height);
highlight_tile(tile);
}
void TilesHighlight::unhighlight_tile(const int x, const int y, const int width, const int height)
{
const Tile tile(x, y, width, height);
unhighlight_tile(tile);
}
void TilesHighlight::highlight_tile(const Tile &tile)
{
std::unique_lock lock(mutex_);
highlighted_tiles_set_.add(tile);
did_tiles_change_ = true;
}
void TilesHighlight::unhighlight_tile(const Tile &tile)
{
std::unique_lock lock(mutex_);
highlighted_tiles_set_.remove(tile);
did_tiles_change_ = true;
}
void TilesHighlight::clear()
{
std::unique_lock lock(mutex_);
highlighted_tiles_set_.clear();
cached_highlighted_tiles_.clear_and_shrink();
}
Span<rcti> TilesHighlight::get_all_highlighted_tiles() const
{
std::unique_lock lock(mutex_);
/* Updated cached flat list if needed. */
if (did_tiles_change_) {
if (highlighted_tiles_set_.is_empty()) {
cached_highlighted_tiles_.clear_and_shrink();
}
else {
cached_highlighted_tiles_.reserve(highlighted_tiles_set_.size());
for (const Tile &tile : highlighted_tiles_set_) {
cached_highlighted_tiles_.append(tile.rect);
}
}
did_tiles_change_ = false;
}
return cached_highlighted_tiles_;
}
} // namespace blender::render