griefith/test
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
Files
399b6ec76c80a8f343747a0459bb3d3df514555f
test/source/blender/blenkernel
History
Campbell Barton 399b6ec76c Mesh: optimize normal calculation 
Optimize mesh normal calculation.

- Remove the intermediate `lnors_weighted` array, accumulate directly
  into the normal array using a spin-lock for thread safety.
- Remove single threaded iteration over loops
  (normal calculation is now fully multi-threaded).
- Remove stack array (alloca) for pre-calculating edge-directions.

Summary of Performance Characteristics:

- The largest gains are for single high poly meshes, with isolated
  normal-calculation benchmarks of meshes over ~1.5 million showing
  2x+ speedup, ~25 million polygons are ~2.85x faster.

- Single lower poly meshes (250k polys) can be ~2x slower.

  Since these meshes aren't normally a bottleneck,
  and this problem isn't noticeable on large scenes,
  we considered the performance trade-off reasonable.

- The performance difference reduces with larger scenes,
  tests with production files from "Sprite Fight" showing
  the same or slightly better overall performance.

NOTE: tested on a AMD Ryzen TR 3970X 32-Core.

For more details & benchmarking scripts, see the patch description.

Reviewed By: mont29

Ref D11993
2021-08-13 10:21:30 +10:00
..
intern
Mesh: optimize normal calculation
2021-08-13 10:21:30 +10:00
BKE_action.h
Cleanup: comment blocks, trailing space in comments
2021-06-24 15:59:34 +10:00
BKE_action.hh
Pose Library: remove assumption about Action group names
2021-07-20 17:12:01 +02:00
BKE_addon.h
Cleanup: use C comments for descriptive text
2020-10-10 22:04:51 +11:00
BKE_anim_data.h
Cleanup: rename BKE_animdata_{add=>ensure}_id
2021-07-09 11:53:16 +10:00
BKE_anim_path.h
Fix T81707: Spline IK Joints "Floating" above curve
2021-04-08 15:52:33 +02:00
BKE_anim_visualization.h
Cleanup: sort struct blocks
2020-12-16 16:26:23 +11:00
BKE_animsys.h
Animation: add function to blend Action into pose
2021-07-15 16:12:36 +02:00
BKE_appdir.h
Cleanup: headers, use 'pragma once', remove argument to '\file'
2021-07-30 22:29:30 +10:00
BKE_armature.h
Cleanup: sort struct declarations
2021-07-16 11:48:54 +10:00
BKE_armature.hh
Pose Library: remove assumption about Action group names
2021-07-20 17:12:01 +02:00
BKE_asset.h
Assets: Add an active asset library per workspace, for the UI to use
2021-07-15 16:12:36 +02:00
BKE_attribute_access.hh
Geometry Nodes: Copy spline attributes in the curve resample node
2021-06-09 15:54:26 -05:00
BKE_attribute_math.hh
Cleanup: comment blocks, trailing space in comments
2021-06-24 15:59:34 +10:00
BKE_attribute.h
Cleanup: spelling in comments
2021-07-07 13:42:46 +10:00
BKE_autoexec.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_blender_copybuffer.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_blender_undo.h
Cleanup/refactor: Undosys: Get rid of the magic values for undo direction.
2021-02-04 22:03:39 +01:00
BKE_blender_user_menu.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_blender_version.h
Fix T83164: Spline IK joint_bindings parameter is broken.
2021-08-05 17:21:25 +02:00
BKE_blender.h
Cleanup: Clang-Tidy readability-inconsistent-declaration-parameter-name fix
2020-09-04 21:04:16 +02:00
BKE_blendfile.h
Revert "Revert "Enhanced stats/reports for blendfile reading.""
2021-06-23 10:37:00 +02:00
BKE_boids.h
Cleanup: reduce indirect DNA header inclusion
2020-12-15 12:34:14 +11:00
BKE_bpath.h
Cleanup: Clang-Tidy readability-inconsistent-declaration-parameter-name fix
2020-09-04 21:04:16 +02:00
BKE_brush.h
Cleanup: rename get_brush_icon, make it a static function
2021-01-04 17:37:44 +11:00
BKE_bvhutils.h
Cleanup: spelling in comments
2021-08-09 22:55:38 +10:00
BKE_cachefile.h
Refactor: remove BKE_<id_type>_copy functions.
2020-10-07 18:05:06 +02:00
BKE_callbacks.h
Docs: formalize naming for generic callbacks in BKE_callbacks.h
2021-06-02 17:35:24 +10:00
BKE_camera.h
Refactor: remove BKE_<id_type>_copy functions.
2020-10-07 18:05:06 +02:00
BKE_ccg.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_cdderivedmesh.h
Cleanup: Clang-Tidy readability-inconsistent-declaration-parameter-name fix
2020-09-04 21:04:16 +02:00
BKE_cloth.h
Cleanup: reserve C++ comments for disabled code
2021-07-20 15:01:05 +10:00
BKE_collection.h
Cleanup: rename BKE_collection_{free => free_data}
2021-08-11 16:09:23 +10:00
BKE_collision.h
Cleanup: full sentences in comments, improve comment formatting
2021-06-26 21:50:48 +10:00
BKE_colorband.h
Cleanup: use bool instead of int in various places
2020-09-02 19:10:40 +02:00
BKE_colortools.h
Python API: Expose CurveMapping Reset View function
2021-03-02 13:13:36 -06:00
BKE_constraint.h
Add Extras Dropdown Menu to Constraints
2021-08-12 14:24:27 +02:00
BKE_context.h
Cleanup: rename FileList::asset_library → asset_library_ref
2021-08-06 15:20:39 +02:00
BKE_crazyspace.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_cryptomatte.h
Cleanup: clang-format, trailing space
2021-03-22 14:25:42 +11:00
BKE_cryptomatte.hh
Compositor: Redesign Cryptomatte node for better usability
2021-03-16 07:43:17 +01:00
BKE_curve.h
Cleanup: Remove unused function, unused declaration
2021-07-19 11:56:52 -04:00
BKE_curveprofile.h
Python API: Expose CurveProfile Reset View function
2021-03-18 17:25:36 -04:00
BKE_customdata_file.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_customdata.h
Cleanup: code comments punctuation / spacing
2021-07-23 17:03:51 +10:00
BKE_data_transfer.h
Cleanup: consistent use of tags: NOTE/TODO/FIXME/XXX
2021-07-04 00:43:40 +10:00
BKE_deform.h
Cleanup: sort struct declarations
2021-07-16 11:48:54 +10:00
BKE_DerivedMesh.h
Cleanup: use single back-tick quoting in comments
2021-07-20 22:58:14 +10:00
BKE_displist_tangent.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_displist.h
Cleanup: Remove unused "for_orco" argument to curve evaluation
2021-06-28 15:14:43 -05:00
BKE_duplilist.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_dynamicpaint.h
Cleanup: Clang-Tidy readability-inconsistent-declaration-parameter-name fix
2020-09-04 21:04:16 +02:00
BKE_editlattice.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_editmesh_bvh.h
Cleanup: clang-format
2020-10-01 14:29:45 +02:00
BKE_editmesh_cache.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_editmesh_tangent.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_editmesh.h
Cleanup: sort struct declarations
2021-07-16 11:48:54 +10:00
BKE_effect.h
Cleanup: full sentences in comments, improve comment formatting
2021-06-26 21:50:48 +10:00
BKE_fcurve_driver.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_fcurve.h
Cleanup: use const arguments for accessor functions
2021-06-30 16:42:19 +10:00
BKE_fluid.h
Fluid: Added domain check for new OpenVDB precision 'Mini' type
2020-10-19 21:40:17 +02:00
BKE_font.h
Cleanup: use const for datatoc declarations
2021-06-30 16:42:19 +10:00
BKE_freestyle.h
Cleanup: reduce indirect DNA header inclusion
2020-12-15 12:34:14 +11:00
BKE_geometry_set_instances.hh
Geometry Nodes: Support instances in attribute search
2021-04-08 12:19:09 -05:00
BKE_geometry_set.h
Geometry Nodes: refactor instances component
2021-05-04 10:16:24 +02:00
BKE_geometry_set.hh
Cleanup: sort struct declarations
2021-07-16 11:48:54 +10:00
BKE_global.h
Fix invalid helps and description of session UUID verification
2021-08-09 12:09:02 +02:00
BKE_gpencil_curve.h
GPencil: Interpolate Tools refactor
2021-02-19 17:41:28 +01:00
BKE_gpencil_geom.h
Cleanup: use const arguments for accessor functions
2021-06-30 16:42:19 +10:00
BKE_gpencil_modifier.h
Fix T89849: Time offset not working with Bake Object transform to Grease pencil
2021-07-14 11:09:25 +02:00
BKE_gpencil.h
Cleanup: remove redundant parentheses
2021-07-16 11:45:52 +10:00
BKE_hair.h
Revert "CleanUp: Introduce eMeshBatchDirtyMode enum"
2020-10-09 07:25:43 +02:00
BKE_icons.h
Fix redundant declaration warning
2020-12-15 17:19:55 +01:00
BKE_idprop.h
Cleanup: full sentences in comments, improve comment formatting
2021-06-26 21:50:48 +10:00
BKE_idtype.h
Cleanup: repeated terms in code comments & error messages
2021-06-28 15:46:08 +10:00
BKE_image_save.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_image.h
Fix T81247: Constrain selected UVs to correct UDIM
2021-05-13 00:12:56 +10:00
BKE_ipo.h
Cleanup: remove redundant struct declarations
2020-12-16 16:25:56 +11:00
BKE_kelvinlet.h
Cleanup: Clang-Tidy readability-inconsistent-declaration-parameter-name fix
2020-09-04 21:04:16 +02:00
BKE_key.h
Cleanup: consistent use of tags: NOTE/TODO/FIXME/XXX
2021-07-04 00:43:40 +10:00
BKE_keyconfig.h
Cleanup: correct spelling in comments
2021-02-05 16:23:34 +11:00
BKE_lattice.h
Cleanup: remove redundant struct declarations
2020-12-16 16:25:56 +11:00
BKE_layer.h
LayerCollections: Add a way to prevent their resync with Collection hierarchy.
2021-07-26 17:36:46 +02:00
BKE_lib_id.h
Cleanup: ID management: remove unused old BKE_libblock_copy_for_localize function.
2021-08-11 14:49:56 +02:00
BKE_lib_override.h
Cleanup: sort struct declarations
2021-07-16 11:48:54 +10:00
BKE_lib_query.h
LibOverride/LibQuery: Refactor 'non-overridable' status management.
2021-05-05 12:51:59 +02:00
BKE_lib_remap.h
Cleanup: consistent use of tags: NOTE/TODO/FIXME/XXX
2021-07-04 00:43:40 +10:00
BKE_library.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_light.h
Refactor: remove BKE_<id_type>_copy functions.
2020-10-07 18:05:06 +02:00
BKE_lightprobe.h
Refactor: remove BKE_<id_type>_copy functions.
2020-10-07 18:05:06 +02:00
BKE_linestyle.h
Refactor: remove BKE_<id_type>_copy functions.
2020-10-07 18:05:06 +02:00
BKE_main_idmap.h
BlenRead: Add GHash-based search for already read linked IDs.
2021-07-27 14:53:49 +02:00
BKE_main.h
BlenRead: Add GHash-based search for already read linked IDs.
2021-07-27 14:53:49 +02:00
BKE_mask.h
Cleanup: use 'r_' prefix for return arguments, order last
2021-02-05 22:34:03 +11:00
BKE_material.h
Geometry Nodes: add empty material slot to new meshes
2021-06-01 15:25:01 +02:00
BKE_mball_tessellate.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_mball.h
Revert "CleanUp: Introduce eMeshBatchDirtyMode enum"
2020-10-09 07:25:43 +02:00
BKE_mesh_boolean_convert.hh
Cleanup: Remove unecessary C API for direct mesh boolean
2021-04-02 00:16:23 -05:00
BKE_mesh_fair.h
Sculpt: Fair Face Sets operation for Face Set Edit
2020-12-15 20:32:58 +01:00
BKE_mesh_iterators.h
Fix T89393: crash when selecting edges when geometry nodes has "on cage" turned on
2021-07-23 16:15:18 +02:00
BKE_mesh_mapping.h
Cleanup: clang-format (re-run after v12 version bump)
2021-07-30 16:19:19 +10:00
BKE_mesh_mirror.h
Cleanup: Sync header+implementaiton definition.
2021-03-05 09:48:49 +01:00
BKE_mesh_remap.h
Cleanup: consistent use of tags: NOTE/TODO/FIXME/XXX
2021-07-04 00:43:40 +10:00
BKE_mesh_remesh_voxel.h
Cleanup: Remove unused/unecessary OpenVDB C API
2021-08-02 12:26:28 -04:00
BKE_mesh_runtime.h
Cleanup: Use const mesh to ensure BVH and triangulation cache
2021-07-02 11:37:01 -05:00
BKE_mesh_sample.hh
Cleanup: Remove unecessary helper function
2021-07-31 14:26:01 -04:00
BKE_mesh_tangent.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_mesh_types.h
Revert "Depsgraph: Implement 'ID_RECALC_GEOMETRY_DEFORM'"
2021-07-19 10:17:38 -03:00
BKE_mesh_wrapper.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_mesh.h
Mesh: Tag normals dirty instead of calculating
2021-08-02 13:47:32 -04:00
BKE_modifier.h
Cleanup: Spelling Mistakes
2021-06-22 10:54:50 -07:00
BKE_movieclip.h
Tracking: Fix movie file prefetch freezing interface
2021-03-22 16:27:35 +01:00
BKE_multires.h
Cleanup: comment blocks, trailing space in comments
2021-06-24 15:59:34 +10:00
BKE_nla.h
Cleanup: consistent use of tags: NOTE/TODO/FIXME/XXX
2021-07-04 00:43:40 +10:00
BKE_node.h
Geometry Nodes: Select by Handle Type Node
2021-08-05 18:42:20 -05:00
BKE_object_deform.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_object_facemap.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_object.h
Revert "Depsgraph: Implement 'ID_RECALC_GEOMETRY_DEFORM'"
2021-07-19 10:17:38 -03:00
BKE_ocean.h
Modifier: warn if the ocean simulation fails to allocate memory
2021-08-04 18:29:43 +10:00
BKE_outliner_treehash.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_packedFile.h
Cleanup: sort struct declarations
2020-09-30 11:51:13 +10:00
BKE_paint.h
Fix sculpt neighbor iterator not taking visibility into account
2021-05-14 03:08:01 +02:00
BKE_particle.h
Cleanup: full sentences in comments, improve comment formatting
2021-06-26 21:50:48 +10:00
BKE_pbvh.h
Cleanup: consistent use of tags: NOTE/TODO/FIXME/XXX
2021-07-04 00:43:40 +10:00
BKE_pointcache.h
Cleanup: Replace int with bool for pointcache function
2021-08-03 15:51:25 +02:00
BKE_pointcloud.h
Geometry Nodes: initial scattering and geometry nodes
2020-12-02 15:38:47 +01:00
BKE_preferences.h
Asset System: Support custom asset library paths through Preferences
2020-12-15 17:03:48 +01:00
BKE_report.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_rigidbody.h
Fix Rigidbody depsgraph passive and constraint transform relations.
2020-08-28 14:55:59 +02:00
BKE_scene.h
Cleanup: improve naming and comments of scene frame/ctime functions
2021-07-12 17:41:15 +02:00
BKE_screen.h
UI/Assets: Initial Asset View UI template
2021-07-15 16:12:36 +02:00
BKE_sequencer_offscreen.h
Cleanup: reduce indirect DNA header inclusion
2020-12-15 12:34:14 +11:00
BKE_shader_fx.h
Cleanup: use const arguments for accessor functions
2021-06-30 16:42:19 +10:00
BKE_shrinkwrap.h
Cleanup: Move remesh files to C++
2021-07-30 13:15:01 -04:00
BKE_simulation.h
Cleanup: reduce indirect DNA header inclusion
2020-12-15 12:34:14 +11:00
BKE_softbody.h
Cleanup: remove unused baking struct members from soft-body
2021-05-11 16:00:38 +10:00
BKE_sound.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_speaker.h
Cleanup: remove redundant struct declarations
2020-12-16 16:25:56 +11:00
BKE_spline.hh
Cleanup: Make spline settings copy function public
2021-08-02 14:21:19 -04:00
BKE_studiolight.h
Cleanup: quiet stringop-overflow compiler warning
2021-07-13 16:54:25 +10:00
BKE_subdiv_ccg.h
UI: Fix Typos in Comments and Docs
2021-02-05 19:08:14 -08:00
BKE_subdiv_deform.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_subdiv_eval.h
Cleanup: Clang-Tidy readability-inconsistent-declaration-parameter-name fix
2020-09-04 21:04:16 +02:00
BKE_subdiv_foreach.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_subdiv_mesh.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_subdiv_topology.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_subdiv.h
Fix subdivision surface wrong for non-limit surface and subdivision level 1
2020-10-01 17:43:41 +02:00
BKE_subsurf.h
Cleanup: comment blocks, trailing space in comments
2021-06-24 15:59:34 +10:00
BKE_text_suggestions.h
Cleanup: reduce indirect DNA header inclusion
2020-12-15 12:34:14 +11:00
BKE_text.h
Cleanup: use const arguments for accessor functions
2021-06-30 16:42:19 +10:00
BKE_texture.h
Refactor: remove BKE_<id_type>_copy functions.
2020-10-07 18:05:06 +02:00
BKE_tracking.h
Cleanup: spelling in comments
2021-07-02 12:15:29 +10:00
BKE_undo_system.h
Undo System: avoid redundant decoding on undo
2021-07-13 19:43:05 +10:00
BKE_unit.h
Add unit for time stored in seconds
2021-06-10 12:15:59 +02:00
BKE_volume_render.h
Cleanup: remove redundant cast, use const casts
2021-06-08 00:23:09 +10:00
BKE_volume_to_mesh.hh
Cleanup: redundant struct declarations
2021-03-04 17:17:19 +11:00
BKE_volume.h
Cleanup: replace BLI_assert(!"text") with BLI_assert_msg(0, "text")
2021-07-15 18:29:01 +10:00
BKE_workspace.h
Fix (unreported) design flow in how workspace's relation data are read from .blend file.
2020-10-02 11:47:34 +02:00
BKE_world.h
Refactor: Remove BKE_XXX_localize(), in favor of using regular ID copying code.
2020-10-07 11:09:36 +02:00
BKE_writeavi.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
BKE_writeffmpeg.h
Code Style: use "#pragma once" in source directory
2020-08-07 09:50:34 +02:00
CMakeLists.txt
USD: add USD importer
2021-08-03 12:33:36 +02:00
nla_private.h
Cleanup: repeated terms in code comments & error messages
2021-06-28 15:46:08 +10:00
particle_private.h
Cleanup: reduce indirect DNA header inclusion
2020-12-15 12:34:14 +11:00
tracking_private.h
Fix T86262: Tracking backwards fails after gap in track
2021-03-15 15:55:09 +01:00