bbbe08d0b0
Tell ffmpeg swscale to do accurate YUV->RGB conversion, instead of slightly faster but not really accurate one. Fixes banding and some color shifts in video files, particularly in dark regions. The accurate conversion is a bit slower though, on 4K resolution video, time taken to convert video frame from YUV to RGB: - x64 (Ryzen 5950X): 2.3ms -> 3.7ms - arm64 (M1 Max): 0.6ms -> 2.9ms My take is that paying 1-2ms per 4K video playback is acceptable since the result is obviously "more correct" and matches what VLC/ffplay produces. From what I can tell, "accurate conversion" turns off some dedicated assembly code paths within ffmpeg. Maybe someday ffmpeg would get accurate and assembly-optimized routines for that. With more accurate decoding, we can now lower the expected render test threshold again, since x64 & arm64 decoding is much closer now. Comparison screenshots in the PR. Pull Request: https://projects.blender.org/blender/blender/pulls/130383
65 lines
1.6 KiB
Python
65 lines
1.6 KiB
Python
#!/usr/bin/env python3
|
|
# SPDX-FileCopyrightText: 2015-2022 Blender Authors
|
|
#
|
|
# SPDX-License-Identifier: Apache-2.0
|
|
|
|
import argparse
|
|
import os
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
|
|
def get_arguments(filepath, output_filepath):
|
|
dirname = os.path.dirname(filepath)
|
|
basedir = os.path.dirname(dirname)
|
|
|
|
args = [
|
|
"--background",
|
|
"--factory-startup",
|
|
"--enable-autoexec",
|
|
"--debug-memory",
|
|
"--debug-exit-on-error",
|
|
filepath,
|
|
"-o", output_filepath,
|
|
"-f", "1",
|
|
"-F", "PNG"]
|
|
|
|
return args
|
|
|
|
|
|
def create_argparse():
|
|
parser = argparse.ArgumentParser()
|
|
parser.add_argument("-blender", nargs="+")
|
|
parser.add_argument("-testdir", nargs=1)
|
|
parser.add_argument("-outdir", nargs=1)
|
|
parser.add_argument("-oiiotool", nargs=1)
|
|
parser.add_argument("--batch", default=False, action="store_true")
|
|
return parser
|
|
|
|
|
|
def main():
|
|
parser = create_argparse()
|
|
args = parser.parse_args()
|
|
|
|
blender = args.blender[0]
|
|
test_dir = args.testdir[0]
|
|
oiiotool = args.oiiotool[0]
|
|
output_dir = args.outdir[0]
|
|
|
|
from modules import render_report
|
|
report = render_report.Report("Sequencer", output_dir, oiiotool)
|
|
report.set_pixelated(True)
|
|
# Default error tolerances are quite large, lower them.
|
|
report.set_fail_threshold(2.0 / 255.0)
|
|
report.set_fail_percent(0.01)
|
|
report.set_reference_dir("reference")
|
|
|
|
test_dir_name = Path(test_dir).name
|
|
ok = report.run(test_dir, blender, get_arguments, batch=args.batch)
|
|
|
|
sys.exit(not ok)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|