958ec9f37f
Previously a storage buffer was used to store draw list commands as it matches already existing APIs. Unfortunately StorageBuffers prefers to be stored on the GPU device and would reduce the benefit of a dynamic draw list. This PR replaces the storage buffer with a regular buffer, which keeps more control where to store the buffer. Pull Request: https://projects.blender.org/blender/blender/pulls/117712
77 lines
1.8 KiB
C++
77 lines
1.8 KiB
C++
/* SPDX-FileCopyrightText: 2022 Blender Authors
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
/** \file
|
|
* \ingroup gpu
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "gpu_drawlist_private.hh"
|
|
|
|
#include "vk_buffer.hh"
|
|
|
|
namespace blender::gpu {
|
|
class VKBatch;
|
|
|
|
class VKDrawList : public DrawList {
|
|
private:
|
|
/**
|
|
* Batch from who the commands are being recorded.
|
|
*/
|
|
VKBatch *batch_ = nullptr;
|
|
|
|
/**
|
|
* Buffer containing the commands.
|
|
*
|
|
* The buffer is host visible and new commands are directly added to the buffer. Reducing
|
|
* the need to copy the commands from an intermediate buffer to the GPU. The commands are only
|
|
* written once and used once.
|
|
*
|
|
* The buffer contains VkDrawIndirectCommands or VkDrawIndirectIndexedCommands.
|
|
*/
|
|
VKBuffer command_buffer_;
|
|
|
|
/**
|
|
* Maximum number of commands that can be recorded per batch. Commands will be flushed when this
|
|
* number of commands are added.
|
|
*/
|
|
const int length_;
|
|
|
|
/**
|
|
* Current number of recorded commands.
|
|
*/
|
|
int command_index_ = 0;
|
|
|
|
public:
|
|
VKDrawList(int list_length);
|
|
|
|
/**
|
|
* Append a new command for the given batch to the draw list.
|
|
*
|
|
* Will flush when batch is different than the previous one or when the command_buffer_ is full.
|
|
*/
|
|
void append(GPUBatch *batch, int instance_first, int instance_count) override;
|
|
|
|
/**
|
|
* Submit buffered commands to the GPU.
|
|
*
|
|
* NOTE: after calling this method the command_index_ and the batch_ are reset.
|
|
*/
|
|
void submit() override;
|
|
|
|
private:
|
|
/**
|
|
* Retrieve command to write to. The returned memory is part of the mapped memory of the
|
|
* commands_buffer_.
|
|
*/
|
|
template<typename CommandType> CommandType &get_command() const
|
|
{
|
|
return MutableSpan<CommandType>(
|
|
static_cast<CommandType *>(command_buffer_.mapped_memory_get()), length_)[command_index_];
|
|
}
|
|
};
|
|
|
|
} // namespace blender::gpu
|