5cd758368a
Quite obscure issue, seemingly caused by the fact that HIP-RT is passing a large (about 20 MB) global array to a different library (HIP driver, via hipModuleLoadData). Having global variables of such size seems to be always problematic as they can not be stored on stack and, possibly, extra mapping is involved here. It is not clear whether it is a quirk of the HIP driver, or Linux, or, maybe, something completely different. It is possible to work-around the problem by making a temporary copy of data on heap memory and pass it to the hipModuleLoadData(). This is how other areas are dealing with modules in Blender. This change contains patch against HIP-RT and the new HIP-RT library compiled with the patch. It seems to fix the problem reported in the report. This change does not resolve OIDN on HIP GPU which seems to have the same issue. However, it is not a recent regression and the bug with OIDN GPU denoising can be reproduced using Blender 4.3. Pull Request: https://projects.blender.org/blender/blender/pulls/135403
27 lines
667 B
Diff
27 lines
667 B
Diff
diff --git a/CMakeLists.txt b/CMakeLists.txt
|
|
index 50eb25e..b13d2da 100644
|
|
--- a/CMakeLists.txt
|
|
+++ b/CMakeLists.txt
|
|
@@ -585,12 +585,16 @@ install(FILES ${HIPRT_ORO_HEADERS}
|
|
DESTINATION include/contrib/Orochi/ParallelPrimitives)
|
|
|
|
# add hipfb files
|
|
-file(GLOB HIPRT_HIPFB_FILES "${BASE_OUTPUT_DIR}/${CMAKE_BUILD_TYPE}/*.hipfb")
|
|
-install(FILES ${HIPRT_HIPFB_FILES}
|
|
- DESTINATION bin)
|
|
-
|
|
-
|
|
+if(PRECOMPILE)
|
|
+ install(FILES ${KERNEL_HIPRT_COMP} ${KERNEL_OROCHI_COMP}
|
|
+ DESTINATION bin)
|
|
+endif()
|
|
|
|
+# Baked headers.
|
|
+if(BAKE_COMPILED_KERNEL)
|
|
+ install(FILES ${KERNEL_HIPRT_H}
|
|
+ DESTINATION include/hiprt/impl)
|
|
+endif()
|
|
|
|
# Project: Unit Test
|
|
if(NOT NO_UNITTEST)
|