Files
test/source/blender/modifiers/intern/MOD_surface.cc
Hans Goudey 91b27ab637 Refactor: Simplify mesh edit mode modifier evaluation
Instead of keeping track of a local array of positions in the modifier
stack itself, use the existing edit mode SoA "edit cache" which already
contains a contiguous array of positions. Combined with positions as a
generic attribute, this means the state is contained just in the mesh
(and the geometry set) making the code much easier to follow.

To do this we make more use of the mesh wrapper system, where we can
pass a `Mesh` that's actually stored with a `BMesh` and the extra
cached array of positions. This also resolves some confusion-- it was
weird to have the mesh wrapper system for this purpose but not use it.

Since we always created a wrapped mesh in edit mode, there's no need
for `MOD_deform_mesh_eval_get` at all anymore. That function was quite
confusing with "eval" in its name when it really retrieved the original
mesh.

Many deform modifiers had placeholder edit mode evaluation functions.
Since these didn't do anything and since the priority is node-based
deformation now, I removed these. The case is documented more in the
modifier type struct callbacks.

Pull Request: https://projects.blender.org/blender/blender/pulls/108637
2023-07-07 13:07:15 +02:00

237 lines
6.3 KiB
C++

/* SPDX-FileCopyrightText: 2005 Blender Foundation
*
* SPDX-License-Identifier: GPL-2.0-or-later */
/** \file
* \ingroup modifiers
*/
#include "BLI_utildefines.h"
#include "BLI_math.h"
#include "BLT_translation.h"
#include "DNA_defaults.h"
#include "DNA_mesh_types.h"
#include "DNA_meshdata_types.h"
#include "DNA_object_types.h"
#include "DNA_scene_types.h"
#include "DNA_screen_types.h"
#include "BKE_bvhutils.h"
#include "BKE_context.h"
#include "BKE_lib_id.h"
#include "BKE_mesh.hh"
#include "BKE_screen.h"
#include "UI_interface.h"
#include "UI_resources.h"
#include "RNA_access.h"
#include "RNA_prototypes.h"
#include "DEG_depsgraph.h"
#include "DEG_depsgraph_query.h"
#include "MOD_modifiertypes.hh"
#include "MOD_ui_common.hh"
#include "MOD_util.hh"
#include "BLO_read_write.h"
#include "MEM_guardedalloc.h"
static void initData(ModifierData *md)
{
SurfaceModifierData *surmd = (SurfaceModifierData *)md;
BLI_assert(MEMCMP_STRUCT_AFTER_IS_ZERO(surmd, modifier));
MEMCPY_STRUCT_AFTER(surmd, DNA_struct_default_get(SurfaceModifierData), modifier);
}
static void copyData(const ModifierData *md_src, ModifierData *md_dst, const int flag)
{
SurfaceModifierData *surmd_dst = (SurfaceModifierData *)md_dst;
BKE_modifier_copydata_generic(md_src, md_dst, flag);
memset(&surmd_dst->runtime, 0, sizeof(surmd_dst->runtime));
}
static void freeData(ModifierData *md)
{
SurfaceModifierData *surmd = (SurfaceModifierData *)md;
if (surmd) {
if (surmd->runtime.bvhtree) {
free_bvhtree_from_mesh(surmd->runtime.bvhtree);
MEM_SAFE_FREE(surmd->runtime.bvhtree);
}
if (surmd->runtime.mesh) {
BKE_id_free(nullptr, surmd->runtime.mesh);
surmd->runtime.mesh = nullptr;
}
MEM_SAFE_FREE(surmd->runtime.vert_positions_prev);
MEM_SAFE_FREE(surmd->runtime.vert_velocities);
}
}
static bool dependsOnTime(Scene * /*scene*/, ModifierData * /*md*/)
{
return true;
}
static void deformVerts(ModifierData *md,
const ModifierEvalContext *ctx,
Mesh *mesh,
float (*vertexCos)[3],
int /*verts_num*/)
{
SurfaceModifierData *surmd = (SurfaceModifierData *)md;
const int cfra = int(DEG_get_ctime(ctx->depsgraph));
/* Free mesh and BVH cache. */
if (surmd->runtime.bvhtree) {
free_bvhtree_from_mesh(surmd->runtime.bvhtree);
MEM_SAFE_FREE(surmd->runtime.bvhtree);
}
if (surmd->runtime.mesh) {
BKE_id_free(nullptr, surmd->runtime.mesh);
surmd->runtime.mesh = nullptr;
}
if (mesh) {
surmd->runtime.mesh = BKE_mesh_copy_for_eval(mesh);
}
if (!ctx->object->pd) {
printf("SurfaceModifier deformVerts: Should not happen!\n");
return;
}
if (surmd->runtime.mesh) {
uint mesh_verts_num = 0, i = 0;
int init = 0;
BKE_mesh_vert_coords_apply(surmd->runtime.mesh, vertexCos);
mesh_verts_num = surmd->runtime.mesh->totvert;
if ((mesh_verts_num != surmd->runtime.verts_num) ||
(surmd->runtime.vert_positions_prev == nullptr) ||
(surmd->runtime.vert_velocities == nullptr) || (cfra != surmd->runtime.cfra_prev + 1))
{
MEM_SAFE_FREE(surmd->runtime.vert_positions_prev);
MEM_SAFE_FREE(surmd->runtime.vert_velocities);
surmd->runtime.vert_positions_prev = static_cast<float(*)[3]>(
MEM_calloc_arrayN(mesh_verts_num, sizeof(float[3]), __func__));
surmd->runtime.vert_velocities = static_cast<float(*)[3]>(
MEM_calloc_arrayN(mesh_verts_num, sizeof(float[3]), __func__));
surmd->runtime.verts_num = mesh_verts_num;
init = 1;
}
/* convert to global coordinates and calculate velocity */
blender::MutableSpan<blender::float3> positions =
surmd->runtime.mesh->vert_positions_for_write();
for (i = 0; i < mesh_verts_num; i++) {
float *vec = positions[i];
mul_m4_v3(ctx->object->object_to_world, vec);
if (init) {
zero_v3(surmd->runtime.vert_velocities[i]);
}
else {
sub_v3_v3v3(surmd->runtime.vert_velocities[i], vec, surmd->runtime.vert_positions_prev[i]);
}
copy_v3_v3(surmd->runtime.vert_positions_prev[i], vec);
}
surmd->runtime.cfra_prev = cfra;
const bool has_poly = surmd->runtime.mesh->totpoly > 0;
const bool has_edge = surmd->runtime.mesh->totedge > 0;
if (has_poly || has_edge) {
surmd->runtime.bvhtree = static_cast<BVHTreeFromMesh *>(
MEM_callocN(sizeof(BVHTreeFromMesh), __func__));
if (has_poly) {
BKE_bvhtree_from_mesh_get(
surmd->runtime.bvhtree, surmd->runtime.mesh, BVHTREE_FROM_LOOPTRI, 2);
}
else if (has_edge) {
BKE_bvhtree_from_mesh_get(
surmd->runtime.bvhtree, surmd->runtime.mesh, BVHTREE_FROM_EDGES, 2);
}
}
}
}
static void panel_draw(const bContext * /*C*/, Panel *panel)
{
uiLayout *layout = panel->layout;
PointerRNA *ptr = modifier_panel_get_property_pointers(panel, nullptr);
uiItemL(layout, TIP_("Settings are inside the Physics tab"), ICON_NONE);
modifier_panel_end(layout, ptr);
}
static void panelRegister(ARegionType *region_type)
{
modifier_panel_register(region_type, eModifierType_Surface, panel_draw);
}
static void blendRead(BlendDataReader * /*reader*/, ModifierData *md)
{
SurfaceModifierData *surmd = (SurfaceModifierData *)md;
memset(&surmd->runtime, 0, sizeof(surmd->runtime));
}
ModifierTypeInfo modifierType_Surface = {
/*name*/ N_("Surface"),
/*structName*/ "SurfaceModifierData",
/*structSize*/ sizeof(SurfaceModifierData),
/*srna*/ &RNA_SurfaceModifier,
/*type*/ eModifierTypeType_OnlyDeform,
/*flags*/ eModifierTypeFlag_AcceptsMesh | eModifierTypeFlag_AcceptsCVs |
eModifierTypeFlag_NoUserAdd,
/*icon*/ ICON_MOD_PHYSICS,
/*copyData*/ copyData,
/*deformVerts*/ deformVerts,
/*deformMatrices*/ nullptr,
/*deformVertsEM*/ nullptr,
/*deformMatricesEM*/ nullptr,
/*modifyMesh*/ nullptr,
/*modifyGeometrySet*/ nullptr,
/*initData*/ initData,
/*requiredDataMask*/ nullptr,
/*freeData*/ freeData,
/*isDisabled*/ nullptr,
/*updateDepsgraph*/ nullptr,
/*dependsOnTime*/ dependsOnTime,
/*dependsOnNormals*/ nullptr,
/*foreachIDLink*/ nullptr,
/*foreachTexLink*/ nullptr,
/*freeRuntimeData*/ nullptr,
/*panelRegister*/ panelRegister,
/*blendWrite*/ nullptr,
/*blendRead*/ blendRead,
};