While the evaluated result is not well defined, we expect Blender to not crash when there are dependency cycles. The evaluation of one object often takes the evaluated geometry of another object into account. This works fine if the other object is already fully evaluated. However, if there is a dependency cycle, the other object may not be evaluated already. Currently, we have no way to check for this and were mostly just relying on luck that the other objects geometry is in some valid state (even if it's not the fully evaluated geometry). This patch adds the ability to explicitly check if an objects geometry is fully evaluated already, so that it can be accessed by other objects. If there are not dependency cycles, this should always be true. If not, it may be false sometimes, and in this case the other objects geometry should be ignored. The same also applies to the object transforms and the geometry of a collection. For that, new functions are added in `DEG_depsgraph_query.hh`. Those should be used whenever accessing another objects or collections object during depsgraph evaluation. More similar functions may be added in the future. ``` bool DEG_object_geometry_is_evaluated(const Object &object); bool DEG_object_transform_is_evaluated(const Object &object); bool DEG_collection_geometry_is_evaluated(const Collection &collection); ``` To determine if the these components are fully evaluated, a reference to the corresponding depsgraph is needed. A possible solution to that is to pass the depsgraph through the call stack to these functions. While possible, there are a couple of annoyances. For one, the parameter would need to be added in many new places. I don't have an exact number, but it's like 50 or so. Another complication is that under some circumstances, multiple depsgraphs may have to be passed around, for example when evaluating node tools (also see `GeoNodesOperatorDepsgraphs`). To simplify the patch and other code in the future, a different route is taken where the depsgraph pointer is added to `ID_Runtime`, making it readily accessible similar to the `ID.orig_id`. The depsgraph pointer is set in the same place where the `orig_id` is set. As a nice side benefit, this also improves the situation in simple cases like having two cubes with a boolean modifier and they union each other. Pull Request: https://projects.blender.org/blender/blender/pulls/123444
419 lines
13 KiB
C++
419 lines
13 KiB
C++
/* SPDX-FileCopyrightText: 2013 Blender Authors
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
/** \file
|
|
* \ingroup depsgraph
|
|
*
|
|
* Implementation of Querying API
|
|
*/
|
|
|
|
#include "MEM_guardedalloc.h"
|
|
|
|
#include <cstring> /* XXX: `memcpy`. */
|
|
|
|
#include "BLI_listbase.h"
|
|
#include "BLI_utildefines.h"
|
|
|
|
#include "BKE_action.h" /* XXX: BKE_pose_channel_find_name */
|
|
#include "BKE_customdata.hh"
|
|
#include "BKE_idtype.hh"
|
|
#include "BKE_main.hh"
|
|
|
|
#include "DNA_object_types.h"
|
|
#include "DNA_scene_types.h"
|
|
|
|
#include "RNA_access.hh"
|
|
#include "RNA_path.hh"
|
|
#include "RNA_prototypes.h"
|
|
|
|
#include "DEG_depsgraph.hh"
|
|
#include "DEG_depsgraph_query.hh"
|
|
|
|
#include "intern/depsgraph.hh"
|
|
#include "intern/eval/deg_eval_copy_on_write.h"
|
|
#include "intern/node/deg_node_component.hh"
|
|
#include "intern/node/deg_node_id.hh"
|
|
|
|
namespace blender::deg {
|
|
|
|
static const ID *get_original_id(const ID *id)
|
|
{
|
|
if (id == nullptr) {
|
|
return nullptr;
|
|
}
|
|
if (id->orig_id == nullptr) {
|
|
return id;
|
|
}
|
|
BLI_assert((id->tag & LIB_TAG_COPIED_ON_EVAL) != 0);
|
|
return (ID *)id->orig_id;
|
|
}
|
|
|
|
static ID *get_original_id(ID *id)
|
|
{
|
|
const ID *const_id = id;
|
|
return const_cast<ID *>(get_original_id(const_id));
|
|
}
|
|
|
|
static const ID *get_evaluated_id(const Depsgraph *deg_graph, const ID *id)
|
|
{
|
|
if (id == nullptr) {
|
|
return nullptr;
|
|
}
|
|
/* TODO(sergey): This is a duplicate of Depsgraph::get_cow_id(),
|
|
* but here we never do assert, since we don't know nature of the
|
|
* incoming ID data-block. */
|
|
const IDNode *id_node = deg_graph->find_id_node(id);
|
|
if (id_node == nullptr) {
|
|
return id;
|
|
}
|
|
return id_node->id_cow;
|
|
}
|
|
|
|
static ID *get_evaluated_id(const Depsgraph *deg_graph, ID *id)
|
|
{
|
|
const ID *const_id = id;
|
|
return const_cast<ID *>(get_evaluated_id(deg_graph, const_id));
|
|
}
|
|
|
|
} // namespace blender::deg
|
|
|
|
namespace deg = blender::deg;
|
|
|
|
Scene *DEG_get_input_scene(const Depsgraph *graph)
|
|
{
|
|
const deg::Depsgraph *deg_graph = reinterpret_cast<const deg::Depsgraph *>(graph);
|
|
return deg_graph->scene;
|
|
}
|
|
|
|
ViewLayer *DEG_get_input_view_layer(const Depsgraph *graph)
|
|
{
|
|
const deg::Depsgraph *deg_graph = reinterpret_cast<const deg::Depsgraph *>(graph);
|
|
return deg_graph->view_layer;
|
|
}
|
|
|
|
Main *DEG_get_bmain(const Depsgraph *graph)
|
|
{
|
|
const deg::Depsgraph *deg_graph = reinterpret_cast<const deg::Depsgraph *>(graph);
|
|
return deg_graph->bmain;
|
|
}
|
|
|
|
eEvaluationMode DEG_get_mode(const Depsgraph *graph)
|
|
{
|
|
const deg::Depsgraph *deg_graph = reinterpret_cast<const deg::Depsgraph *>(graph);
|
|
return deg_graph->mode;
|
|
}
|
|
|
|
float DEG_get_ctime(const Depsgraph *graph)
|
|
{
|
|
const deg::Depsgraph *deg_graph = reinterpret_cast<const deg::Depsgraph *>(graph);
|
|
return deg_graph->ctime;
|
|
}
|
|
|
|
bool DEG_id_type_updated(const Depsgraph *graph, short id_type)
|
|
{
|
|
const deg::Depsgraph *deg_graph = reinterpret_cast<const deg::Depsgraph *>(graph);
|
|
return deg_graph->id_type_updated[BKE_idtype_idcode_to_index(id_type)] != 0;
|
|
}
|
|
|
|
bool DEG_id_type_any_updated(const Depsgraph *graph)
|
|
{
|
|
const deg::Depsgraph *deg_graph = reinterpret_cast<const deg::Depsgraph *>(graph);
|
|
|
|
/* Loop over all ID types. */
|
|
for (char id_type_index : deg_graph->id_type_updated) {
|
|
if (id_type_index) {
|
|
return true;
|
|
}
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool DEG_id_type_any_exists(const Depsgraph *depsgraph, short id_type)
|
|
{
|
|
const deg::Depsgraph *deg_graph = reinterpret_cast<const deg::Depsgraph *>(depsgraph);
|
|
return deg_graph->id_type_exist[BKE_idtype_idcode_to_index(id_type)] != 0;
|
|
}
|
|
|
|
uint32_t DEG_get_eval_flags_for_id(const Depsgraph *graph, const ID *id)
|
|
{
|
|
if (graph == nullptr) {
|
|
/* Happens when converting objects to mesh from a python script
|
|
* after modifying scene graph.
|
|
*
|
|
* Currently harmless because it's only called for temporary
|
|
* objects which are out of the DAG anyway. */
|
|
return 0;
|
|
}
|
|
|
|
const deg::Depsgraph *deg_graph = reinterpret_cast<const deg::Depsgraph *>(graph);
|
|
const deg::IDNode *id_node = deg_graph->find_id_node(deg::get_original_id(id));
|
|
if (id_node == nullptr) {
|
|
/* TODO(sergey): Does it mean we need to check set scene? */
|
|
return 0;
|
|
}
|
|
|
|
return id_node->eval_flags;
|
|
}
|
|
|
|
void DEG_get_customdata_mask_for_object(const Depsgraph *graph,
|
|
Object *ob,
|
|
CustomData_MeshMasks *r_mask)
|
|
{
|
|
if (graph == nullptr) {
|
|
/* Happens when converting objects to mesh from a python script
|
|
* after modifying scene graph.
|
|
*
|
|
* Currently harmless because it's only called for temporary
|
|
* objects which are out of the DAG anyway. */
|
|
return;
|
|
}
|
|
|
|
const deg::Depsgraph *deg_graph = reinterpret_cast<const deg::Depsgraph *>(graph);
|
|
const deg::IDNode *id_node = deg_graph->find_id_node(DEG_get_original_id(&ob->id));
|
|
if (id_node == nullptr) {
|
|
/* TODO(sergey): Does it mean we need to check set scene? */
|
|
return;
|
|
}
|
|
|
|
r_mask->vmask |= id_node->customdata_masks.vert_mask;
|
|
r_mask->emask |= id_node->customdata_masks.edge_mask;
|
|
r_mask->fmask |= id_node->customdata_masks.face_mask;
|
|
r_mask->lmask |= id_node->customdata_masks.loop_mask;
|
|
r_mask->pmask |= id_node->customdata_masks.poly_mask;
|
|
}
|
|
|
|
Scene *DEG_get_evaluated_scene(const Depsgraph *graph)
|
|
{
|
|
const deg::Depsgraph *deg_graph = reinterpret_cast<const deg::Depsgraph *>(graph);
|
|
Scene *scene_cow = deg_graph->scene_cow;
|
|
/* TODO(sergey): Shall we expand data-block here? Or is it OK to assume
|
|
* that caller is OK with just a pointer in case scene is not updated yet? */
|
|
BLI_assert(scene_cow != nullptr && deg::deg_eval_copy_is_expanded(&scene_cow->id));
|
|
return scene_cow;
|
|
}
|
|
|
|
ViewLayer *DEG_get_evaluated_view_layer(const Depsgraph *graph)
|
|
{
|
|
const deg::Depsgraph *deg_graph = reinterpret_cast<const deg::Depsgraph *>(graph);
|
|
Scene *scene_cow = DEG_get_evaluated_scene(graph);
|
|
if (scene_cow == nullptr) {
|
|
return nullptr; /* Happens with new, not-yet-built/evaluated graphs. */
|
|
}
|
|
/* Do name-based lookup. */
|
|
/* TODO(sergey): Can this be optimized? */
|
|
ViewLayer *view_layer_orig = deg_graph->view_layer;
|
|
ViewLayer *view_layer_cow = (ViewLayer *)BLI_findstring(
|
|
&scene_cow->view_layers, view_layer_orig->name, offsetof(ViewLayer, name));
|
|
BLI_assert(view_layer_cow != nullptr);
|
|
return view_layer_cow;
|
|
}
|
|
|
|
Object *DEG_get_evaluated_object(const Depsgraph *depsgraph, Object *object)
|
|
{
|
|
if (object == nullptr) {
|
|
return nullptr;
|
|
}
|
|
return (Object *)DEG_get_evaluated_id(depsgraph, &object->id);
|
|
}
|
|
|
|
ID *DEG_get_evaluated_id(const Depsgraph *depsgraph, ID *id)
|
|
{
|
|
return deg::get_evaluated_id(reinterpret_cast<const deg::Depsgraph *>(depsgraph), id);
|
|
}
|
|
|
|
void DEG_get_evaluated_rna_pointer(const Depsgraph *depsgraph,
|
|
PointerRNA *ptr,
|
|
PointerRNA *r_ptr_eval)
|
|
{
|
|
if ((ptr == nullptr) || (r_ptr_eval == nullptr)) {
|
|
return;
|
|
}
|
|
ID *orig_id = ptr->owner_id;
|
|
ID *cow_id = DEG_get_evaluated_id(depsgraph, orig_id);
|
|
if (ptr->owner_id == ptr->data) {
|
|
/* For ID pointers, it's easy... */
|
|
r_ptr_eval->owner_id = cow_id;
|
|
r_ptr_eval->data = (void *)cow_id;
|
|
r_ptr_eval->type = ptr->type;
|
|
}
|
|
else if (ptr->type == &RNA_PoseBone) {
|
|
/* HACK: Since bone keyframing is quite commonly used,
|
|
* speed things up for this case by doing a special lookup
|
|
* for bones */
|
|
const Object *ob_eval = (Object *)cow_id;
|
|
bPoseChannel *pchan = (bPoseChannel *)ptr->data;
|
|
const bPoseChannel *pchan_eval = BKE_pose_channel_find_name(ob_eval->pose, pchan->name);
|
|
r_ptr_eval->owner_id = cow_id;
|
|
r_ptr_eval->data = (void *)pchan_eval;
|
|
r_ptr_eval->type = ptr->type;
|
|
}
|
|
else {
|
|
/* For everything else, try to get RNA Path of the BMain-pointer,
|
|
* then use that to look up what the evaluated one should be
|
|
* given the evaluated ID pointer as the new lookup point */
|
|
/* TODO: Find a faster alternative, or implement support for other
|
|
* common types too above (e.g. modifiers) */
|
|
if (const std::optional<std::string> path = RNA_path_from_ID_to_struct(ptr)) {
|
|
PointerRNA cow_id_ptr = RNA_id_pointer_create(cow_id);
|
|
if (!RNA_path_resolve(&cow_id_ptr, path->c_str(), r_ptr_eval, nullptr)) {
|
|
/* Couldn't find evaluated copy of data */
|
|
fprintf(stderr,
|
|
"%s: Couldn't resolve RNA path ('%s') relative to evaluated ID (%p) for '%s'\n",
|
|
__func__,
|
|
path->c_str(),
|
|
(void *)cow_id,
|
|
orig_id->name);
|
|
}
|
|
}
|
|
else {
|
|
/* Path resolution failed - XXX: Hide this behind a debug flag */
|
|
fprintf(stderr,
|
|
"%s: Couldn't get RNA path for %s relative to %s\n",
|
|
__func__,
|
|
RNA_struct_identifier(ptr->type),
|
|
orig_id->name);
|
|
}
|
|
}
|
|
}
|
|
|
|
Object *DEG_get_original_object(Object *object)
|
|
{
|
|
return (Object *)DEG_get_original_id(&object->id);
|
|
}
|
|
|
|
ID *DEG_get_original_id(ID *id)
|
|
{
|
|
return deg::get_original_id(id);
|
|
}
|
|
|
|
Depsgraph *DEG_get_depsgraph_by_id(const ID &id)
|
|
{
|
|
return id.runtime.depsgraph;
|
|
}
|
|
|
|
bool DEG_is_original_id(const ID *id)
|
|
{
|
|
/* Some explanation of the logic.
|
|
*
|
|
* What we want here is to be able to tell whether given ID is a result of dependency graph
|
|
* evaluation or not.
|
|
*
|
|
* All the data-blocks which are created by copy-on-evaluation mechanism will have will be tagged
|
|
* with LIB_TAG_COPIED_ON_EVAL tag. Those data-blocks can not be original.
|
|
*
|
|
* Modifier stack evaluation might create special data-blocks which have all the modifiers
|
|
* applied, and those will be tagged with LIB_TAG_COPIED_ON_EVAL_FINAL_RESULT. Such data-blocks
|
|
* can not be original as well.
|
|
*
|
|
* Localization is usually happening from evaluated data-block, or will have some special pointer
|
|
* magic which will make them to act as evaluated.
|
|
*
|
|
* NOTE: We consider ID evaluated if ANY of those flags is set. We do NOT require ALL of them. */
|
|
if (id->tag & (LIB_TAG_COPIED_ON_EVAL | LIB_TAG_COPIED_ON_EVAL_FINAL_RESULT | LIB_TAG_LOCALIZED))
|
|
{
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool DEG_is_original_object(const Object *object)
|
|
{
|
|
return DEG_is_original_id(&object->id);
|
|
}
|
|
|
|
bool DEG_is_evaluated_id(const ID *id)
|
|
{
|
|
return !DEG_is_original_id(id);
|
|
}
|
|
|
|
bool DEG_is_evaluated_object(const Object *object)
|
|
{
|
|
return !DEG_is_original_object(object);
|
|
}
|
|
|
|
bool DEG_is_fully_evaluated(const Depsgraph *depsgraph)
|
|
{
|
|
const deg::Depsgraph *deg_graph = (const deg::Depsgraph *)depsgraph;
|
|
/* Check whether relations are up to date. */
|
|
if (deg_graph->need_update_relations) {
|
|
return false;
|
|
}
|
|
/* Check whether IDs are up to date. */
|
|
if (!deg_graph->entry_tags.is_empty()) {
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool DEG_id_is_fully_evaluated(const Depsgraph *depsgraph, const ID *id_eval)
|
|
{
|
|
const deg::Depsgraph *deg_graph = reinterpret_cast<const deg::Depsgraph *>(depsgraph);
|
|
/* Only us the original ID pointer to look up the IDNode, do not dereference it. */
|
|
const ID *id_orig = deg::get_original_id(id_eval);
|
|
const deg::IDNode *id_node = deg_graph->find_id_node(id_orig);
|
|
if (!id_node) {
|
|
return false;
|
|
}
|
|
for (deg::ComponentNode *component : id_node->components.values()) {
|
|
for (deg::OperationNode *operation : component->operations) {
|
|
if (operation->flag & deg::DEPSOP_FLAG_NEEDS_UPDATE) {
|
|
return false;
|
|
}
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
static bool operation_needs_update(const ID &id,
|
|
const deg::NodeType component_type,
|
|
const deg::OperationCode opcode)
|
|
{
|
|
const Depsgraph *depsgraph = DEG_get_depsgraph_by_id(id);
|
|
if (!depsgraph) {
|
|
return false;
|
|
}
|
|
const deg::Depsgraph °_graph = *reinterpret_cast<const deg::Depsgraph *>(depsgraph);
|
|
/* Only us the original ID pointer to look up the IDNode, do not dereference it. */
|
|
const ID *id_orig = deg::get_original_id(&id);
|
|
if (!id_orig) {
|
|
return false;
|
|
}
|
|
const deg::IDNode *id_node = deg_graph.find_id_node(id_orig);
|
|
if (!id_node) {
|
|
return false;
|
|
};
|
|
const deg::ComponentNode *component_node = id_node->find_component(component_type);
|
|
if (!component_node) {
|
|
return false;
|
|
}
|
|
const deg::OperationNode *operation_node = component_node->find_operation(opcode);
|
|
if (!operation_node) {
|
|
return false;
|
|
}
|
|
/* Technically, there is potential for a race condition here, because the depsgraph evaluation
|
|
* might update this flag, but it's very unlikely to cause issues right now. Maybe this should
|
|
* become an atomic eventually. */
|
|
const bool needs_update = operation_node->flag & deg::DEPSOP_FLAG_NEEDS_UPDATE;
|
|
return needs_update;
|
|
}
|
|
|
|
bool DEG_object_geometry_is_evaluated(const Object &object)
|
|
{
|
|
return !operation_needs_update(
|
|
object.id, deg::NodeType::GEOMETRY, deg::OperationCode::GEOMETRY_EVAL);
|
|
}
|
|
|
|
bool DEG_object_transform_is_evaluated(const Object &object)
|
|
{
|
|
return !operation_needs_update(
|
|
object.id, deg::NodeType::TRANSFORM, deg::OperationCode::TRANSFORM_FINAL);
|
|
}
|
|
|
|
bool DEG_collection_geometry_is_evaluated(const Collection &collection)
|
|
{
|
|
return !operation_needs_update(
|
|
collection.id, deg::NodeType::GEOMETRY, deg::OperationCode::GEOMETRY_EVAL_DONE);
|
|
}
|