58e0ca99a9
Image operation's get_im_buf() function was not thread-safe: - It had TOCTOU issue around calculating multi-layer indices and requesting to load the image buffer. - It accessed render result, render layer and pass pointers without any thread guards. This change moves all the logic needed to access the image buffer into a single function with proper guards around the access. The result is user-counted, so it is usable in a thread even if another thread modifies the image. The is still potential TOCTOU in the compositor since the image is acquired twice: once from init_execution(), and once from the determine_canvas(). It could cause issues if image resolution is changed between these calls. It is still to be looked into. Ref #118337, #121761
96 lines
2.4 KiB
C++
96 lines
2.4 KiB
C++
/* SPDX-FileCopyrightText: 2011 Blender Authors
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
#include "COM_ImageOperation.h"
|
|
|
|
#include "BKE_scene.hh"
|
|
|
|
#include "IMB_colormanagement.hh"
|
|
#include "IMB_interp.hh"
|
|
|
|
namespace blender::compositor {
|
|
|
|
BaseImageOperation::BaseImageOperation()
|
|
{
|
|
image_ = nullptr;
|
|
buffer_ = nullptr;
|
|
image_user_ = {};
|
|
imagewidth_ = 0;
|
|
imageheight_ = 0;
|
|
framenumber_ = 0;
|
|
number_of_channels_ = 0;
|
|
rd_ = nullptr;
|
|
view_name_ = nullptr;
|
|
}
|
|
ImageOperation::ImageOperation() : BaseImageOperation()
|
|
{
|
|
this->add_output_socket(DataType::Color);
|
|
}
|
|
ImageAlphaOperation::ImageAlphaOperation() : BaseImageOperation()
|
|
{
|
|
this->add_output_socket(DataType::Value);
|
|
}
|
|
|
|
ImBuf *BaseImageOperation::get_im_buf()
|
|
{
|
|
if (rd_ == nullptr || image_ == nullptr) {
|
|
return nullptr;
|
|
}
|
|
|
|
ImBuf *ibuf = BKE_image_acquire_multilayer_view_ibuf(*rd_, *image_, image_user_, "", view_name_);
|
|
if (ibuf == nullptr || (ibuf->byte_buffer.data == nullptr && ibuf->float_buffer.data == nullptr))
|
|
{
|
|
BKE_image_release_ibuf(image_, ibuf, nullptr);
|
|
return nullptr;
|
|
}
|
|
return ibuf;
|
|
}
|
|
|
|
void BaseImageOperation::init_execution()
|
|
{
|
|
ImBuf *stackbuf = get_im_buf();
|
|
buffer_ = stackbuf;
|
|
if (stackbuf) {
|
|
imagewidth_ = stackbuf->x;
|
|
imageheight_ = stackbuf->y;
|
|
number_of_channels_ = stackbuf->channels;
|
|
}
|
|
}
|
|
|
|
void BaseImageOperation::deinit_execution()
|
|
{
|
|
BKE_image_release_ibuf(image_, buffer_, nullptr);
|
|
}
|
|
|
|
void BaseImageOperation::determine_canvas(const rcti & /*preferred_area*/, rcti &r_area)
|
|
{
|
|
ImBuf *stackbuf = get_im_buf();
|
|
|
|
r_area = COM_AREA_NONE;
|
|
|
|
if (stackbuf) {
|
|
BLI_rcti_init(&r_area, 0, stackbuf->x, 0, stackbuf->y);
|
|
}
|
|
|
|
BKE_image_release_ibuf(image_, stackbuf, nullptr);
|
|
}
|
|
|
|
void ImageOperation::update_memory_buffer_partial(MemoryBuffer *output,
|
|
const rcti &area,
|
|
Span<MemoryBuffer *> /*inputs*/)
|
|
{
|
|
const bool ensure_premultiplied = !ELEM(
|
|
image_->alpha_mode, IMA_ALPHA_CHANNEL_PACKED, IMA_ALPHA_IGNORE);
|
|
output->copy_from(buffer_, area, ensure_premultiplied, true);
|
|
}
|
|
|
|
void ImageAlphaOperation::update_memory_buffer_partial(MemoryBuffer *output,
|
|
const rcti &area,
|
|
Span<MemoryBuffer *> /*inputs*/)
|
|
{
|
|
output->copy_from(buffer_, area, 3, COM_DATA_TYPE_VALUE_CHANNELS, 0);
|
|
}
|
|
|
|
} // namespace blender::compositor
|