f428fd8229
Previous GHOST_ContextVK would create a logical device for each context. Blender uses multiple contexts at the same time and wasn't able to share resources between them as the logical device where different. This patch will create a single logical device and share them between multiple contexts. This allows sharing memory/shaders between contexts and make sure that all memory allocations are freed from the device it was allocated from. Some allocations in Blender are freed when there isn't a context, this was failing in the previous implementation. We didn't noticed it before as we didn't test multiple contexts. This patch also moves device specific data structures from VKContext to VKDevice like the descriptor pools, debug layers etc. Pull Request: https://projects.blender.org/blender/blender/pulls/107606
78 lines
2.2 KiB
C++
78 lines
2.2 KiB
C++
/* SPDX-License-Identifier: GPL-2.0-or-later
|
|
* Copyright 2023 Blender Foundation */
|
|
|
|
/** \file
|
|
* \ingroup gpu
|
|
*/
|
|
|
|
#include "vk_pipeline.hh"
|
|
#include "vk_backend.hh"
|
|
#include "vk_context.hh"
|
|
#include "vk_memory.hh"
|
|
|
|
namespace blender::gpu {
|
|
|
|
VKPipeline::VKPipeline(VkPipeline vk_pipeline,
|
|
VkDescriptorSetLayout vk_descriptor_set_layout,
|
|
VKPushConstants &&push_constants)
|
|
: vk_pipeline_(vk_pipeline),
|
|
descriptor_set_(vk_descriptor_set_layout),
|
|
push_constants_(std::move(push_constants))
|
|
{
|
|
}
|
|
|
|
VKPipeline::~VKPipeline()
|
|
{
|
|
VK_ALLOCATION_CALLBACKS
|
|
const VKDevice &device = VKBackend::get().device_get();
|
|
if (vk_pipeline_ != VK_NULL_HANDLE) {
|
|
vkDestroyPipeline(device.device_get(), vk_pipeline_, vk_allocation_callbacks);
|
|
}
|
|
}
|
|
|
|
VKPipeline VKPipeline::create_compute_pipeline(
|
|
VkShaderModule compute_module,
|
|
VkDescriptorSetLayout &descriptor_set_layout,
|
|
VkPipelineLayout &pipeline_layout,
|
|
const VKPushConstants::Layout &push_constants_layout)
|
|
{
|
|
VK_ALLOCATION_CALLBACKS
|
|
const VKDevice &device = VKBackend::get().device_get();
|
|
VkComputePipelineCreateInfo pipeline_info = {};
|
|
pipeline_info.sType = VK_STRUCTURE_TYPE_COMPUTE_PIPELINE_CREATE_INFO;
|
|
pipeline_info.flags = 0;
|
|
pipeline_info.stage = {};
|
|
pipeline_info.stage.sType = VK_STRUCTURE_TYPE_PIPELINE_SHADER_STAGE_CREATE_INFO;
|
|
pipeline_info.stage.flags = 0;
|
|
pipeline_info.stage.stage = VK_SHADER_STAGE_COMPUTE_BIT;
|
|
pipeline_info.stage.module = compute_module;
|
|
pipeline_info.layout = pipeline_layout;
|
|
pipeline_info.stage.pName = "main";
|
|
|
|
VkPipeline vk_pipeline;
|
|
if (vkCreateComputePipelines(device.device_get(),
|
|
nullptr,
|
|
1,
|
|
&pipeline_info,
|
|
vk_allocation_callbacks,
|
|
&vk_pipeline) != VK_SUCCESS)
|
|
{
|
|
return VKPipeline();
|
|
}
|
|
|
|
VKPushConstants push_constants(&push_constants_layout);
|
|
return VKPipeline(vk_pipeline, descriptor_set_layout, std::move(push_constants));
|
|
}
|
|
|
|
VkPipeline VKPipeline::vk_handle() const
|
|
{
|
|
return vk_pipeline_;
|
|
}
|
|
|
|
bool VKPipeline::is_valid() const
|
|
{
|
|
return vk_pipeline_ != VK_NULL_HANDLE;
|
|
}
|
|
|
|
} // namespace blender::gpu
|