5401a69627
The issue is visible when adding an assert in the delta accessors of the TranslateOperation operation (get_delta_x and get_delta_y), and rendering compositor-nodes-desintegrate-wipe-01.blend (either command line or F12, doesn't matter). Seems that under certain circumstances the system might skip determining the area of interest. For such cases ensure delta from the beginning of the threaded code. Pull Request: https://projects.blender.org/blender/blender/pulls/122686
108 lines
2.6 KiB
C++
108 lines
2.6 KiB
C++
/* SPDX-FileCopyrightText: 2011 Blender Authors
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
#pragma once
|
|
|
|
#include "BLI_utildefines.h"
|
|
#include "COM_ConstantOperation.h"
|
|
#include "COM_MultiThreadedOperation.h"
|
|
|
|
#include <mutex>
|
|
|
|
namespace blender::compositor {
|
|
|
|
class TranslateOperation : public MultiThreadedOperation {
|
|
protected:
|
|
static constexpr int IMAGE_INPUT_INDEX = 0;
|
|
static constexpr int X_INPUT_INDEX = 1;
|
|
static constexpr int Y_INPUT_INDEX = 2;
|
|
|
|
private:
|
|
float delta_x_;
|
|
float delta_y_;
|
|
bool is_delta_set_;
|
|
bool is_relative_;
|
|
PixelSampler sampler_;
|
|
|
|
std::mutex mutex_;
|
|
|
|
protected:
|
|
MemoryBufferExtend x_extend_mode_;
|
|
MemoryBufferExtend y_extend_mode_;
|
|
|
|
public:
|
|
TranslateOperation();
|
|
TranslateOperation(DataType data_type, ResizeMode mode = ResizeMode::Center);
|
|
|
|
float get_delta_x()
|
|
{
|
|
BLI_assert(is_delta_set_);
|
|
return delta_x_;
|
|
}
|
|
float get_delta_y()
|
|
{
|
|
BLI_assert(is_delta_set_);
|
|
return delta_y_;
|
|
}
|
|
|
|
void set_is_relative(const bool is_relative)
|
|
{
|
|
is_relative_ = is_relative;
|
|
}
|
|
bool get_is_relative()
|
|
{
|
|
return is_relative_;
|
|
}
|
|
|
|
PixelSampler get_sampler()
|
|
{
|
|
return sampler_;
|
|
}
|
|
void set_sampler(PixelSampler sampler)
|
|
{
|
|
sampler_ = sampler;
|
|
}
|
|
|
|
inline void ensure_delta()
|
|
{
|
|
if (!is_delta_set_) {
|
|
std::unique_lock lock(mutex_);
|
|
if (is_delta_set_) {
|
|
return;
|
|
}
|
|
|
|
delta_x_ = get_input_operation(X_INPUT_INDEX)->get_constant_value_default(0.0f);
|
|
delta_y_ = get_input_operation(Y_INPUT_INDEX)->get_constant_value_default(0.0f);
|
|
if (get_is_relative()) {
|
|
const int input_width = BLI_rcti_size_x(
|
|
&get_input_operation(IMAGE_INPUT_INDEX)->get_canvas());
|
|
const int input_height = BLI_rcti_size_y(
|
|
&get_input_operation(IMAGE_INPUT_INDEX)->get_canvas());
|
|
delta_x_ *= input_width;
|
|
delta_y_ *= input_height;
|
|
}
|
|
|
|
is_delta_set_ = true;
|
|
}
|
|
}
|
|
void set_wrapping(int wrapping_type);
|
|
|
|
void get_area_of_interest(int input_idx, const rcti &output_area, rcti &r_input_area) override;
|
|
|
|
void update_memory_buffer_started(MemoryBuffer *output,
|
|
const rcti &area,
|
|
Span<MemoryBuffer *> inputs) override;
|
|
void update_memory_buffer_partial(MemoryBuffer *output,
|
|
const rcti &area,
|
|
Span<MemoryBuffer *> inputs) override;
|
|
};
|
|
|
|
class TranslateCanvasOperation : public TranslateOperation {
|
|
public:
|
|
TranslateCanvasOperation();
|
|
void determine_canvas(const rcti &preferred_area, rcti &r_area) override;
|
|
};
|
|
|
|
} // namespace blender::compositor
|