Currently, the `eval` and `pdf` are not explicitly set to zero when a BSDF sample is invalid (e.g., below the upper hemisphere), when calling `bsdf_sample` or `bsdf_eval`. It is assumed that `eval` and `pdf` are set to zero before these functions are called, which can cause problems if not. This patch fixes this potential problem by explicitly setting `eval` and `pdf` to zero when the sampled direction is invalid. I also added a sanity check if `eval` and `pdf` are valid (i.e., >= 0.f). The check is activated when build in debug mode and with the `WITH_CYCLES_DEBUG` set to `ON`. Reviewed By: brecht, sergey Differential Revision: https://developer.blender.org/D14776
131 lines
4.1 KiB
C
131 lines
4.1 KiB
C
/* SPDX-License-Identifier: Apache-2.0
|
|
* Copyright 2011-2022 Blender Foundation */
|
|
|
|
#pragma once
|
|
|
|
/* DISNEY PRINCIPLED SHEEN BRDF
|
|
*
|
|
* Shading model by Brent Burley (Disney): "Physically Based Shading at Disney" (2012)
|
|
*/
|
|
|
|
#include "kernel/closure/bsdf_util.h"
|
|
|
|
CCL_NAMESPACE_BEGIN
|
|
|
|
typedef struct PrincipledSheenBsdf {
|
|
SHADER_CLOSURE_BASE;
|
|
float avg_value;
|
|
} PrincipledSheenBsdf;
|
|
|
|
static_assert(sizeof(ShaderClosure) >= sizeof(PrincipledSheenBsdf),
|
|
"PrincipledSheenBsdf is too large!");
|
|
|
|
ccl_device_inline float calculate_avg_principled_sheen_brdf(float3 N, float3 I)
|
|
{
|
|
/* To compute the average, we set the half-vector to the normal, resulting in
|
|
* NdotI = NdotL = NdotV = LdotH */
|
|
float NdotI = dot(N, I);
|
|
if (NdotI < 0.0f) {
|
|
return 0.0f;
|
|
}
|
|
|
|
return schlick_fresnel(NdotI) * NdotI;
|
|
}
|
|
|
|
ccl_device float3
|
|
calculate_principled_sheen_brdf(float3 N, float3 V, float3 L, float3 H, ccl_private float *pdf)
|
|
{
|
|
float NdotL = dot(N, L);
|
|
float NdotV = dot(N, V);
|
|
|
|
if (NdotL < 0 || NdotV < 0) {
|
|
*pdf = 0.0f;
|
|
return make_float3(0.0f, 0.0f, 0.0f);
|
|
}
|
|
|
|
float LdotH = dot(L, H);
|
|
|
|
float value = schlick_fresnel(LdotH) * NdotL;
|
|
|
|
return make_float3(value, value, value);
|
|
}
|
|
|
|
ccl_device int bsdf_principled_sheen_setup(ccl_private const ShaderData *sd,
|
|
ccl_private PrincipledSheenBsdf *bsdf)
|
|
{
|
|
bsdf->type = CLOSURE_BSDF_PRINCIPLED_SHEEN_ID;
|
|
bsdf->avg_value = calculate_avg_principled_sheen_brdf(bsdf->N, sd->I);
|
|
bsdf->sample_weight *= bsdf->avg_value;
|
|
return SD_BSDF | SD_BSDF_HAS_EVAL;
|
|
}
|
|
|
|
ccl_device float3 bsdf_principled_sheen_eval_reflect(ccl_private const ShaderClosure *sc,
|
|
const float3 I,
|
|
const float3 omega_in,
|
|
ccl_private float *pdf)
|
|
{
|
|
ccl_private const PrincipledSheenBsdf *bsdf = (ccl_private const PrincipledSheenBsdf *)sc;
|
|
|
|
float3 N = bsdf->N;
|
|
float3 V = I; // outgoing
|
|
float3 L = omega_in; // incoming
|
|
float3 H = normalize(L + V);
|
|
|
|
if (dot(N, omega_in) > 0.0f) {
|
|
*pdf = fmaxf(dot(N, omega_in), 0.0f) * M_1_PI_F;
|
|
return calculate_principled_sheen_brdf(N, V, L, H, pdf);
|
|
}
|
|
else {
|
|
*pdf = 0.0f;
|
|
return make_float3(0.0f, 0.0f, 0.0f);
|
|
}
|
|
}
|
|
|
|
ccl_device float3 bsdf_principled_sheen_eval_transmit(ccl_private const ShaderClosure *sc,
|
|
const float3 I,
|
|
const float3 omega_in,
|
|
ccl_private float *pdf)
|
|
{
|
|
*pdf = 0.0f;
|
|
return make_float3(0.0f, 0.0f, 0.0f);
|
|
}
|
|
|
|
ccl_device int bsdf_principled_sheen_sample(ccl_private const ShaderClosure *sc,
|
|
float3 Ng,
|
|
float3 I,
|
|
float3 dIdx,
|
|
float3 dIdy,
|
|
float randu,
|
|
float randv,
|
|
ccl_private float3 *eval,
|
|
ccl_private float3 *omega_in,
|
|
ccl_private float3 *domega_in_dx,
|
|
ccl_private float3 *domega_in_dy,
|
|
ccl_private float *pdf)
|
|
{
|
|
ccl_private const PrincipledSheenBsdf *bsdf = (ccl_private const PrincipledSheenBsdf *)sc;
|
|
|
|
float3 N = bsdf->N;
|
|
|
|
sample_cos_hemisphere(N, randu, randv, omega_in, pdf);
|
|
|
|
if (dot(Ng, *omega_in) > 0) {
|
|
float3 H = normalize(I + *omega_in);
|
|
|
|
*eval = calculate_principled_sheen_brdf(N, I, *omega_in, H, pdf);
|
|
|
|
#ifdef __RAY_DIFFERENTIALS__
|
|
// TODO: find a better approximation for the diffuse bounce
|
|
*domega_in_dx = -((2 * dot(N, dIdx)) * N - dIdx);
|
|
*domega_in_dy = -((2 * dot(N, dIdy)) * N - dIdy);
|
|
#endif
|
|
}
|
|
else {
|
|
*eval = make_float3(0.0f, 0.0f, 0.0f);
|
|
*pdf = 0.0f;
|
|
}
|
|
return LABEL_REFLECT | LABEL_DIFFUSE;
|
|
}
|
|
|
|
CCL_NAMESPACE_END
|