There are a couple of functions that create rna pointers. For example `RNA_main_pointer_create` and `RNA_pointer_create`. Currently, those take an output parameter `r_ptr` as last argument. This patch changes it so that the functions actually return a` PointerRNA` instead of using the output parameters. This has a few benefits: * Output parameters should only be used when there is an actual benefit. Otherwise, one should default to returning the value. * It's simpler to use the API in the large majority of cases (note that this patch reduces the number of lines of code). * It allows the `PointerRNA` to be const on the call-site, if that is desired. No performance regression has been measured in production files. If one of these functions happened to be called in a hot loop where there is a regression, the solution should be to use an inline function there which allows the compiler to optimize it even better. Pull Request: https://projects.blender.org/blender/blender/pulls/111976
303 lines
7.4 KiB
C++
303 lines
7.4 KiB
C++
/* SPDX-FileCopyrightText: 2023 Blender Authors
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
#include "usd.h"
|
|
|
|
#include "usd_hook.h"
|
|
|
|
#include <boost/python/call_method.hpp>
|
|
#include <boost/python/class.hpp>
|
|
#include <boost/python/import.hpp>
|
|
#include <boost/python/object.hpp>
|
|
#include <boost/python/return_value_policy.hpp>
|
|
#include <boost/python/to_python_converter.hpp>
|
|
|
|
#include "BLI_listbase.h"
|
|
|
|
#include "RNA_access.hh"
|
|
#include "RNA_prototypes.h"
|
|
#include "RNA_types.hh"
|
|
#include "bpy_rna.h"
|
|
|
|
#include "WM_api.hh"
|
|
#include "WM_types.hh"
|
|
|
|
#include <list>
|
|
|
|
using namespace boost;
|
|
|
|
using USDHookList = std::list<USDHook *>;
|
|
|
|
/* USD hook type declarations */
|
|
static USDHookList g_usd_hooks;
|
|
|
|
void USD_register_hook(USDHook *hook)
|
|
{
|
|
if (std::find(g_usd_hooks.begin(), g_usd_hooks.end(), hook) != g_usd_hooks.end()) {
|
|
/* The hook is already in the list. */
|
|
return;
|
|
}
|
|
|
|
/* Add hook type to the list. */
|
|
g_usd_hooks.push_back(hook);
|
|
}
|
|
|
|
void USD_unregister_hook(USDHook *hook)
|
|
{
|
|
g_usd_hooks.remove(hook);
|
|
}
|
|
|
|
USDHook *USD_find_hook_name(const char name[])
|
|
{
|
|
/* sanity checks */
|
|
if (g_usd_hooks.empty() || (name == nullptr) || (name[0] == 0)) {
|
|
return nullptr;
|
|
}
|
|
|
|
USDHookList::iterator hook_iter = std::find_if(
|
|
g_usd_hooks.begin(), g_usd_hooks.end(), [name](USDHook *hook) {
|
|
return STREQ(hook->idname, name);
|
|
});
|
|
|
|
return (hook_iter == g_usd_hooks.end()) ? nullptr : *hook_iter;
|
|
}
|
|
|
|
namespace blender::io::usd {
|
|
|
|
/* Convert PointerRNA to a PyObject*. */
|
|
struct PointerRNAToPython {
|
|
|
|
/* We pass the argument by value because we need
|
|
* to obtain a non-const pointer to it. */
|
|
static PyObject *convert(PointerRNA ptr)
|
|
{
|
|
return pyrna_struct_CreatePyObject(&ptr);
|
|
}
|
|
};
|
|
|
|
/* Encapsulate arguments for scene export. */
|
|
struct USDSceneExportContext {
|
|
|
|
USDSceneExportContext() : depsgraph_ptr({}) {}
|
|
|
|
USDSceneExportContext(pxr::UsdStageRefPtr in_stage, Depsgraph *depsgraph) : stage(in_stage)
|
|
{
|
|
depsgraph_ptr = RNA_pointer_create(nullptr, &RNA_Depsgraph, depsgraph);
|
|
}
|
|
|
|
pxr::UsdStageRefPtr get_stage()
|
|
{
|
|
return stage;
|
|
}
|
|
|
|
const PointerRNA &get_depsgraph() const
|
|
{
|
|
return depsgraph_ptr;
|
|
}
|
|
|
|
pxr::UsdStageRefPtr stage;
|
|
PointerRNA depsgraph_ptr;
|
|
};
|
|
|
|
/* Encapsulate arguments for material export. */
|
|
struct USDMaterialExportContext {
|
|
USDMaterialExportContext() {}
|
|
|
|
USDMaterialExportContext(pxr::UsdStageRefPtr in_stage) : stage(in_stage) {}
|
|
|
|
pxr::UsdStageRefPtr get_stage()
|
|
{
|
|
return stage;
|
|
}
|
|
|
|
pxr::UsdStageRefPtr stage;
|
|
};
|
|
|
|
void register_export_hook_converters()
|
|
{
|
|
static bool registered = false;
|
|
|
|
/* No need to register if there are no hooks. */
|
|
if (g_usd_hooks.empty()) {
|
|
return;
|
|
}
|
|
|
|
if (registered) {
|
|
return;
|
|
}
|
|
|
|
registered = true;
|
|
|
|
PyGILState_STATE gilstate = PyGILState_Ensure();
|
|
|
|
/* We must import these modules for the USD type converters to work. */
|
|
python::import("pxr.Usd");
|
|
python::import("pxr.UsdShade");
|
|
|
|
/* Register converter from PoinerRNA to a PyObject*. */
|
|
python::to_python_converter<PointerRNA, PointerRNAToPython>();
|
|
|
|
/* Register context class converters. */
|
|
python::class_<USDSceneExportContext>("USDSceneExportContext")
|
|
.def("get_stage", &USDSceneExportContext::get_stage)
|
|
.def("get_depsgraph",
|
|
&USDSceneExportContext::get_depsgraph,
|
|
python::return_value_policy<python::return_by_value>());
|
|
|
|
python::class_<USDMaterialExportContext>("USDMaterialExportContext")
|
|
.def("get_stage", &USDMaterialExportContext::get_stage);
|
|
|
|
PyGILState_Release(gilstate);
|
|
}
|
|
|
|
/* Retrieve and report the current Python error. */
|
|
static void handle_python_error(USDHook *hook)
|
|
{
|
|
if (!PyErr_Occurred()) {
|
|
return;
|
|
}
|
|
|
|
PyErr_Print();
|
|
|
|
WM_reportf(RPT_ERROR,
|
|
"An exception occurred invoking USD hook '%s'. Please see the console for details",
|
|
hook->name);
|
|
}
|
|
|
|
/* Abstract base class to facilitate calling a function with a given
|
|
* signature defined by the registered USDHook classes. Subclasses
|
|
* override virtual methods to specify the hook function name and to
|
|
* call the hook with the required arguments.
|
|
*/
|
|
class USDHookInvoker {
|
|
public:
|
|
/* Attempt to call the function, if defined by the registered hooks. */
|
|
void call() const
|
|
{
|
|
if (g_usd_hooks.empty()) {
|
|
return;
|
|
}
|
|
|
|
PyGILState_STATE gilstate = PyGILState_Ensure();
|
|
|
|
/* Iterate over the hooks and invoke the hook function, if it's defined. */
|
|
USDHookList::const_iterator hook_iter = g_usd_hooks.begin();
|
|
while (hook_iter != g_usd_hooks.end()) {
|
|
|
|
/* XXX: Not sure if this is necessary:
|
|
* Advance the iterator before invoking the callback, to guard
|
|
* against the unlikely error where the hook is de-registered in
|
|
* the callback. This would prevent a crash due to the iterator
|
|
* getting invalidated. */
|
|
USDHook *hook = *hook_iter;
|
|
++hook_iter;
|
|
|
|
if (!hook->rna_ext.data) {
|
|
continue;
|
|
}
|
|
|
|
try {
|
|
PyObject *hook_obj = static_cast<PyObject *>(hook->rna_ext.data);
|
|
|
|
if (!PyObject_HasAttrString(hook_obj, function_name())) {
|
|
continue;
|
|
}
|
|
|
|
call_hook(hook_obj);
|
|
}
|
|
catch (python::error_already_set const &) {
|
|
handle_python_error(hook);
|
|
}
|
|
catch (...) {
|
|
WM_reportf(RPT_ERROR, "An exception occurred invoking USD hook '%s'", hook->name);
|
|
}
|
|
}
|
|
|
|
PyGILState_Release(gilstate);
|
|
}
|
|
|
|
protected:
|
|
/* Override to specify the name of the function to be called. */
|
|
virtual const char *function_name() const = 0;
|
|
/* Override to call the function of the given object with the
|
|
* required arguments, e.g.,
|
|
*
|
|
* python::call_method<void>(hook_obj, function_name(), arg1, arg2); */
|
|
virtual void call_hook(PyObject *hook_obj) const = 0;
|
|
};
|
|
|
|
class OnExportInvoker : public USDHookInvoker {
|
|
private:
|
|
USDSceneExportContext hook_context_;
|
|
|
|
public:
|
|
OnExportInvoker(pxr::UsdStageRefPtr stage, Depsgraph *depsgraph)
|
|
: hook_context_(stage, depsgraph)
|
|
{
|
|
}
|
|
|
|
protected:
|
|
const char *function_name() const override
|
|
{
|
|
return "on_export";
|
|
}
|
|
|
|
void call_hook(PyObject *hook_obj) const override
|
|
{
|
|
python::call_method<bool>(hook_obj, function_name(), hook_context_);
|
|
}
|
|
};
|
|
|
|
class OnMaterialExportInvoker : public USDHookInvoker {
|
|
private:
|
|
USDMaterialExportContext hook_context_;
|
|
pxr::UsdShadeMaterial usd_material_;
|
|
PointerRNA material_ptr_;
|
|
|
|
public:
|
|
OnMaterialExportInvoker(pxr::UsdStageRefPtr stage,
|
|
Material *material,
|
|
pxr::UsdShadeMaterial &usd_material)
|
|
: hook_context_(stage), usd_material_(usd_material)
|
|
{
|
|
material_ptr_ = RNA_pointer_create(nullptr, &RNA_Material, material);
|
|
}
|
|
|
|
protected:
|
|
const char *function_name() const override
|
|
{
|
|
return "on_material_export";
|
|
}
|
|
|
|
void call_hook(PyObject *hook_obj) const override
|
|
{
|
|
python::call_method<bool>(
|
|
hook_obj, function_name(), hook_context_, material_ptr_, usd_material_);
|
|
}
|
|
};
|
|
|
|
void call_export_hooks(pxr::UsdStageRefPtr stage, Depsgraph *depsgraph)
|
|
{
|
|
if (g_usd_hooks.empty()) {
|
|
return;
|
|
}
|
|
|
|
OnExportInvoker on_export(stage, depsgraph);
|
|
on_export.call();
|
|
}
|
|
|
|
void call_material_export_hooks(pxr::UsdStageRefPtr stage,
|
|
Material *material,
|
|
pxr::UsdShadeMaterial &usd_material)
|
|
{
|
|
if (g_usd_hooks.empty()) {
|
|
return;
|
|
}
|
|
|
|
OnMaterialExportInvoker on_material_export(stage, material, usd_material);
|
|
on_material_export.call();
|
|
}
|
|
|
|
} // namespace blender::io::usd
|