b5c89822ac
There are a couple of functions that create rna pointers. For example `RNA_main_pointer_create` and `RNA_pointer_create`. Currently, those take an output parameter `r_ptr` as last argument. This patch changes it so that the functions actually return a` PointerRNA` instead of using the output parameters. This has a few benefits: * Output parameters should only be used when there is an actual benefit. Otherwise, one should default to returning the value. * It's simpler to use the API in the large majority of cases (note that this patch reduces the number of lines of code). * It allows the `PointerRNA` to be const on the call-site, if that is desired. No performance regression has been measured in production files. If one of these functions happened to be called in a hot loop where there is a regression, the solution should be to use an inline function there which allows the compiler to optimize it even better. Pull Request: https://projects.blender.org/blender/blender/pulls/111976
128 lines
3.9 KiB
C++
128 lines
3.9 KiB
C++
/* SPDX-FileCopyrightText: 2015 Blender Authors
|
|
*
|
|
* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
|
|
/** \file
|
|
* \ingroup bke
|
|
*/
|
|
|
|
#include "BKE_action.hh"
|
|
#include "BKE_animsys.h"
|
|
#include "BKE_armature.hh"
|
|
|
|
#include "BLI_function_ref.hh"
|
|
#include "BLI_set.hh"
|
|
|
|
#include "DNA_action_types.h"
|
|
#include "DNA_anim_types.h"
|
|
#include "DNA_armature_types.h"
|
|
#include "DNA_object_types.h"
|
|
|
|
#include "RNA_access.hh"
|
|
|
|
using namespace blender::bke;
|
|
|
|
namespace {
|
|
|
|
using ActionApplier =
|
|
blender::FunctionRef<void(PointerRNA *, bAction *, const AnimationEvalContext *)>;
|
|
|
|
/* Forward declarations. */
|
|
void pose_apply_disable_fcurves_for_unselected_bones(bAction *action,
|
|
const BoneNameSet &selected_bone_names);
|
|
void pose_apply_restore_fcurves(bAction *action);
|
|
|
|
void pose_apply(Object *ob,
|
|
bAction *action,
|
|
AnimationEvalContext *anim_eval_context,
|
|
ActionApplier applier);
|
|
|
|
} // namespace
|
|
|
|
void BKE_pose_apply_action_selected_bones(Object *ob,
|
|
bAction *action,
|
|
AnimationEvalContext *anim_eval_context)
|
|
{
|
|
auto evaluate_and_apply =
|
|
[](PointerRNA *ptr, bAction *act, const AnimationEvalContext *anim_eval_context) {
|
|
animsys_evaluate_action(ptr, act, anim_eval_context, false);
|
|
};
|
|
|
|
pose_apply(ob, action, anim_eval_context, evaluate_and_apply);
|
|
}
|
|
|
|
void BKE_pose_apply_action_all_bones(Object *ob,
|
|
bAction *action,
|
|
AnimationEvalContext *anim_eval_context)
|
|
{
|
|
PointerRNA pose_owner_ptr = RNA_id_pointer_create(&ob->id);
|
|
animsys_evaluate_action(&pose_owner_ptr, action, anim_eval_context, false);
|
|
}
|
|
|
|
void BKE_pose_apply_action_blend(Object *ob,
|
|
bAction *action,
|
|
AnimationEvalContext *anim_eval_context,
|
|
const float blend_factor)
|
|
{
|
|
auto evaluate_and_blend = [blend_factor](PointerRNA *ptr,
|
|
bAction *act,
|
|
const AnimationEvalContext *anim_eval_context) {
|
|
animsys_blend_in_action(ptr, act, anim_eval_context, blend_factor);
|
|
};
|
|
|
|
pose_apply(ob, action, anim_eval_context, evaluate_and_blend);
|
|
}
|
|
|
|
namespace {
|
|
void pose_apply(Object *ob,
|
|
bAction *action,
|
|
AnimationEvalContext *anim_eval_context,
|
|
ActionApplier applier)
|
|
{
|
|
bPose *pose = ob->pose;
|
|
if (pose == nullptr) {
|
|
return;
|
|
}
|
|
|
|
const bArmature *armature = (bArmature *)ob->data;
|
|
const BoneNameSet selected_bone_names = BKE_armature_find_selected_bone_names(armature);
|
|
const bool limit_to_selected_bones = !selected_bone_names.is_empty();
|
|
|
|
if (limit_to_selected_bones) {
|
|
/* Mute all FCurves that are not associated with selected bones. This separates the concept of
|
|
* bone selection from the FCurve evaluation code. */
|
|
pose_apply_disable_fcurves_for_unselected_bones(action, selected_bone_names);
|
|
}
|
|
|
|
/* Apply the Action. */
|
|
PointerRNA pose_owner_ptr = RNA_id_pointer_create(&ob->id);
|
|
|
|
applier(&pose_owner_ptr, action, anim_eval_context);
|
|
|
|
if (limit_to_selected_bones) {
|
|
pose_apply_restore_fcurves(action);
|
|
}
|
|
}
|
|
|
|
void pose_apply_restore_fcurves(bAction *action)
|
|
{
|
|
/* TODO(Sybren): Restore the FCurve flags, instead of just erasing the 'disabled' flag. */
|
|
LISTBASE_FOREACH (FCurve *, fcu, &action->curves) {
|
|
fcu->flag &= ~FCURVE_DISABLED;
|
|
}
|
|
}
|
|
|
|
void pose_apply_disable_fcurves_for_unselected_bones(bAction *action,
|
|
const BoneNameSet &selected_bone_names)
|
|
{
|
|
auto disable_unselected_fcurve = [&](FCurve *fcu, const char *bone_name) {
|
|
const bool is_bone_selected = selected_bone_names.contains(bone_name);
|
|
if (!is_bone_selected) {
|
|
fcu->flag |= FCURVE_DISABLED;
|
|
}
|
|
};
|
|
BKE_action_find_fcurves_with_bones(action, disable_unselected_fcurve);
|
|
}
|
|
|
|
} // namespace
|