griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
Files
81ea699ebf555c1947afca2e73cf10fa90758008
test2/source/blender/blenkernel/intern/action_bones.cc

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

50 lines
1.5 KiB
C++
Raw Normal View History

Cleanup: Add a copyright notice to files and use SPDX format A lot of files were missing copyright field in the header and the Blender Foundation contributed to them in a sense of bug fixing and general maintenance. This change makes it explicit that those files are at least partially copyrighted by the Blender Foundation. Note that this does not make it so the Blender Foundation is the only holder of the copyright in those files, and developers who do not have a signed contract with the foundation still hold the copyright as well. Another aspect of this change is using SPDX format for the header. We already used it for the license specification, and now we state it for the copyright as well, following the FAQ: https://reuse.software/faq/
2023-05-31 16:19:06 +02:00
/* SPDX-FileCopyrightText: 2001-2002 NaN Holding BV. All rights reserved.
*
* SPDX-License-Identifier: GPL-2.0-or-later */
Pose Library: remove assumption about Action group names Remove the assumption of the pose library that Action groups are named after the bones in the armature. Even though this assumption is correct when the keys are created by Blender, action groups can be renamed. Keys created by Python scripts can also use arbitrary group names. Since there is more code in Blender making this assumption, and looping over selected bones is also a common occurrence, this commit contains some generic functionality to aid in this: - `BKE_armature_find_selected_bones`: function that iterates over all bones in an armature and calls a callback for each selected one. It returns a struct with info about the selection states (all or no bones selected). - `BKE_armature_find_selected_bone_names(armature)` uses the above function to return a set of selected bone names. - `BKE_pose_find_fcurves_with_bones()` calls a callback for each FCurve in an Action that targets a bone, also passing it the bone name.
2021-07-20 16:13:14 +02:00
/** \file
* \ingroup bke
*/
#include "BKE_action.hh"
#include "BLI_listbase.h"
#include "BLI_string.h"
#include "DNA_action_types.h"
#include "DNA_anim_types.h"
RNA: support extracting names from paths without allocating memory Support extracting identifiers RNA paths into fixed size buffer since the maximum size of the identifier is known all cases. - Add BLI_str_unescape_ex to support limiting the destination buffer. - Add BLI_str_quoted_substr to copy values into a fixed size buffer.
2021-09-04 14:22:44 +10:00
#include "DNA_armature_types.h"
Pose Library: remove assumption about Action group names Remove the assumption of the pose library that Action groups are named after the bones in the armature. Even though this assumption is correct when the keys are created by Blender, action groups can be renamed. Keys created by Python scripts can also use arbitrary group names. Since there is more code in Blender making this assumption, and looping over selected bones is also a common occurrence, this commit contains some generic functionality to aid in this: - `BKE_armature_find_selected_bones`: function that iterates over all bones in an armature and calls a callback for each selected one. It returns a struct with info about the selection states (all or no bones selected). - `BKE_armature_find_selected_bone_names(armature)` uses the above function to return a set of selected bone names. - `BKE_pose_find_fcurves_with_bones()` calls a callback for each FCurve in an Action that targets a bone, also passing it the bone name.
2021-07-20 16:13:14 +02:00
Anim: make pose library pose blending work with slotted actions This wasn't working because the code that stores the backup up the current pose looped over the pose asset's fcurve listbase to determine which bones needed to be backed up. When the pose asset was stored as a slotted action, that listbase was always empty, so nothing was backed up. This resulted in exploding poses as the pose was repeatedly applied on top of itself, and in debug builds would trigger asserts in code that was sanity-checking quaternion values. This PR updates that code to loop over the fcurves of the first slot when the pose asset is stored as a slotted action, which in turn makes pose blending work as expected with slotted actions. Pull Request: https://projects.blender.org/blender/blender/pulls/128686
2024-10-07 16:13:56 +02:00
#include "ANIM_action_legacy.hh"
Pose Library: remove assumption about Action group names Remove the assumption of the pose library that Action groups are named after the bones in the armature. Even though this assumption is correct when the keys are created by Blender, action groups can be renamed. Keys created by Python scripts can also use arbitrary group names. Since there is more code in Blender making this assumption, and looping over selected bones is also a common occurrence, this commit contains some generic functionality to aid in this: - `BKE_armature_find_selected_bones`: function that iterates over all bones in an armature and calls a callback for each selected one. It returns a struct with info about the selection states (all or no bones selected). - `BKE_armature_find_selected_bone_names(armature)` uses the above function to return a set of selected bone names. - `BKE_pose_find_fcurves_with_bones()` calls a callback for each FCurve in an Action that targets a bone, also passing it the bone name.
2021-07-20 16:13:14 +02:00
#include "MEM_guardedalloc.h"
namespace blender::bke {
Anim: make pose library pose blending work with slotted actions This wasn't working because the code that stores the backup up the current pose looped over the pose asset's fcurve listbase to determine which bones needed to be backed up. When the pose asset was stored as a slotted action, that listbase was always empty, so nothing was backed up. This resulted in exploding poses as the pose was repeatedly applied on top of itself, and in debug builds would trigger asserts in code that was sanity-checking quaternion values. This PR updates that code to loop over the fcurves of the first slot when the pose asset is stored as a slotted action, which in turn makes pose blending work as expected with slotted actions. Pull Request: https://projects.blender.org/blender/blender/pulls/128686
2024-10-07 16:13:56 +02:00
void BKE_action_find_fcurves_with_bones(bAction *action, FoundFCurveCallback callback)
Pose Library: remove assumption about Action group names Remove the assumption of the pose library that Action groups are named after the bones in the armature. Even though this assumption is correct when the keys are created by Blender, action groups can be renamed. Keys created by Python scripts can also use arbitrary group names. Since there is more code in Blender making this assumption, and looping over selected bones is also a common occurrence, this commit contains some generic functionality to aid in this: - `BKE_armature_find_selected_bones`: function that iterates over all bones in an armature and calls a callback for each selected one. It returns a struct with info about the selection states (all or no bones selected). - `BKE_armature_find_selected_bone_names(armature)` uses the above function to return a set of selected bone names. - `BKE_pose_find_fcurves_with_bones()` calls a callback for each FCurve in an Action that targets a bone, also passing it the bone name.
2021-07-20 16:13:14 +02:00
{
Anim: make pose library pose blending work with slotted actions This wasn't working because the code that stores the backup up the current pose looped over the pose asset's fcurve listbase to determine which bones needed to be backed up. When the pose asset was stored as a slotted action, that listbase was always empty, so nothing was backed up. This resulted in exploding poses as the pose was repeatedly applied on top of itself, and in debug builds would trigger asserts in code that was sanity-checking quaternion values. This PR updates that code to loop over the fcurves of the first slot when the pose asset is stored as a slotted action, which in turn makes pose blending work as expected with slotted actions. Pull Request: https://projects.blender.org/blender/blender/pulls/128686
2024-10-07 16:13:56 +02:00
auto const_callback = [&](const FCurve *fcurve, const char *bone_name) {
callback(const_cast<FCurve *>(fcurve), bone_name);
};
BKE_action_find_fcurves_with_bones(const_cast<const bAction *>(action), const_callback);
}
void BKE_action_find_fcurves_with_bones(const bAction *action, FoundFCurveCallbackConst callback)
{
/* As of writing this comment, this is only ever used in the pose library
* code, where actions are only supposed to have one slot. If either it
* starts getting used elsewhere or the pose library starts using multiple
* slots, this will need to be updated. */
const animrig::slot_handle_t slot_handle = animrig::first_slot_handle(*action);
for (const FCurve *fcu : animrig::legacy::fcurves_for_action_slot(action, slot_handle)) {
RNA: support extracting names from paths without allocating memory Support extracting identifiers RNA paths into fixed size buffer since the maximum size of the identifier is known all cases. - Add BLI_str_unescape_ex to support limiting the destination buffer. - Add BLI_str_quoted_substr to copy values into a fixed size buffer.
2021-09-04 14:22:44 +10:00
char bone_name[MAXBONENAME];
if (!BLI_str_quoted_substr(fcu->rna_path, "pose.bones[", bone_name, sizeof(bone_name))) {
Pose Library: remove assumption about Action group names Remove the assumption of the pose library that Action groups are named after the bones in the armature. Even though this assumption is correct when the keys are created by Blender, action groups can be renamed. Keys created by Python scripts can also use arbitrary group names. Since there is more code in Blender making this assumption, and looping over selected bones is also a common occurrence, this commit contains some generic functionality to aid in this: - `BKE_armature_find_selected_bones`: function that iterates over all bones in an armature and calls a callback for each selected one. It returns a struct with info about the selection states (all or no bones selected). - `BKE_armature_find_selected_bone_names(armature)` uses the above function to return a set of selected bone names. - `BKE_pose_find_fcurves_with_bones()` calls a callback for each FCurve in an Action that targets a bone, also passing it the bone name.
2021-07-20 16:13:14 +02:00
continue;
}
callback(fcu, bone_name);
}
}
} // namespace blender::bke
Reference in New Issue Copy Permalink