diff --git a/source/blender/makesrna/intern/rna_wm_api.cc b/source/blender/makesrna/intern/rna_wm_api.cc index 0834d4cc0aa..24f02917c7c 100644 --- a/source/blender/makesrna/intern/rna_wm_api.cc +++ b/source/blender/makesrna/intern/rna_wm_api.cc @@ -123,10 +123,10 @@ static bool rna_event_modal_handler_add(bContext *C, ReportList *reports, wmOper return WM_event_add_modal_handler_ex(win, area, region, op) != nullptr; } -/* XXX, need a way for python to know event types, 0x0110 is hard coded */ static wmTimer *rna_event_timer_add(wmWindowManager *wm, float time_step, wmWindow *win) { - return WM_event_timer_add(wm, win, 0x0110, time_step); + /* NOTE: we need a way for Python to know event types, `TIMER` is hard coded. */ + return WM_event_timer_add(wm, win, TIMER, time_step); } static void rna_event_timer_remove(wmWindowManager *wm, wmTimer *timer) diff --git a/source/blender/windowmanager/intern/wm_event_system.cc b/source/blender/windowmanager/intern/wm_event_system.cc index 4907b39ed2d..41d8e68cc62 100644 --- a/source/blender/windowmanager/intern/wm_event_system.cc +++ b/source/blender/windowmanager/intern/wm_event_system.cc @@ -874,7 +874,7 @@ void wm_event_handler_ui_cancel_ex(bContext *C, wmEvent event; wm_event_init_from_window(win, &event); event.type = EVT_BUT_CANCEL; - event.val = reactivate_button ? 0 : 1; + event.val = reactivate_button ? KM_NOTHING : KM_PRESS; event.flag = (eWM_EventFlag)0; handler->handle_fn(C, &event, handler->user_data); } @@ -4888,7 +4888,7 @@ void WM_event_add_mousemove(wmWindow *win) /** * \return The WM enum for key or #EVENT_NONE (which should be ignored). */ -static int convert_key(GHOST_TKey key) +static int wm_event_type_from_ghost_key(GHOST_TKey key) { if (key >= GHOST_kKeyA && key <= GHOST_kKeyZ) { return (EVT_AKEY + (int(key) - GHOST_kKeyA)); @@ -5683,7 +5683,7 @@ void wm_event_add_ghostevent(wmWindowManager *wm, case GHOST_kEventKeyDown: case GHOST_kEventKeyUp: { const GHOST_TEventKeyData *kd = static_cast(customdata); - event.type = convert_key(kd->key); + event.type = wm_event_type_from_ghost_key(kd->key); if (UNLIKELY(event.type == EVENT_NONE)) { break; }