diff --git a/source/blender/compositor/realtime_compositor/intern/evaluator.cc b/source/blender/compositor/realtime_compositor/intern/evaluator.cc index 1b52e1d381d..f8c63cd7f6e 100644 --- a/source/blender/compositor/realtime_compositor/intern/evaluator.cc +++ b/source/blender/compositor/realtime_compositor/intern/evaluator.cc @@ -161,7 +161,7 @@ void Evaluator::compile_and_evaluate_shader_compile_unit(CompileState &compile_s void Evaluator::map_shader_operation_inputs_to_their_results(ShaderOperation *operation, CompileState &compile_state) { - for (const auto &item : operation->get_inputs_to_linked_outputs_map().items()) { + for (const auto item : operation->get_inputs_to_linked_outputs_map().items()) { Result &result = compile_state.get_result_from_output_socket(item.value); operation->map_input_to_result(item.key, &result); } diff --git a/source/blender/compositor/realtime_compositor/intern/shader_operation.cc b/source/blender/compositor/realtime_compositor/intern/shader_operation.cc index b4976e5eff0..e85075f59cd 100644 --- a/source/blender/compositor/realtime_compositor/intern/shader_operation.cc +++ b/source/blender/compositor/realtime_compositor/intern/shader_operation.cc @@ -81,7 +81,7 @@ Map &ShaderOperation::get_inputs_to_linked_outputs_m void ShaderOperation::compute_results_reference_counts(const Schedule &schedule) { - for (const auto &item : output_sockets_to_output_identifiers_map_.items()) { + for (const auto item : output_sockets_to_output_identifiers_map_.items()) { const int reference_count = number_of_inputs_linked_to_output_conditioned( item.key, [&](DInputSocket input) { return schedule.contains(input.node()); }); diff --git a/source/blender/draw/intern/draw_manager_shader.c b/source/blender/draw/intern/draw_manager_shader.c index 61900825d7b..c7c3cc6b718 100644 --- a/source/blender/draw/intern/draw_manager_shader.c +++ b/source/blender/draw/intern/draw_manager_shader.c @@ -118,7 +118,7 @@ static void drw_deferred_shader_compilation_exec( BLI_spin_lock(&comp->list_lock); /* Pop tail because it will be less likely to lock the main thread * if all GPUMaterials are to be freed (see DRW_deferred_shader_remove()). */ - LinkData *link = (LinkData *)BLI_poptail(&comp->optimize_queue); + link = (LinkData *)BLI_poptail(&comp->optimize_queue); GPUMaterial *optimize_mat = link ? (GPUMaterial *)link->data : NULL; if (optimize_mat) { /* Avoid another thread freeing the material during optimization. */ diff --git a/source/blender/editors/sculpt_paint/sculpt.cc b/source/blender/editors/sculpt_paint/sculpt.cc index 59bf3f04dd6..6b5e2438068 100644 --- a/source/blender/editors/sculpt_paint/sculpt.cc +++ b/source/blender/editors/sculpt_paint/sculpt.cc @@ -2715,7 +2715,7 @@ void SCULPT_brush_strength_color(SculptSession *ss, void SCULPT_calc_vertex_displacement(SculptSession *ss, const Brush *brush, - float rgba[4], + float rgba[3], float out_offset[3]) { mul_v3_fl(rgba, ss->cache->bstrength); diff --git a/source/blender/gpu/opengl/gl_shader.hh b/source/blender/gpu/opengl/gl_shader.hh index 178b10c254a..17e4339e130 100644 --- a/source/blender/gpu/opengl/gl_shader.hh +++ b/source/blender/gpu/opengl/gl_shader.hh @@ -47,7 +47,7 @@ class GLShader : public Shader { void fragment_shader_from_glsl(MutableSpan sources) override; void compute_shader_from_glsl(MutableSpan sources) override; bool finalize(const shader::ShaderCreateInfo *info = nullptr) override; - void warm_cache(int limit) override{}; + void warm_cache(int /*limit*/) override{}; std::string resources_declare(const shader::ShaderCreateInfo &info) const override; std::string vertex_interface_declare(const shader::ShaderCreateInfo &info) const override; diff --git a/source/blender/nodes/intern/geometry_nodes_log.cc b/source/blender/nodes/intern/geometry_nodes_log.cc index a57bfad7a79..c1d8a8f81b3 100644 --- a/source/blender/nodes/intern/geometry_nodes_log.cc +++ b/source/blender/nodes/intern/geometry_nodes_log.cc @@ -330,7 +330,7 @@ void GeoTreeLog::ensure_used_named_attributes() GeoTreeLog &child_log = modifier_log_->get_tree_log(child_hash); child_log.ensure_used_named_attributes(); if (const std::optional &group_node_id = child_log.tree_loggers_[0]->group_node_id) { - for (const auto &item : child_log.used_named_attributes.items()) { + for (const auto item : child_log.used_named_attributes.items()) { add_attribute(*group_node_id, item.key, item.value); } }