griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Refactor: convert BVH importer to use the current Action API

Browse Source 
Use the current API (i.e. not the to-be-deleted-in-5.0 one) to import
F-Curves from BVH files.

No functional changes.

This is part of #146586

Pull Request: https://projects.blender.org/blender/blender/pulls/147060
This commit is contained in:
Sybren A. Stüvel
2025-09-22 17:31:33 +02:00
parent 3171a22dfd
commit 0b978a20e7
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
scripts/addons_core/io_anim_bvh/import_bvh.py
View File

@@ -7,6 +7,7 @@ from math import radians, ceil
import bpy import bpy
from bpy.app.translations import pgettext_tip as tip_ from bpy.app.translations import pgettext_tip as tip_
from mathutils import Vector, Euler, Matrix from mathutils import Vector, Euler, Matrix
from bpy_extras import anim_utils
class BVH_Node: class BVH_Node:
@@ -525,6 +526,7 @@ def bvh_node_dict2armature(
# imported Actions while keeping Slot auto-assignment, which means that # imported Actions while keeping Slot auto-assignment, which means that
# all Actions should use the same slot name. # all Actions should use the same slot name.
action_slot = action.slots.new(arm_ob.id_type, "Slot") action_slot = action.slots.new(arm_ob.id_type, "Slot")
channelbag = anim_utils.action_ensure_channelbag_for_slot(action, action_slot)
arm_ob_adt.action = action arm_ob_adt.action = action
arm_ob_adt.action_slot = action_slot arm_ob_adt.action_slot = action_slot
@@ -587,7 +589,7 @@ def bvh_node_dict2armature(
# For each location x, y, z. # For each location x, y, z.
for axis_i in range(3): for axis_i in range(3):
curve = action.fcurves.new(data_path=data_path, index=axis_i, action_group=bvh_node.name) curve = channelbag.fcurves.new(data_path=data_path, index=axis_i, group_name=bvh_node.name)
keyframe_points = curve.keyframe_points keyframe_points = curve.keyframe_points
keyframe_points.add(num_frame) keyframe_points.add(num_frame)
@@ -631,7 +633,7 @@ def bvh_node_dict2armature(
# For each euler angle x, y, z (or quaternion w, x, y, z). # For each euler angle x, y, z (or quaternion w, x, y, z).
for axis_i in range(len(rotate[0])): for axis_i in range(len(rotate[0])):
curve = action.fcurves.new(data_path=data_path, index=axis_i, action_group=bvh_node.name) curve = channelbag.fcurves.new(data_path=data_path, index=axis_i, group_name=bvh_node.name)
keyframe_points = curve.keyframe_points keyframe_points = curve.keyframe_points
keyframe_points.add(num_frame) keyframe_points.add(num_frame)
@@ -641,7 +643,7 @@ def bvh_node_dict2armature(
rotate[frame_i][axis_i], rotate[frame_i][axis_i],
) )
for cu in action.fcurves: for cu in channelbag.fcurves:
if IMPORT_LOOP: if IMPORT_LOOP:
pass # 2.5 doenst have cyclic now? pass # 2.5 doenst have cyclic now?