From d08c4e8cc9403a91468df98cc5c7a6d55525939d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sybren=20A=2E=20St=C3=BCvel?= Date: Thu, 3 Jul 2025 11:57:33 +0200 Subject: [PATCH] Fix: Overlay: Invalid RGB order in overlay theme colors Fix an accidental swap of the green & blue channel when drawing theme- colored elements in the overlay engine. Thanks @fclem for finding the issue. Pull Request: https://projects.blender.org/blender/blender/pulls/141382 --- source/blender/draw/engines/overlay/overlay_instance.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/blender/draw/engines/overlay/overlay_instance.cc b/source/blender/draw/engines/overlay/overlay_instance.cc index 05aae40207a..a7ff33007ec 100644 --- a/source/blender/draw/engines/overlay/overlay_instance.cc +++ b/source/blender/draw/engines/overlay/overlay_instance.cc @@ -237,7 +237,7 @@ void Resources::update_theme_settings(const DRWContext *ctx, const State &state) using namespace math; UniformData &gb = theme; - auto rgba_uchar_to_float = [](uchar r, uchar b, uchar g, uchar a) { + auto rgba_uchar_to_float = [](uchar r, uchar g, uchar b, uchar a) { return float4(r, g, b, a) / 255.0f; };