From 29ab328f35a4648ef3b55918230c3252bb721b34 Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Tue, 20 May 2025 11:15:35 +1000 Subject: [PATCH] CMake: use "mode" argument for messages While it's optional, include by convention and helps to clarify the purpose of a message. --- CMakeLists.txt | 4 +++- build_files/cmake/platform/platform_win32.cmake | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index a48a3c757f4..24c01d06961 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1043,7 +1043,9 @@ if(WITH_COMPILER_CODE_COVERAGE) set(_code_coverage_defaults "-fprofile-instr-generate -fcoverage-mapping") endif() else() - message("unsupported compiler ${CMAKE_C_COMPILER_ID} for WITH_COMPILER_CODE_COVERAGE, disabling.") + message(WARNING + "unsupported compiler ${CMAKE_C_COMPILER_ID} for WITH_COMPILER_CODE_COVERAGE, disabling." + ) set(WITH_COMPILER_CODE_COVERAGE OFF) endif() diff --git a/build_files/cmake/platform/platform_win32.cmake b/build_files/cmake/platform/platform_win32.cmake index ff5d18f8bf1..ab56cca282f 100644 --- a/build_files/cmake/platform/platform_win32.cmake +++ b/build_files/cmake/platform/platform_win32.cmake @@ -208,7 +208,7 @@ if(WITH_COMPILER_ASAN AND MSVC AND NOT MSVC_CLANG) string(APPEND CMAKE_EXE_LINKER_FLAGS_DEBUG " /INCREMENTAL:NO") string(APPEND CMAKE_SHARED_LINKER_FLAGS_DEBUG " /INCREMENTAL:NO") else() - message("-- ASAN not supported on MSVC ${CMAKE_CXX_COMPILER_VERSION}") + message(WARNING "ASAN not supported on MSVC ${CMAKE_CXX_COMPILER_VERSION}") endif() endif()