griefith/test2
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix #148142: Cannot interact with normal windows (GNOME 48.4)

Browse Source 
Resolve regression with GNOME-48 & LIBDECOR caused by fix for GNOME-49
(see !148104).

New normal (non-maximized) windows were not refreshing and ignored
cursor input. Workaround the issue be resetting the title.

See code-comments for details.

Ref !148178
This commit is contained in:
Campbell Barton
2025-10-16 02:28:38 +00:00
parent a8e64f9a22
commit 3099cd2124
1 changed files with 25 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
intern/ghost/intern/GHOST_WindowWayland.cc
View File

@@ -1034,7 +1034,31 @@ static void gwl_window_frame_update_from_pending_no_lock(GWL_Window *win)
if (decor.initial_configure_seen == false) {
decor.initial_configure_seen = true;
if (decor.initial_configure_state) {
gwl_libdecor_window_initial_configure_state_set(&decor, gwl_window_state_get(win));
const GHOST_TWindowState state_current = gwl_window_state_get(win);
const GHOST_TWindowState state = decor.initial_configure_state.value();
gwl_libdecor_window_initial_configure_state_set(&decor, state_current);
/* An unfortunate hack for GNOME-48 and older.
* It's necessary to force the window to refresh,
* otherwise the window cannot be interacted with, see: #148142.
*
* Since there doesn't seem to a be a way to request an
* update directly: reset the title to force an update.
*
* Note that temporarily maximizing the window also works
* but this is more likely to flicker on startup.
*
* Interestingly the other call to #gwl_libdecor_window_initial_configure_state_set
* would also suffer from this problem with GNOME-49 but in that case
* committing the surface resolves the problem. */
if (((state == state_current) && (state == GHOST_kWindowStateNormal))) {
/* Ensure the title changes. */
const std::string &title = win->title;
const char *title_swap = " ";
libdecor_frame_set_title(decor.frame, title_swap + (title.empty() ? 0 : 1));
libdecor_frame_set_title(decor.frame, title.c_str());
}
}
}