From 3d450045528f70d110eeae8d64fc441dc2000995 Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Sat, 13 May 2023 17:34:17 +1000 Subject: [PATCH] Fix tangent layer extraction using an empty attribute name The attribute name was always "" as the size argument was `sizeof(char)` instead of the buffer length. --- .../blender/draw/intern/mesh_extractors/extract_mesh_vbo_tan.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_tan.cc b/source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_tan.cc index 91dfad3dfb6..274bbb8db36 100644 --- a/source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_tan.cc +++ b/source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_tan.cc @@ -139,7 +139,7 @@ static void extract_tan_init_common(const MeshRenderData *mr, char attr_name[32], attr_safe_name[GPU_MAX_SAFE_ATTR_NAME]; const char *layer_name = CustomData_get_layer_name(r_loop_data, CD_TANGENT, 0); GPU_vertformat_safe_attr_name(layer_name, attr_safe_name, GPU_MAX_SAFE_ATTR_NAME); - BLI_snprintf(attr_name, sizeof(*attr_name), "t%s", attr_safe_name); + SNPRINTF(attr_name, "t%s", attr_safe_name); GPU_vertformat_attr_add(format, attr_name, comp_type, 4, fetch_mode); GPU_vertformat_alias_add(format, "t"); GPU_vertformat_alias_add(format, "at");