diff --git a/source/blender/editors/interface/interface_template_node_tree_interface.cc b/source/blender/editors/interface/interface_template_node_tree_interface.cc index 7ca605c9fc4..32551388f5d 100644 --- a/source/blender/editors/interface/interface_template_node_tree_interface.cc +++ b/source/blender/editors/interface/interface_template_node_tree_interface.cc @@ -153,6 +153,8 @@ class NodeSocketViewItem : public BasicTreeViewItem { } bool rename(const bContext &C, StringRefNull new_name) override { + MEM_SAFE_FREE(socket_.name); + socket_.name = BLI_strdup(new_name.c_str()); nodetree_.tree_interface.tag_items_changed(); ED_node_tree_propagate_change(&C, CTX_data_main(&C), &nodetree_); @@ -210,6 +212,8 @@ class NodePanelViewItem : public BasicTreeViewItem { } bool rename(const bContext &C, StringRefNull new_name) override { + MEM_SAFE_FREE(panel_.name); + panel_.name = BLI_strdup(new_name.c_str()); nodetree_.tree_interface.tag_items_changed(); ED_node_tree_propagate_change(&C, CTX_data_main(&C), &nodetree_); diff --git a/source/blender/editors/sculpt_paint/sculpt_ops.cc b/source/blender/editors/sculpt_paint/sculpt_ops.cc index 90c44dd1efd..7adc5e110dd 100644 --- a/source/blender/editors/sculpt_paint/sculpt_ops.cc +++ b/source/blender/editors/sculpt_paint/sculpt_ops.cc @@ -748,7 +748,7 @@ static void do_mask_by_color_contiguous_update_node(Object *ob, const float new_mask = mask_by_color_floodfill[vd.index]; const float mask = sculpt_mask_by_color_final_mask_get( current_mask, new_mask, invert, preserve_mask); - if (current_mask == current_mask) { + if (current_mask == mask) { continue; } @@ -861,7 +861,7 @@ static void do_mask_by_color_task(Object *ob, const float new_mask = sculpt_mask_by_color_delta_get(active_color, col, threshold, invert); const float mask = sculpt_mask_by_color_final_mask_get( current_mask, new_mask, invert, preserve_mask); - if (current_mask == vd.mask) { + if (current_mask == mask) { continue; }