From 748135539725a13bb3655f2e622bcd492aaa01bd Mon Sep 17 00:00:00 2001 From: Campbell Barton Date: Thu, 2 Jan 2025 15:11:15 +1100 Subject: [PATCH] Cleanup: scripts, unused variables & re-declaring built-ins --- doc/python_api/examples/bpy.types.USDHook.py | 4 ++-- scripts/startup/bl_ui/properties_render.py | 2 -- scripts/startup/bl_ui/space_userpref.py | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/doc/python_api/examples/bpy.types.USDHook.py b/doc/python_api/examples/bpy.types.USDHook.py index 667295b9676..caf4c54c6fb 100644 --- a/doc/python_api/examples/bpy.types.USDHook.py +++ b/doc/python_api/examples/bpy.types.USDHook.py @@ -307,8 +307,8 @@ class USDHookExample(bpy.types.USDHook): source = surf_output.GetConnectedSource() # Get the shader prim from the source shader = UsdShade.Shader(source[0]) - id = shader.GetShaderId() - if id != "ND_standard_surface_surfaceshader": + shader_id = shader.GetShaderId() + if shader_id != "ND_standard_surface_surfaceshader": return False color_attr = shader.GetInput("base_color") diff --git a/scripts/startup/bl_ui/properties_render.py b/scripts/startup/bl_ui/properties_render.py index e8b3d79aa83..54174646935 100644 --- a/scripts/startup/bl_ui/properties_render.py +++ b/scripts/startup/bl_ui/properties_render.py @@ -775,8 +775,6 @@ class CompositorDenoisePerformanceButtonsPanel: layout.use_property_decorate = False col = layout.column() - row = col.row() - col.prop(rd, "compositor_denoise_preview_quality", text="Preview Quality") col.prop(rd, "compositor_denoise_final_quality", text="Final Quality") diff --git a/scripts/startup/bl_ui/space_userpref.py b/scripts/startup/bl_ui/space_userpref.py index f8451af4ce0..8901fd73ca8 100644 --- a/scripts/startup/bl_ui/space_userpref.py +++ b/scripts/startup/bl_ui/space_userpref.py @@ -2762,7 +2762,7 @@ class USERPREF_PT_studiolight_light_editor(StudioLightPanel, Panel): flow = layout.grid_flow(row_major=True, columns=2, even_rows=True, even_columns=True) flow.active = system.use_studio_light_edit - for i, light in enumerate(system.solid_lights): + for light in system.solid_lights: self.opengl_light_buttons(flow, light) layout.prop(system, "light_ambient")