From 7baa22b49d5fd83fa2454cc4aaafd91518ecb69a Mon Sep 17 00:00:00 2001 From: Hans Goudey Date: Mon, 9 Dec 2024 14:26:08 -0500 Subject: [PATCH] Cleanup: Correct usage of std::unique_ptr in Line Art code `.release()` is technically fine but semantically wrong here. First, release is meant to take ownership from the unique_ptr, meaning at best it's "weird" to not do anything with the pointer afterwards. Second, the runtime struct with the unique_ptr was just default constructed, which means the unique_ptr will be empty anyway. --- source/blender/modifiers/intern/MOD_lineart.cc | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/source/blender/modifiers/intern/MOD_lineart.cc b/source/blender/modifiers/intern/MOD_lineart.cc index 13868fc0666..930893529a6 100644 --- a/source/blender/modifiers/intern/MOD_lineart.cc +++ b/source/blender/modifiers/intern/MOD_lineart.cc @@ -100,11 +100,8 @@ static void copy_data(const ModifierData *md, ModifierData *target, const int fl blender::Set *object_dependencies = source_runtime->object_dependencies.get(); if (object_dependencies) { - target_runtime->object_dependencies.reset( - new blender::Set(*object_dependencies)); - } - else { - target_runtime->object_dependencies.release(); + target_runtime->object_dependencies = std::make_unique>( + object_dependencies); } }