From 7d37bd3841c0d2d91323a460b108bd10b44ebe4e Mon Sep 17 00:00:00 2001
From: Brecht Van Lommel <brecht@blender.org>
Date: Sun, 26 Jan 2025 20:07:58 +0100
Subject: [PATCH] Cleanup: Various clang-tidy warnings in ikplugin

Pull Request: https://projects.blender.org/blender/blender/pulls/133734
---
 source/blender/ikplugin/intern/ikplugin_api.h     | 2 +-
 source/blender/ikplugin/intern/iksolver_plugin.cc | 3 +--
 source/blender/ikplugin/intern/itasc_plugin.cc    | 7 ++-----
 3 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/source/blender/ikplugin/intern/ikplugin_api.h b/source/blender/ikplugin/intern/ikplugin_api.h
index d5b7c286833..a9007e7f5f3 100644
--- a/source/blender/ikplugin/intern/ikplugin_api.h
+++ b/source/blender/ikplugin/intern/ikplugin_api.h
@@ -34,7 +34,7 @@ struct IKPlugin {
   void (*test_constraint)(struct Object *ob, struct bConstraint *cons);
 };
 
-typedef struct IKPlugin IKPlugin;
+using IKPlugin = struct IKPlugin;
 
 #ifdef __cplusplus
 }
diff --git a/source/blender/ikplugin/intern/iksolver_plugin.cc b/source/blender/ikplugin/intern/iksolver_plugin.cc
index a490a8391a0..337773ca157 100644
--- a/source/blender/ikplugin/intern/iksolver_plugin.cc
+++ b/source/blender/ikplugin/intern/iksolver_plugin.cc
@@ -11,11 +11,10 @@
 #include "MEM_guardedalloc.h"
 
 #include "BIK_api.h"
-#include "BLI_blenlib.h"
+#include "BLI_listbase.h"
 #include "BLI_math_matrix.h"
 #include "BLI_math_rotation.h"
 #include "BLI_math_vector.h"
-#include "BLI_utildefines.h"
 #include "BLI_vector.hh"
 
 #include "BKE_armature.hh"
diff --git a/source/blender/ikplugin/intern/itasc_plugin.cc b/source/blender/ikplugin/intern/itasc_plugin.cc
index ffa7d8f090c..50398a6e2be 100644
--- a/source/blender/ikplugin/intern/itasc_plugin.cc
+++ b/source/blender/ikplugin/intern/itasc_plugin.cc
@@ -27,16 +27,13 @@
 #include "MEM_guardedalloc.h"
 
 #include "BIK_api.h"
-#include "BLI_blenlib.h"
 #include "BLI_math_matrix.h"
 #include "BLI_math_rotation.h"
 #include "BLI_math_vector.h"
-#include "BLI_utildefines.h"
 
 #include "BKE_action.hh"
 #include "BKE_armature.hh"
 #include "BKE_constraint.h"
-#include "BKE_global.hh"
 #include "DNA_action_types.h"
 #include "DNA_armature_types.h"
 #include "DNA_constraint_types.h"
@@ -564,7 +561,7 @@ static bool target_callback(const iTaSC::Timestamp & /*timestamp*/,
   IK_Target *target = (IK_Target *)param;
   /* compute next target position
    * get target matrix from constraint. */
-  bConstraint *constraint = (bConstraint *)target->blenderConstraint;
+  bConstraint *constraint = target->blenderConstraint;
   float tarmat[4][4];
 
   BKE_constraint_target_matrix_get(target->bldepsgraph,
@@ -1435,7 +1432,7 @@ static IK_Scene *convert_tree(
   /* for each target, we need to add an end effector in the armature */
   for (numtarget = 0, polarcon = nullptr, ret = true, target = (PoseTarget *)tree->targets.first;
        target;
-       target = (PoseTarget *)target->next)
+       target = target->next)
   {
     condata = (bKinematicConstraint *)target->con->data;
     pchan = tree->pchan[target->tip];