VSE: Execute modifiers in strip-local space (#145688)

Browse Source

Currently when a strip has a transform that does not fill the whole
render area, first the image of the strip is transformed, and then
any modifiers are applied on that. This is mostly in the new
Compositor modifier, where procedural textures, gradients, image
coordinates "stick to the screen" instead of following the transformed
strip.

This changes the behavior so that first the modifiers are applied
to the strip image, and then the strip is transformed. This is
potentially a visually breaking change:
- This can alter visual look of existing strip, especially if they are
  scaled. Previous behavior was first scale filtering, then modifier;
  now it is first modifier, then scale filtering.
- Most obvious change is Compositor modifier (which is new in 5.0).
- Compositor modifier can actually expand the input image (e.g. Blur
  node with "expand bounds" option set), and that works.
- Note that Masks continue to be applied in global/screen space. There
  can be small look differences with rotated/scaled strips that use
  masks, due to Mask application now needing to do filtered mask image
  lookups.
- If anyone needs previous behavior (modifier is applied on the
  "whole screen"), they can put transformed strip into a meta strip,
  and apply the modifier on the meta strip itself.

Compositor modifier examples with images in the PR.

Pull Request: https://projects.blender.org/blender/blender/pulls/146181

...

This commit is contained in:

Aras Pranckevicius

2025-10-07 13:51:41 +02:00

committed by Aras Pranckevicius

parent f145e1f7e2

commit 8a74f7c0b0

33 changed files with 798 additions and 532 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

BIN

tests/files/sequence_editing/effects/mod_comp_blur_expand.blend (Stored with Git LFS) Normal file

Binary file not shown.

BIN

tests/files/sequence_editing/effects/reference/adjustment_layer_stack.png (Stored with Git LFS)

Binary file not shown.

BIN

tests/files/sequence_editing/effects/reference/mod_bright_contrast.png (Stored with Git LFS)

Binary file not shown.

BIN

tests/files/sequence_editing/effects/reference/mod_colorbalance.png (Stored with Git LFS)

Binary file not shown.

BIN

tests/files/sequence_editing/effects/reference/mod_comp.png (Stored with Git LFS)

Binary file not shown.

BIN

tests/files/sequence_editing/effects/reference/mod_comp_blur_expand.png (Stored with Git LFS) Normal file

Binary file not shown.

BIN

tests/files/sequence_editing/effects/reference/mod_curves.png (Stored with Git LFS)

Binary file not shown.

BIN

tests/files/sequence_editing/effects/reference/mod_huecorrect.png (Stored with Git LFS)

Binary file not shown.

BIN

tests/files/sequence_editing/effects/reference/mod_mask.png (Stored with Git LFS)

Binary file not shown.

BIN

tests/files/sequence_editing/effects/reference/mod_mask_id.png (Stored with Git LFS)

Binary file not shown.

BIN

tests/files/sequence_editing/effects/reference/mod_mask_id_rot.png (Stored with Git LFS)

Binary file not shown.

BIN

tests/files/sequence_editing/effects/reference/mod_tonemap.png (Stored with Git LFS)

Binary file not shown.

BIN

tests/files/sequence_editing/effects/reference/mod_whitebalance.png (Stored with Git LFS)

Binary file not shown.

BIN

tests/files/sequence_editing/effects/reference/text_outline_stack.png (Stored with Git LFS)

Binary file not shown.